From 5bbda2a68eda8971c340f9ba9c70359f0867dc3a Mon Sep 17 00:00:00 2001 From: Nate Weaver Date: Mon, 24 Feb 2020 12:15:04 -0600 Subject: [PATCH] "footnotes" -> ".footnotes"; use idFromHash() --- Shared/Article Rendering/newsfoot.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Shared/Article Rendering/newsfoot.js b/Shared/Article Rendering/newsfoot.js index 99e80e15b..296c74d0b 100644 --- a/Shared/Article Rendering/newsfoot.js +++ b/Shared/Article Rendering/newsfoot.js @@ -152,11 +152,11 @@ document.addEventListener("click", (ev) => { if (!(ev.target && ev.target instanceof HTMLAnchorElement)) return; - if (!ev.target.matches(".footnotes .reversefootnote, .footnotes .footnoteBackLink, footnotes .footnote-return")) return; - const hash = ev.target.hash; - if (!hash) return; - const fnref = document.getElementById(hash.substring(1)); - + if (!ev.target.matches(".footnotes .reversefootnote, .footnotes .footnoteBackLink, .footnotes .footnote-return")) return; + const id = idFromHash(ev.target); + if (!id) return; + const fnref = document.getElementById(id); + window.scrollTo({ top: fnref.getBoundingClientRect().top + window.scrollY }); ev.preventDefault(); });