FreshRSS/NetNewsWire
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Mark classes as final that can be marked as final.

Browse Source
This commit is contained in:
Brent Simmons 2025-01-25 11:01:12 -08:00
parent 48fc807f94
commit 5651764907
155 changed files with 172 additions and 172 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Mac/AppDelegate.swift
View File

@ -22,7 +22,7 @@ import Sparkle
var appDelegate: AppDelegate!
@NSApplicationMain
class AppDelegate: NSObject, NSApplicationDelegate, NSUserInterfaceValidations, UNUserNotificationCenterDelegate, UnreadCountProvider, SPUStandardUserDriverDelegate, SPUUpdaterDelegate {
final class AppDelegate: NSObject, NSApplicationDelegate, NSUserInterfaceValidations, UNUserNotificationCenterDelegate, UnreadCountProvider, SPUStandardUserDriverDelegate, SPUUpdaterDelegate {
private struct WindowRestorationIdentifiers {
static let mainWindow = "mainWindow"

2
Mac/MainWindow/AddFeed/AddFeedController.swift
View File

@ -22,7 +22,7 @@ import Parser
// Else,
// display error sheet.
class AddFeedController: AddFeedWindowControllerDelegate {
final class AddFeedController: AddFeedWindowControllerDelegate {
private let hostWindow: NSWindow
private var addFeedWindowController: AddFeedWindowController?

2
Mac/MainWindow/AddFeed/FolderTreeMenu.swift
View File

@ -11,7 +11,7 @@ import RSCore
import RSTree
import Account
class FolderTreeMenu {
final class FolderTreeMenu {
static func createFolderPopupMenu(with rootNode: Node, restrictToSpecialAccounts: Bool = false) -> NSMenu {

2
Mac/MainWindow/AddFolder/AddFolderWindowController.swift
View File

@ -10,7 +10,7 @@ import AppKit
import Articles
import Account
class AddFolderWindowController: NSWindowController {
final class AddFolderWindowController: NSWindowController {
@IBOutlet var folderNameTextField: NSTextField!
@IBOutlet var accountPopupButton: NSPopUpButton!

2
Mac/MainWindow/ArticleExtractorButton.swift
View File

@ -15,7 +15,7 @@ enum ArticleExtractorButtonState {
case off
}
class ArticleExtractorButton: NSButton {
final class ArticleExtractorButton: NSButton {
private var animatedLayer: CALayer?

2
Mac/MainWindow/LegacyArticleExtractorButton.swift
View File

@ -8,7 +8,7 @@
import Foundation
class LegacyArticleExtractorButton: NSButton {
final class LegacyArticleExtractorButton: NSButton {
var isError = false {
didSet {

2
Mac/MainWindow/MainWindowController.swift
View File

@ -16,7 +16,7 @@ enum TimelineSourceMode {
case regular, search
}
class MainWindowController: NSWindowController, NSUserInterfaceValidations {
final class MainWindowController: NSWindowController, NSUserInterfaceValidations {
@IBOutlet weak var articleThemePopUpButton: NSPopUpButton?

2
Mac/MainWindow/OPML/ExportOPMLWindowController.swift
View File

@ -10,7 +10,7 @@ import AppKit
import Account
import UniformTypeIdentifiers
class ExportOPMLWindowController: NSWindowController {
final class ExportOPMLWindowController: NSWindowController {
@IBOutlet weak var accountPopUpButton: NSPopUpButton!
private weak var hostWindow: NSWindow?

2
Mac/MainWindow/OPML/ImportOPMLWindowController.swift
View File

@ -10,7 +10,7 @@ import AppKit
import Account
import UniformTypeIdentifiers
class ImportOPMLWindowController: NSWindowController {
final class ImportOPMLWindowController: NSWindowController {
@IBOutlet weak var accountPopUpButton: NSPopUpButton!
private weak var hostWindow: NSWindow?

2
Mac/MainWindow/Sidebar/Cell/SidebarCell.swift
View File

@ -11,7 +11,7 @@ import RSCore
import Account
import RSTree
class SidebarCell: NSTableCellView {
final class SidebarCell: NSTableCellView {
var iconImage: IconImage? {
didSet {

2
Mac/MainWindow/Sidebar/SidebarOutlineView.swift
View File

@ -10,7 +10,7 @@ import AppKit
import RSCore
import RSTree
class SidebarOutlineView: NSOutlineView {
final class SidebarOutlineView: NSOutlineView {
@IBOutlet var keyboardDelegate: KeyboardDelegate!

2
Mac/MainWindow/Sidebar/SidebarViewController.swift
View File

@ -22,7 +22,7 @@ protocol SidebarDelegate: AnyObject {
func sidebarInvalidatedRestorationState(_: SidebarViewController)
}
@objc class SidebarViewController: NSViewController, NSOutlineViewDelegate, NSMenuDelegate, UndoableCommandRunner {
@objc final class SidebarViewController: NSViewController, NSOutlineViewDelegate, NSMenuDelegate, UndoableCommandRunner {
@IBOutlet weak var outlineView: NSOutlineView!

2
Mac/MainWindow/Sidebar/UnreadCountView.swift
View File

@ -8,7 +8,7 @@
import AppKit
class UnreadCountView: NSView {
final class UnreadCountView: NSView {
struct Appearance {
static let padding = NSEdgeInsets(top: 1.0, left: 7.0, bottom: 1.0, right: 7.0)

2
Mac/MainWindow/Timeline/Cell/TimelineTableCellView.swift
View File

@ -9,7 +9,7 @@
import AppKit
import RSCore
class TimelineTableCellView: NSTableCellView {
final class TimelineTableCellView: NSTableCellView {
private let titleView = TimelineTableCellView.multiLineTextField()
private let summaryView = TimelineTableCellView.multiLineTextField()

2
Mac/MainWindow/Timeline/Cell/UnreadIndicatorView.swift
View File

@ -8,7 +8,7 @@
import AppKit
class UnreadIndicatorView: NSView {
final class UnreadIndicatorView: NSView {
static let unreadCircleDimension: CGFloat = 8.0

2
Mac/MainWindow/Timeline/TimelineTableRowView.swift
View File

@ -8,7 +8,7 @@
import AppKit
class TimelineTableRowView: NSTableRowView {
final class TimelineTableRowView: NSTableRowView {
private var separator: NSView?

2
Mac/MainWindow/Timeline/TimelineTableView.swift
View File

@ -9,7 +9,7 @@
import AppKit
import RSCore
class TimelineTableView: NSTableView {
final class TimelineTableView: NSTableView {
weak var keyboardDelegate: KeyboardDelegate?

2
Mac/Preferences/Accounts/AccountCell.swift
View File

@ -8,7 +8,7 @@
import AppKit
class AccountCell: NSTableCellView {
final class AccountCell: NSTableCellView {
private var originalImage: NSImage?

2
Mac/Preferences/Accounts/AccountsAddCloudKitWindowController.swift
View File

@ -17,7 +17,7 @@ enum AccountsAddCloudKitWindowControllerError: LocalizedError {
}
}
class AccountsAddCloudKitWindowController: NSWindowController {
final class AccountsAddCloudKitWindowController: NSWindowController {
@IBOutlet weak var limitationsAndSolutionsTextField: NSTextField!

2
Mac/Preferences/Accounts/AccountsAddLocalWindowController.swift
View File

@ -9,7 +9,7 @@
import AppKit
import Account
class AccountsAddLocalWindowController: NSWindowController {
final class AccountsAddLocalWindowController: NSWindowController {
@IBOutlet private weak var nameTextField: NSTextField!
@IBOutlet private weak var localAccountNameTextField: NSTextField!

2
Mac/Preferences/Accounts/AccountsFeedbinWindowController.swift
View File

@ -11,7 +11,7 @@ import Account
import RSWeb
import Secrets
class AccountsFeedbinWindowController: NSWindowController {
final class AccountsFeedbinWindowController: NSWindowController {
@IBOutlet weak var signInTextField: NSTextField!
@IBOutlet weak var noAccountTextField: NSTextField!

2
Mac/Preferences/Accounts/AccountsNewsBlurWindowController.swift
View File

@ -11,7 +11,7 @@ import Account
import RSWeb
import Secrets
class AccountsNewsBlurWindowController: NSWindowController {
final class AccountsNewsBlurWindowController: NSWindowController {
@IBOutlet weak var signInTextField: NSTextField!
@IBOutlet weak var noAccountTextField: NSTextField!

2
Mac/Preferences/Accounts/AccountsReaderAPIWindowController.swift
View File

@ -11,7 +11,7 @@ import Account
import RSWeb
import Secrets
class AccountsReaderAPIWindowController: NSWindowController {
final class AccountsReaderAPIWindowController: NSWindowController {
@IBOutlet weak var titleImageView: NSImageView!
@IBOutlet weak var titleLabel: NSTextField!

2
Mac/Preferences/PreferencesWindowController.swift
View File

@ -27,7 +27,7 @@ private struct ToolbarItemIdentifier {
static let Advanced = "Advanced"
}
class PreferencesWindowController: NSWindowController, NSToolbarDelegate {
final class PreferencesWindowController: NSWindowController, NSToolbarDelegate {
private let windowWidth = CGFloat(512.0) // Width is constant for all views; only the height changes
private var viewControllers = [String: NSViewController]()

4
Mac/SafariExtension/SafariExtensionHandler.swift
View File

@ -8,7 +8,7 @@
import SafariServices
class SafariExtensionHandler: SFSafariExtensionHandler {
final class SafariExtensionHandler: SFSafariExtensionHandler {
// Safari App Extensions don't support any reasonable means of detecting whether a
// specific Safari page was loaded with the benefit of the extension's injected
@ -20,7 +20,7 @@ class SafariExtensionHandler: SFSafariExtensionHandler {
// I tried to use a NSMapTable from String to the closure directly, but Swift
// complains that the object has to be a class type.
typealias ValidationHandler = (Bool, String) -> Void
class ValidationWrapper {
final class ValidationWrapper {
let validationHandler: ValidationHandler
init(validationHandler: @escaping ValidationHandler) {

2
Mac/SafariExtension/SafariExtensionViewController.swift
View File

@ -8,7 +8,7 @@
import SafariServices
class SafariExtensionViewController: SFSafariExtensionViewController {
final class SafariExtensionViewController: SFSafariExtensionViewController {
// This would be the place to handle a popover that could, for example, list the possibly multiple feeds offered by a site.
static let shared: SafariExtensionViewController = {

2
Mac/Scriptability/Account+Scriptability.swift
View File

@ -12,7 +12,7 @@ import Articles
import RSCore
@objc(ScriptableAccount)
class ScriptableAccount: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
final class ScriptableAccount: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
let account: Account
init (_ account: Account) {

6
Mac/Scriptability/AppDelegate+Scriptability.swift
View File

@ -90,7 +90,7 @@ extension AppDelegate: AppDelegateAppleEvents {
}
}
class NetNewsWireCreateElementCommand: NSCreateCommand {
final class NetNewsWireCreateElementCommand: NSCreateCommand {
override func performDefaultImplementation() -> Any? {
let classDescription = self.createClassDescription
if classDescription.className == "feed" {
@ -110,7 +110,7 @@ class NetNewsWireCreateElementCommand: NSCreateCommand {
is ambiguity about whether specifiers are lists or single objects, the code switches
based on which it is.
*/
class NetNewsWireDeleteCommand: NSDeleteCommand {
final class NetNewsWireDeleteCommand: NSDeleteCommand {
/*
delete(objectToDelete:, from container:)
@ -165,7 +165,7 @@ class NetNewsWireDeleteCommand: NSDeleteCommand {
}
}
class NetNewsWireExistsCommand: NSExistsCommand {
final class NetNewsWireExistsCommand: NSExistsCommand {
// cocoa default behavior doesn't work here, because of cases where we define an object's property
// to be another object type. e.g., 'permalink of the current article' parses as

2
Mac/Scriptability/Article+Scriptability.swift
View File

@ -11,7 +11,7 @@ import Account
import Articles
@objc(ScriptableArticle)
class ScriptableArticle: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
final class ScriptableArticle: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
let article: Article
let container: ScriptingObjectContainer

2
Mac/Scriptability/Author+Scriptability.swift
View File

@ -11,7 +11,7 @@ import Account
import Articles
@objc(ScriptableAuthor)
class ScriptableAuthor: NSObject, UniqueIdScriptingObject {
final class ScriptableAuthor: NSObject, UniqueIdScriptingObject {
let author: Author
let container: ScriptingObjectContainer

2
Mac/Scriptability/Folder+Scriptability.swift
View File

@ -12,7 +12,7 @@ import Articles
import RSCore
@objc(ScriptableFolder)
class ScriptableFolder: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
final class ScriptableFolder: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
let folder: Folder
let container: ScriptingObjectContainer

2
Mac/Scriptability/WebFeed+Scriptability.swift
View File

@ -12,7 +12,7 @@ import Account
import Articles
@objc(ScriptableFeed)
class ScriptableFeed: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
final class ScriptableFeed: NSObject, UniqueIdScriptingObject, ScriptingObjectContainer {
let feed: Feed
let container: ScriptingObjectContainer

2
Mac/ShareExtension/ShareViewController.swift
View File

@ -10,7 +10,7 @@ import Cocoa
import os.log
import UniformTypeIdentifiers
class ShareViewController: NSViewController {
final class ShareViewController: NSViewController {
@IBOutlet weak var nameTextField: NSTextField!
@IBOutlet weak var folderPopUpButton: NSPopUpButton!

2
Modules/Account/Sources/Account/CloudKit/CloudKitAccountZoneDelegate.swift
View File

@ -13,7 +13,7 @@ import CloudKit
import RSCore
import Articles
class CloudKitAcountZoneDelegate: CloudKitZoneDelegate {
final class CloudKitAcountZoneDelegate: CloudKitZoneDelegate {
struct UnclaimedFeed {
let url: URL

2
Modules/Account/Sources/Account/CloudKit/CloudKitArticlesZoneDelegate.swift
View File

@ -16,7 +16,7 @@ import SyncDatabase
import Articles
import ArticlesDatabase
class CloudKitArticlesZoneDelegate: CloudKitZoneDelegate {
final class CloudKitArticlesZoneDelegate: CloudKitZoneDelegate {
private var log = OSLog(subsystem: Bundle.main.bundleIdentifier!, category: "CloudKit")

2
Modules/Account/Sources/Account/CloudKit/CloudKitReceiveStatusOperation.swift
View File

@ -10,7 +10,7 @@ import Foundation
import os.log
import RSCore
class CloudKitReceiveStatusOperation: MainThreadOperation {
final class CloudKitReceiveStatusOperation: MainThreadOperation {
private var log = OSLog(subsystem: Bundle.main.bundleIdentifier!, category: "CloudKit")

2
Modules/Account/Sources/Account/CloudKit/CloudKitRemoteNotificationOperation.swift
View File

@ -11,7 +11,7 @@ import Foundation
import os.log
import RSCore
class CloudKitRemoteNotificationOperation: MainThreadOperation {
final class CloudKitRemoteNotificationOperation: MainThreadOperation {
private var log = OSLog(subsystem: Bundle.main.bundleIdentifier!, category: "CloudKit")

2
Modules/Account/Sources/Account/CloudKit/CloudKitSendStatusOperation.swift
View File

@ -13,7 +13,7 @@ import RSCore
import RSWeb
import SyncDatabase
class CloudKitSendStatusOperation: MainThreadOperation {
final class CloudKitSendStatusOperation: MainThreadOperation {
private var log = OSLog(subsystem: Bundle.main.bundleIdentifier!, category: "CloudKit")
private let blockSize = 150

2
Modules/Account/Sources/Account/FeedFinder/FeedFinder.swift
View File

@ -11,7 +11,7 @@ import Parser
import RSWeb
import RSCore
class FeedFinder {
final class FeedFinder {
static func find(url: URL, completion: @escaping (Result<Set<FeedSpecifier>, Error>) -> Void) {
Downloader.shared.download(url) { (data, response, error) in

2
Modules/Account/Sources/Account/FeedFinder/HTMLFeedFinder.swift
View File

@ -11,7 +11,7 @@ import Parser
private let feedURLWordsToMatch = ["feed", "xml", "rss", "atom", "json"]
class HTMLFeedFinder {
final class HTMLFeedFinder {
var feedSpecifiers: Set<FeedSpecifier> {
return Set(feedSpecifiersDictionary.values)

2
Modules/Account/Sources/Account/Feedly/Operations/FeedlyAddExistingFeedOperation.swift
View File

@ -12,7 +12,7 @@ import RSWeb
import RSCore
import Secrets
class FeedlyAddExistingFeedOperation: FeedlyOperation, FeedlyOperationDelegate, FeedlyCheckpointOperationDelegate {
final class FeedlyAddExistingFeedOperation: FeedlyOperation, FeedlyOperationDelegate, FeedlyCheckpointOperationDelegate {
private let operationQueue = MainThreadOperationQueue()
var addCompletionHandler: ((Result<Void, Error>) -> Void)?

2
Modules/Account/Sources/Account/Feedly/Operations/FeedlyAddNewFeedOperation.swift
View File

@ -13,7 +13,7 @@ import RSWeb
import RSCore
import Secrets
class FeedlyAddNewFeedOperation: FeedlyOperation, FeedlyOperationDelegate, FeedlySearchOperationDelegate, FeedlyCheckpointOperationDelegate {
final class FeedlyAddNewFeedOperation: FeedlyOperation, FeedlyOperationDelegate, FeedlySearchOperationDelegate, FeedlyCheckpointOperationDelegate {
private let operationQueue = MainThreadOperationQueue()
private let folder: Folder

2
Modules/Account/Sources/Account/Feedly/Operations/FeedlyDownloadArticlesOperation.swift
View File

@ -11,7 +11,7 @@ import os.log
import RSCore
import RSWeb
class FeedlyDownloadArticlesOperation: FeedlyOperation {
final class FeedlyDownloadArticlesOperation: FeedlyOperation {
private let account: Account
private let log: OSLog

2
Modules/Account/Sources/Account/Feedly/Operations/FeedlyGetUpdatedArticleIdsOperation.swift
View File

@ -14,7 +14,7 @@ import Secrets
///
/// Typically, it pages through the article ids of the global.all stream.
/// When all the article ids are collected, it is the responsibility of another operation to download them when appropriate.
class FeedlyGetUpdatedArticleIdsOperation: FeedlyOperation, FeedlyEntryIdentifierProviding {
final class FeedlyGetUpdatedArticleIdsOperation: FeedlyOperation, FeedlyEntryIdentifierProviding {
private let account: Account
private let resource: FeedlyResourceId

2
Modules/Account/Sources/Account/Feedly/Operations/FeedlyIngestStreamArticleIdsOperation.swift
View File

@ -15,7 +15,7 @@ import Secrets
/// Typically, it pages through the article ids of the global.all stream.
/// As the article ids are collected, a default read status is created for each.
/// So this operation has side effects *for the entire account* it operates on.
class FeedlyIngestStreamArticleIdsOperation: FeedlyOperation {
final class FeedlyIngestStreamArticleIdsOperation: FeedlyOperation {
private let account: Account
private let resource: FeedlyResourceId

2
Modules/Account/Sources/Account/Feedly/Operations/FeedlySearchOperation.swift
View File

@ -18,7 +18,7 @@ protocol FeedlySearchOperationDelegate: AnyObject {
/// Find one and only one feed for a given query (usually, a URL).
/// What happens when a feed is found for the URL is delegated to the `searchDelegate`.
class FeedlySearchOperation: FeedlyOperation {
final class FeedlySearchOperation: FeedlyOperation {
let query: String
let locale: Locale

2
Modules/Account/Tests/AccountTests/AccountCredentialsTest.swift
View File

@ -11,7 +11,7 @@ import RSWeb
@testable import Account
import Secrets
class AccountCredentialsTest: XCTestCase {
final class AccountCredentialsTest: XCTestCase {
private var account: Account!

2
Modules/Account/Tests/AccountTests/Feedbin/AccountFeedbinFolderContentsSyncTest.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class AccountFeedbinFolderContentsSyncTest: XCTestCase {
final class AccountFeedbinFolderContentsSyncTest: XCTestCase {
override func setUp() {
}

2
Modules/Account/Tests/AccountTests/Feedbin/AccountFeedbinFolderSyncTest.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class AccountFeedbinFolderSyncTest: XCTestCase {
final class AccountFeedbinFolderSyncTest: XCTestCase {
override func setUp() {
}

2
Modules/Account/Tests/AccountTests/Feedbin/AccountFeedbinSyncTest.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class AccountFeedbinSyncTest: XCTestCase {
final class AccountFeedbinSyncTest: XCTestCase {
override func setUp() {
}

4
Modules/Account/Tests/AccountTests/Feedly/FeedlyCheckpointOperationTests.swift
View File

@ -10,9 +10,9 @@ import XCTest
@testable import Account
import RSCore
class FeedlyCheckpointOperationTests: XCTestCase {
final class FeedlyCheckpointOperationTests: XCTestCase {
class TestDelegate: FeedlyCheckpointOperationDelegate {
final class TestDelegate: FeedlyCheckpointOperationDelegate {
var didReachCheckpointExpectation: XCTestExpectation?

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyCollectionParserTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class FeedlyCollectionParserTests: XCTestCase {
final class FeedlyCollectionParserTests: XCTestCase {
func testParsing() {
let collection = FeedlyCollection(feeds: [], label: "Test Collection", id: "test/collection/1")

4
Modules/Account/Tests/AccountTests/Feedly/FeedlyCreateFeedsForCollectionFoldersOperationTests.swift
View File

@ -10,7 +10,7 @@ import XCTest
@testable import Account
import RSCore
class FeedlyCreateFeedsForCollectionFoldersOperationTests: XCTestCase {
final class FeedlyCreateFeedsForCollectionFoldersOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()
@ -27,7 +27,7 @@ class FeedlyCreateFeedsForCollectionFoldersOperationTests: XCTestCase {
super.tearDown()
}
class FeedsAndFoldersProvider: FeedlyFeedsAndFoldersProviding {
final class FeedsAndFoldersProvider: FeedlyFeedsAndFoldersProviding {
var feedsAndFolders = [([FeedlyFeed], Folder)]()
}

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyEntryParserTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class FeedlyEntryParserTests: XCTestCase {
final class FeedlyEntryParserTests: XCTestCase {
func testParsing() {
let content = FeedlyEntry.Content(content: "Test Content", direction: .leftToRight)

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyFeedParserTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class FeedlyFeedParserTests: XCTestCase {
final class FeedlyFeedParserTests: XCTestCase {
func testParsing() {
let name = "Test Feed"

4
Modules/Account/Tests/AccountTests/Feedly/FeedlyGetCollectionsOperationTests.swift
View File

@ -11,7 +11,7 @@ import XCTest
import os.log
import RSCore
class FeedlyGetCollectionsOperationTests: XCTestCase {
final class FeedlyGetCollectionsOperationTests: XCTestCase {
func testGetCollections() {
let support = FeedlyTestSupport()
@ -58,7 +58,7 @@ class FeedlyGetCollectionsOperationTests: XCTestCase {
func testGetCollectionsError() {
class TestDelegate: FeedlyOperationDelegate {
final class TestDelegate: FeedlyOperationDelegate {
var errorExpectation: XCTestExpectation?
var error: Error?

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyGetStreamContentsOperationTests.swift
View File

@ -10,7 +10,7 @@ import XCTest
@testable import Account
import RSCore
class FeedlyGetStreamContentsOperationTests: XCTestCase {
final class FeedlyGetStreamContentsOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyGetStreamIdsOperationTests.swift
View File

@ -10,7 +10,7 @@ import XCTest
@testable import Account
import RSCore
class FeedlyGetStreamIdsOperationTests: XCTestCase {
final class FeedlyGetStreamIdsOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()

6
Modules/Account/Tests/AccountTests/Feedly/FeedlyLogoutOperationTests.swift
View File

@ -11,7 +11,7 @@ import XCTest
import RSCore
import Secrets
class FeedlyLogoutOperationTests: XCTestCase {
final class FeedlyLogoutOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()
@ -36,7 +36,7 @@ class FeedlyLogoutOperationTests: XCTestCase {
return (accessToken, refreshToken)
}
class TestFeedlyLogoutService: FeedlyLogoutService {
final class TestFeedlyLogoutService: FeedlyLogoutService {
var mockResult: Result<Void, Error>?
var logoutExpectation: XCTestExpectation?
@ -123,7 +123,7 @@ class FeedlyLogoutOperationTests: XCTestCase {
}
}
class TestLogoutDelegate: FeedlyOperationDelegate {
final class TestLogoutDelegate: FeedlyOperationDelegate {
var error: Error?
var didFailExpectation: XCTestExpectation?

6
Modules/Account/Tests/AccountTests/Feedly/FeedlyMirrorCollectionsAsFoldersOperationTests.swift
View File

@ -10,7 +10,7 @@ import XCTest
@testable import Account
import RSCore
class FeedlyMirrorCollectionsAsFoldersOperationTests: XCTestCase {
final class FeedlyMirrorCollectionsAsFoldersOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()
@ -27,7 +27,7 @@ class FeedlyMirrorCollectionsAsFoldersOperationTests: XCTestCase {
super.tearDown()
}
class CollectionsProvider: FeedlyCollectionProviding {
final class CollectionsProvider: FeedlyCollectionProviding {
var collections = [
FeedlyCollection(feeds: [], label: "One", id: "collections/1"),
FeedlyCollection(feeds: [], label: "Two", id: "collections/2")
@ -105,7 +105,7 @@ class FeedlyMirrorCollectionsAsFoldersOperationTests: XCTestCase {
XCTAssertTrue(removeFolders.feedsAndFolders.isEmpty)
}
class CollectionsAndFeedsProvider: FeedlyCollectionProviding {
final class CollectionsAndFeedsProvider: FeedlyCollectionProviding {
var feedsForCollectionOne = [
FeedlyFeed(id: "feed/1", title: "Feed One", updated: nil, website: nil),
FeedlyFeed(id: "feed/2", title: "Feed Two", updated: nil, website: nil)

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyOperationTests.swift
View File

@ -11,7 +11,7 @@ import XCTest
import RSWeb
import RSCore
class FeedlyOperationTests: XCTestCase {
final class FeedlyOperationTests: XCTestCase {
enum TestOperationError: Error, Equatable {
case mockError

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyOrganiseParsedItemsByFeedOperationTests.swift
View File

@ -11,7 +11,7 @@ import XCTest
import Parser
import RSCore
class FeedlyOrganiseParsedItemsByFeedOperationTests: XCTestCase {
final class FeedlyOrganiseParsedItemsByFeedOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()

6
Modules/Account/Tests/AccountTests/Feedly/FeedlyRefreshAccessTokenOperationTests.swift
View File

@ -12,7 +12,7 @@ import RSWeb
import RSCore
import Secrets
class FeedlyRefreshAccessTokenOperationTests: XCTestCase {
final class FeedlyRefreshAccessTokenOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()
@ -29,7 +29,7 @@ class FeedlyRefreshAccessTokenOperationTests: XCTestCase {
super.tearDown()
}
class TestRefreshTokenService: OAuthAccessTokenRefreshing {
final class TestRefreshTokenService: OAuthAccessTokenRefreshing {
var mockResult: Result<OAuthAuthorizationGrant, Error>?
var refreshAccessTokenExpectation: XCTestExpectation?
var parameterTester: ((String, OAuthAuthorizationClient) -> Void)?
@ -71,7 +71,7 @@ class FeedlyRefreshAccessTokenOperationTests: XCTestCase {
XCTAssertTrue(refresh.isCanceled)
}
class TestRefreshTokenDelegate: FeedlyOperationDelegate {
final class TestRefreshTokenDelegate: FeedlyOperationDelegate {
var error: Error?
var didFailExpectation: XCTestExpectation?

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyResourceIdTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class FeedlyResourceIdTests: XCTestCase {
final class FeedlyResourceIdTests: XCTestCase {
func testFeedResourceId() {
let expectedUrl = "http://ranchero.com/blog/atom.xml"

2
Modules/Account/Tests/AccountTests/Feedly/FeedlySendArticleStatusesOperationTests.swift
View File

@ -12,7 +12,7 @@ import SyncDatabase
import Articles
import RSCore
class FeedlySendArticleStatusesOperationTests: XCTestCase {
final class FeedlySendArticleStatusesOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()

2
Modules/Account/Tests/AccountTests/Feedly/FeedlySyncAllMockResponseProvider.swift
View File

@ -8,7 +8,7 @@
import Foundation
class FeedlyMockResponseProvider: TestTransportMockResponseProviding {
final class FeedlyMockResponseProvider: TestTransportMockResponseProviding {
let subdirectory: String

2
Modules/Account/Tests/AccountTests/Feedly/FeedlySyncStreamContentsOperationTests.swift
View File

@ -10,7 +10,7 @@ import XCTest
@testable import Account
import RSCore
class FeedlySyncStreamContentsOperationTests: XCTestCase {
final class FeedlySyncStreamContentsOperationTests: XCTestCase {
private var account: Account!
private let support = FeedlyTestSupport()

4
Modules/Account/Tests/AccountTests/Feedly/FeedlyTestSupport.swift
View File

@ -13,7 +13,7 @@ import Secrets
import os.log
import SyncDatabase
class FeedlyTestSupport {
final class FeedlyTestSupport {
var log = OSLog(subsystem: Bundle.main.bundleIdentifier!, category: "FeedlyTests")
var accessToken = Credentials(type: .oauthAccessToken, username: "Test", secret: "t3st-access-tok3n")
var refreshToken = Credentials(type: .oauthRefreshToken, username: "Test", secret: "t3st-refresh-tok3n")
@ -54,7 +54,7 @@ class FeedlyTestSupport {
return TestDatabaseContainer()
}
class TestDatabaseContainer {
final class TestDatabaseContainer {
private let path: String
private(set) var database: SyncDatabase!

2
Modules/Account/Tests/AccountTests/Feedly/FeedlyTextSanitizationTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class FeedlyTextSanitizationTests: XCTestCase {
final class FeedlyTextSanitizationTests: XCTestCase {
func testRTLSanitization() {

2
Modules/Account/Tests/AccountTests/Feedly/TestMarkArticlesService.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import Account
class TestMarkArticlesService: FeedlyMarkArticlesService {
final class TestMarkArticlesService: FeedlyMarkArticlesService {
var didMarkExpectation: XCTestExpectation?
var parameterTester: ((Set<String>, FeedlyMarkAction) -> Void)?

2
Modules/Account/Tests/AccountTests/TestAccountManager.swift
View File

@ -11,7 +11,7 @@ import RSWeb
@testable import Account
class TestAccountManager {
final class TestAccountManager {
static let shared = TestAccountManager()

2
Modules/RSCore/Sources/RSCore/AppKit/RSAppMovementMonitor.swift
View File

@ -9,7 +9,7 @@
#if os(macOS)
import Cocoa
public class RSAppMovementMonitor: NSObject {
public final class RSAppMovementMonitor: NSObject {
// If provided, the handler will be consulted when the app is moved.
// Return true to indicate that the default handler should be invoked.

2
Modules/RSCore/Sources/RSCore/AppKit/RSDarkModeAdaptingToolbarButton.swift
View File

@ -8,7 +8,7 @@
#if os(macOS)
import AppKit
class RSDarkModeAdaptingToolbarButton: NSButton {
final class RSDarkModeAdaptingToolbarButton: NSButton {
// Clients probably should not bother using this class unless they want
// to force the template in dark mode, but if you are using this in a more
// general context where you want to control and/or override it on a

2
Modules/RSCore/Sources/RSCore/AppKit/RSToolbarItem.swift
View File

@ -8,7 +8,7 @@
#if os(macOS)
import AppKit
public class RSToolbarItem: NSToolbarItem {
public final class RSToolbarItem: NSToolbarItem {
override public func validate() {

2
Modules/RSCore/Tests/RSCoreTests/MacroProcessorTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import RSCore
class MacroProcessorTests: XCTestCase {
final class MacroProcessorTests: XCTestCase {
let substitutions = ["one": "1", "two": "2"]
func testMacroProcessor() {

2
Modules/RSCore/Tests/RSCoreTests/MainThreadOperationTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import RSCore
class MainThreadOperationTests: XCTestCase {
final class MainThreadOperationTests: XCTestCase {
func testSingleOperation() {
let queue = MainThreadOperationQueue()

2
Modules/RSCore/Tests/RSCoreTests/String+RSCoreTests.swift
View File

@ -8,7 +8,7 @@
import XCTest
class StringRSCore: XCTestCase {
final class StringRSCore: XCTestCase {
func testCollapsingWhitespace() {

2
Modules/RSWeb/Sources/RSWeb/Reachability.swift
View File

@ -33,7 +33,7 @@ public enum ReachabilityError: Error {
case unableToGetFlags(Int32)
}
public class Reachability {
public final class Reachability {
/// Returns true if the internet is reachable.
///

2
Modules/RSWeb/Tests/RSWebTests/DictionaryTests.swift
View File

@ -8,7 +8,7 @@
import XCTest
class DictionaryTests: XCTestCase {
final class DictionaryTests: XCTestCase {
func testSimpleQueryString() {

2
Modules/RSWeb/Tests/RSWebTests/RSWebTests.swift
View File

@ -9,7 +9,7 @@
import XCTest
@testable import RSWeb
class RSWebTests: XCTestCase {
final class RSWebTests: XCTestCase {
func testExample() {
// This is an example of a functional test case.

2
Modules/RSWeb/Tests/RSWebTests/StringTests.swift
View File

@ -8,7 +8,7 @@
import XCTest
class StringTests: XCTestCase {
final class StringTests: XCTestCase {
func testHTMLEscaping() {

2
Shared/Activity/ActivityManager.swift
View File

@ -15,7 +15,7 @@ import Articles
import Intents
import UniformTypeIdentifiers
class ActivityManager {
final class ActivityManager {
private var nextUnreadActivity: NSUserActivity?
private var selectingActivity: NSUserActivity?

2
Shared/ArticleExtractor/ArticleExtractor.swift
View File

@ -23,7 +23,7 @@ protocol ArticleExtractorDelegate: AnyObject {
func articleExtractionDidComplete(extractedArticle: ExtractedArticle)
}
class ArticleExtractor {
final class ArticleExtractor {
private var dataTask: URLSessionDataTask?

2
Shared/Extensions/RSImage-Extensions.swift
View File

@ -38,7 +38,7 @@ extension RSImage {
// MARK: - IconScalerQueue
private class IconScalerQueue {
private final class IconScalerQueue {
static let shared = IconScalerQueue()

2
Shared/Favicons/ColorHash.swift
View File

@ -16,7 +16,7 @@ import WatchKit
import AppKit
#endif
public class ColorHash {
public final class ColorHash {
public static let defaultSaturation = [CGFloat(0.35), CGFloat(0.5), CGFloat(0.65)]
public static let defaultBrightness = [CGFloat(0.5), CGFloat(0.65), CGFloat(0.80)]

2
Shared/IconImageCache.swift
View File

@ -10,7 +10,7 @@ import Foundation
import Account
import Articles
class IconImageCache {
final class IconImageCache {
static var shared = IconImageCache()

2
Shared/Timer/ArticleStatusSyncTimer.swift
View File

@ -9,7 +9,7 @@
import Foundation
import Account
class ArticleStatusSyncTimer {
final class ArticleStatusSyncTimer {
private static let intervalSeconds = Double(120)

2
Tests/NetNewsWire-iOSTests/NetNewsWire-iOSTests.swift
View File

@ -8,7 +8,7 @@
import XCTest
class NetNewsWire-iOSTests: XCTestCase {
final class NetNewsWire-iOSTests: XCTestCase {
func testExample() {
// This is an example of a functional test case.

2
Tests/NetNewsWireTests/ArticleSorterTests.swift
View File

@ -12,7 +12,7 @@ import XCTest
@testable import NetNewsWire
class ArticleSorterTests: XCTestCase {
final class ArticleSorterTests: XCTestCase {
// MARK: sortByDate ascending tests

2
Tests/NetNewsWireTests/ScriptingTests/AppleScriptXCTestCase.swift
View File

@ -8,7 +8,7 @@
import XCTest
class AppleScriptXCTestCase: XCTestCase {
final class AppleScriptXCTestCase: XCTestCase {
/*
@function doIndividualScript

2
Tests/NetNewsWireTests/ScriptingTests/ScriptingTests.swift
View File

@ -8,7 +8,7 @@
import XCTest
class ScriptingTests: AppleScriptXCTestCase {
final class ScriptingTests: AppleScriptXCTestCase {
/*
@function testGenericScript

2
Tests/NetNewsWireTests/SharingTests.swift
View File

@ -11,7 +11,7 @@ import XCTest
@testable import NetNewsWire
class SharingTests: XCTestCase {
final class SharingTests: XCTestCase {
func testSharingSubject() {
let sharingServiceDelegate = SharingServiceDelegate(nil)

2
iOS/Account/CloudKitAccountViewController.swift
View File

@ -18,7 +18,7 @@ enum CloudKitAccountViewControllerError: LocalizedError {
}
}
class CloudKitAccountViewController: UITableViewController {
final class CloudKitAccountViewController: UITableViewController {
weak var delegate: AddAccountDismissDelegate?
@IBOutlet weak var footerLabel: UILabel!

2
iOS/Account/FeedbinAccountViewController.swift
View File

@ -12,7 +12,7 @@ import Secrets
import RSWeb
import SafariServices
class FeedbinAccountViewController: UITableViewController {
final class FeedbinAccountViewController: UITableViewController {
@IBOutlet weak var activityIndicator: UIActivityIndicatorView!
@IBOutlet weak var cancelBarButtonItem: UIBarButtonItem!

2
iOS/Account/LocalAccountViewController.swift
View File

@ -9,7 +9,7 @@
import UIKit
import Account
class LocalAccountViewController: UITableViewController {
final class LocalAccountViewController: UITableViewController {
@IBOutlet weak var nameTextField: UITextField!
@IBOutlet weak var footerLabel: UILabel!

2
iOS/Account/NewsBlurAccountViewController.swift
View File

@ -12,7 +12,7 @@ import Secrets
import RSWeb
import SafariServices
class NewsBlurAccountViewController: UITableViewController {
final class NewsBlurAccountViewController: UITableViewController {
@IBOutlet weak var activityIndicator: UIActivityIndicatorView!
@IBOutlet weak var cancelBarButtonItem: UIBarButtonItem!

2
iOS/Account/ReaderAPIAccountViewController.swift
View File

@ -12,7 +12,7 @@ import Secrets
import RSWeb
import SafariServices
class ReaderAPIAccountViewController: UITableViewController {
final class ReaderAPIAccountViewController: UITableViewController {
@IBOutlet weak var activityIndicator: UIActivityIndicatorView!
@IBOutlet weak var cancelBarButtonItem: UIBarButtonItem!

2
iOS/Add/AddComboTableViewCell.swift
View File

@ -8,7 +8,7 @@
import UIKit
class AddComboTableViewCell: VibrantTableViewCell {
final class AddComboTableViewCell: VibrantTableViewCell {
@IBOutlet weak var icon: UIImageView!
@IBOutlet weak var label: UILabel!

2
iOS/Add/AddFeedFolderViewController.swift
View File

@ -14,7 +14,7 @@ protocol AddFeedFolderViewControllerDelegate: AnyObject {
func didSelect(container: Container)
}
class AddFeedFolderViewController: UITableViewController {
final class AddFeedFolderViewController: UITableViewController {
weak var delegate: AddFeedFolderViewControllerDelegate?
var initialContainer: Container?

2
iOS/Add/AddFeedSelectFolderTableViewCell.swift
View File

@ -8,7 +8,7 @@
import UIKit
class AddFeedSelectFolderTableViewCell: VibrantTableViewCell {
final class AddFeedSelectFolderTableViewCell: VibrantTableViewCell {
@IBOutlet weak var folderLabel: UILabel!
@IBOutlet weak var detailLabel: UILabel!

Some files were not shown because too many files have changed in this diff Show More