Fix lint issues.

This commit is contained in:
Brent Simmons 2025-01-24 15:50:14 -08:00
parent 4b1b285d0b
commit 4fabcab999
8 changed files with 14 additions and 10 deletions

@ -21,6 +21,8 @@ disabled_rules:
- force_try - force_try
- cyclomatic_complexity - cyclomatic_complexity
- generic_type_name - generic_type_name
- function_body_length
- type_body_length
excluded: excluded:
- Modules/Secrets/Sources/Secrets/SecretKey.swift - Modules/Secrets/Sources/Secrets/SecretKey.swift

@ -23,7 +23,6 @@ class ShareViewController: NSViewController {
return NSNib.Name("ShareViewController") return NSNib.Name("ShareViewController")
} }
// swiftlint:disable:next function_body_length
override func loadView() { override func loadView() {
super.loadView() super.loadView()

@ -64,7 +64,6 @@ public final class WidgetDataEncoder {
} }
} }
// swiftlint:disable:next function_body_length
private func encodeWidgetData(completion: @escaping (WidgetData?) -> Void) { private func encodeWidgetData(completion: @escaping (WidgetData?) -> Void) {
let dispatchGroup = DispatchGroup() let dispatchGroup = DispatchGroup()
var groupError: Error? var groupError: Error?

@ -20,7 +20,6 @@ class MainFeedTableViewCell: VibrantTableViewCell {
weak var delegate: MainFeedTableViewCellDelegate? weak var delegate: MainFeedTableViewCellDelegate?
override var accessibilityLabel: String? { override var accessibilityLabel: String? {
set {}
get { get {
if unreadCount > 0 { if unreadCount > 0 {
let unreadLabel = NSLocalizedString("unread", comment: "Unread label for accessibility") let unreadLabel = NSLocalizedString("unread", comment: "Unread label for accessibility")

@ -8,16 +8,15 @@
import UIKit import UIKit
protocol MainFeedTableViewSectionHeaderDelegate { protocol MainFeedTableViewSectionHeaderDelegate: AnyObject {
func mainFeedTableViewSectionHeaderDisclosureDidToggle(_ sender: MainFeedTableViewSectionHeader) func mainFeedTableViewSectionHeaderDisclosureDidToggle(_ sender: MainFeedTableViewSectionHeader)
} }
class MainFeedTableViewSectionHeader: UITableViewHeaderFooterView { class MainFeedTableViewSectionHeader: UITableViewHeaderFooterView {
var delegate: MainFeedTableViewSectionHeaderDelegate? weak var delegate: MainFeedTableViewSectionHeaderDelegate?
override var accessibilityLabel: String? { override var accessibilityLabel: String? {
set {}
get { get {
if unreadCount > 0 { if unreadCount > 0 {
let unreadLabel = NSLocalizedString("unread", comment: "Unread label for accessibility") let unreadLabel = NSLocalizedString("unread", comment: "Unread label for accessibility")
@ -29,7 +28,6 @@ class MainFeedTableViewSectionHeader: UITableViewHeaderFooterView {
} }
private var expandedStateMessage: String { private var expandedStateMessage: String {
set {}
get { get {
if disclosureExpanded { if disclosureExpanded {
return NSLocalizedString("Expanded", comment: "Disclosure button expanded state for accessibility") return NSLocalizedString("Expanded", comment: "Disclosure button expanded state for accessibility")

@ -581,7 +581,16 @@ class TimelineViewController: UITableViewController, UndoableCommandRunner {
status: status status: status
) )
let prototypeCellData = MainTimelineCellData(article: prototypeArticle, showFeedName: .feed, feedName: "Prototype Feed Name", byline: nil, iconImage: nil, showIcon: false, numberOfLines: numberOfTextLines, iconSize: iconSize) let prototypeCellData = MainTimelineCellData(
article: prototypeArticle,
showFeedName: .feed,
feedName: "Prototype Feed Name",
byline: nil,
iconImage: nil,
showIcon: false,
numberOfLines: numberOfTextLines,
iconSize: iconSize
)
if UIApplication.shared.preferredContentSizeCategory.isAccessibilityCategory { if UIApplication.shared.preferredContentSizeCategory.isAccessibilityCategory {
let layout = MainTimelineAccessibilityCellLayout(width: tableView.bounds.width, insets: tableView.safeAreaInsets, cellData: prototypeCellData) let layout = MainTimelineAccessibilityCellLayout(width: tableView.bounds.width, insets: tableView.safeAreaInsets, cellData: prototypeCellData)

@ -156,7 +156,6 @@ class SettingsViewController: UITableViewController {
return cell return cell
} }
// swiftlint:disable:next function_body_length
override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
switch indexPath.section { switch indexPath.section {

@ -22,7 +22,6 @@ class ShareViewController: SLComposeServiceViewController, ShareFolderPickerCont
private var selectedContainer: ExtensionContainer? private var selectedContainer: ExtensionContainer?
private var folderItem: SLComposeSheetConfigurationItem! private var folderItem: SLComposeSheetConfigurationItem!
// swiftlint:disable:next function_body_length
override func viewDidLoad() { override func viewDidLoad() {
extensionContainers = ExtensionContainersFile.read() extensionContainers = ExtensionContainersFile.read()