From 2cdcddeefeabd2c254388372886125a854fa85c3 Mon Sep 17 00:00:00 2001 From: Brent Simmons Date: Wed, 5 Feb 2020 22:43:18 -0800 Subject: [PATCH] Handle possible nil favicon.urlString. --- Shared/Favicons/FaviconURLFinder.swift | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Shared/Favicons/FaviconURLFinder.swift b/Shared/Favicons/FaviconURLFinder.swift index 5dcbfab0d..54f38606b 100644 --- a/Shared/Favicons/FaviconURLFinder.swift +++ b/Shared/Favicons/FaviconURLFinder.swift @@ -54,14 +54,15 @@ struct FaviconURLFinder { if ignoredMimeTypes.contains(type) { return false } - } else { - if let url = URL(string: favicon.urlString), ignoredExtensions.contains(url.pathExtension) { + } + else { + if let urlString = favicon.urlString, let url = URL(string: urlString), ignoredExtensions.contains(url.pathExtension) { return false } } return true - }).map { $0.urlString } + }).compactMap { $0.urlString } completion(faviconURLs) }