FreshRSS
/
NetNewsWire
mirror of https://github.com/Ranchero-Software/NetNewsWire.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Set all the web view delegates to nil when recycling to prevent unintended behaviors. Issue #1777

This commit is contained in:
Maurice Parker 2020-02-06 10:36:39 -08:00
parent eb3b73d4cb
commit 268c20da56
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
iOS/Article/WebViewController.swift
View File

@ -424,6 +424,8 @@ private extension WebViewController {
// us from easily swiping between WKWebViews. This hack fixes that. // us from easily swiping between WKWebViews. This hack fixes that.
webView.scrollView.contentInset = UIEdgeInsets(top: 0, left: -1, bottom: 0, right: 0) webView.scrollView.contentInset = UIEdgeInsets(top: 0, left: -1, bottom: 0, right: 0)
webView.scrollView.setZoomScale(1.0, animated: false)
self.view.setNeedsLayout() self.view.setNeedsLayout()
self.view.layoutIfNeeded() self.view.layoutIfNeeded()
@ -449,6 +451,9 @@ private extension WebViewController {
webView.removeFromSuperview() webView.removeFromSuperview()
webView.evaluateJavaScript("cancelImageLoad();") webView.evaluateJavaScript("cancelImageLoad();")
webView.navigationDelegate = nil
webView.uiDelegate = nil
webView.scrollView.delegate = nil
webView.configuration.userContentController.removeScriptMessageHandler(forName: MessageName.imageWasClicked) webView.configuration.userContentController.removeScriptMessageHandler(forName: MessageName.imageWasClicked)
webView.configuration.userContentController.removeScriptMessageHandler(forName: MessageName.imageWasShown) webView.configuration.userContentController.removeScriptMessageHandler(forName: MessageName.imageWasShown)
webView.interactions.removeAll() webView.interactions.removeAll()
@ -489,8 +494,7 @@ private extension WebViewController {
windowScrollY = 0 windowScrollY = 0
webView.scrollView.setZoomScale(1.0, animated: false) webView.evaluateJavaScript(render)
webView.evaluateJavaScript(render)
} }