FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2025-02-03 12:27:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Defer the selection of the feed and article on state restoration to avoid crashes on iPad's running iOS 15 in landscape mode as they restore article selected state. Fixes #3201

Browse Source
This commit is contained in:
Maurice Parker 2021-09-11 14:28:00 -05:00
parent fe080b8ddc
commit 25946f3c5a
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
iOS/SceneCoordinator.swift
View File

@ -157,6 +157,21 @@ class SceneCoordinator: NSObject, UndoableCommandRunner, UnreadCountProvider {
private var exceptionArticleFetcher: ArticleFetcher? private var exceptionArticleFetcher: ArticleFetcher?
private(set) var timelineFeed: Feed? private(set) var timelineFeed: Feed?
// We have to defer the selecting of the feed and article due to a behavior (bug?) in iOS 15.
// iOS 15 will crash if you are in landscape on an iPad and are restoring article state. We
// have no idea why this is, but it happens when you do a select on a UITableView right before
// doing a diffable datasource apply.
//
// Steps to recreate:
//
// * Try to relaunch the app in the sim.
// * Press the Stop button in Xcode
// * Wait for all the app suspension activities to complete (widget data, etc)
// * Once the article has loaded, navigate to the iPad home screen
// * While in landscape, select a feed and then select an article
// * Install a fresh build of NNW to an iPad simulator (11 or 12.9' will do) running iPadOS 15
private var deferredFeedAndArticleSelect: (feedIndexPath: IndexPath, articleID: String)?
var timelineMiddleIndexPath: IndexPath? var timelineMiddleIndexPath: IndexPath?
private(set) var showFeedNames = ShowFeedName.none private(set) var showFeedNames = ShowFeedName.none
@ -438,6 +453,12 @@ class SceneCoordinator: NSObject, UndoableCommandRunner, UnreadCountProvider {
} }
rebuildBackingStores(initialLoad: true) rebuildBackingStores(initialLoad: true)
treeControllerDelegate.resetFilterExceptions() treeControllerDelegate.resetFilterExceptions()
if let (feedIndexPath, articleID) = deferredFeedAndArticleSelect {
selectFeed(indexPath: feedIndexPath) {
self.selectArticleInCurrentFeed(articleID)
}
}
} }
@objc func unreadCountDidChange(_ note: Notification) { @objc func unreadCountDidChange(_ note: Notification) {
@ -2279,9 +2300,7 @@ private extension SceneCoordinator {
func selectFeedAndArticle(feedNode: Node, articleID: String) -> Bool { func selectFeedAndArticle(feedNode: Node, articleID: String) -> Bool {
if let feedIndexPath = indexPathFor(feedNode) { if let feedIndexPath = indexPathFor(feedNode) {
selectFeed(indexPath: feedIndexPath) { deferredFeedAndArticleSelect = (feedIndexPath, articleID)
self.selectArticleInCurrentFeed(articleID)
}
return true return true
} }
return false return false