Merge pull request #2073 from rizwankce/open-in-safari-shortcut

Keyboard shortcuts for "Open in App Browser"

Shared/Resources/GlobalKeyboardShortcuts.plist

@@ -106,11 +106,11 @@
 	</dict>
 	<dict>
 		<key>title</key>
-		<string>Open in Browser</string>
+		<string>Open in App Browser</string>
 		<key>key</key>
 		<string>[return]</string>
 		<key>action</key>
-		<string>openInBrowser:</string>
+		<string>openFeedInAppBrowser:</string>
 	</dict>
 	<dict>
 		<key>key</key>

iOS/Article/ArticleViewController.swift

@@ -256,6 +256,7 @@ class ArticleViewController: UIViewController {
 	}
 	
 	// MARK: Keyboard Shortcuts
+
 	@objc func navigateToTimeline(_ sender: Any?) {
 		coordinator.navigateToTimeline()
 	}
@@ -278,6 +279,9 @@ class ArticleViewController: UIViewController {
 		currentWebViewController?.stopArticleExtractorIfProcessing()
 	}
 
+	func openInAppBrowser() {
+		currentWebViewController?.openInAppBrowser()
+	}	
 }
 
 // MARK: WebViewControllerDelegate

iOS/Article/WebViewController.swift

@@ -228,6 +228,14 @@ class WebViewController: UIViewController {
 		present(activityViewController, animated: true)
 	}
 
+	func openInAppBrowser() {
+		guard let preferredLink = article?.preferredLink, let url = URL(string: preferredLink) else {
+			return
+		}
+
+		let vc = SFSafariViewController(url: url)
+		present(vc, animated: true)
+	}
 }
 
 // MARK: ArticleExtractorDelegate

iOS/KeyboardManager.swift

@@ -177,6 +177,9 @@ private extension KeyboardManager {
 		let openInBrowserTitle = NSLocalizedString("Open In Browser", comment: "Open In Browser")
 		keys.append(KeyboardManager.createKeyCommand(title: openInBrowserTitle, action: "openInBrowser:", input: UIKeyCommand.inputRightArrow, modifiers: [.command]))
 
+		let openInAppBrowserTitle = NSLocalizedString("Open In App Browser", comment: "Open In App Browser")
+		keys.append(KeyboardManager.createKeyCommand(title: openInAppBrowserTitle, action: "openInAppBrowser:", input: "\r", modifiers: []))
+
 		let toggleReadTitle = NSLocalizedString("Toggle Read Status", comment: "Toggle Read Status")
 		keys.append(KeyboardManager.createKeyCommand(title: toggleReadTitle, action: "toggleRead:", input: "u", modifiers: [.command, .shift]))
 

iOS/MasterFeed/MasterFeedViewController.swift

@@ -11,6 +11,7 @@ import Account
 import Articles
 import RSCore
 import RSTree
+import SafariServices
 
 class MasterFeedViewController: UITableViewController, UndoableCommandRunner {
 
@@ -515,6 +516,13 @@ class MasterFeedViewController: UITableViewController, UndoableCommandRunner {
 		becomeFirstResponder()
 	}
 
+	func openInAppBrowser() {
+		if let indexPath = coordinator.currentFeedIndexPath,
+			let url = coordinator.homePageURLForFeed(indexPath) {
+			let vc = SFSafariViewController(url: url)
+			present(vc, animated: true)
+		}
+	}
 }
 
 // MARK: UIContextMenuInteractionDelegate

iOS/RootSplitViewController.swift

@@ -82,6 +82,14 @@ class RootSplitViewController: UISplitViewController {
 		coordinator.showBrowserForCurrentArticle()
 	}
 
+	@objc func openInAppBrowser(_ sender: Any?) {
+		coordinator.showInAppBrowserForCurrentArticle()
+	}
+
+	@objc func openFeedInAppBrowser(_ sender: Any?) {
+		coordinator.showInAppBrowserForCurrentFeed()
+	}
+	
 	@objc func articleSearch(_ sender: Any?) {
 		coordinator.showSearch()
 	}

iOS/SceneCoordinator.swift

@@ -12,6 +12,7 @@ import Account
 import Articles
 import RSCore
 import RSTree
+import SafariServices
 
 enum PanelMode {
 	case unset
@@ -1184,6 +1185,14 @@ class SceneCoordinator: NSObject, UndoableCommandRunner, UnreadCountProvider {
 		UIApplication.shared.open(url, options: [:])
 	}
 
+	func showInAppBrowserForCurrentArticle() {
+		articleViewController?.openInAppBrowser()
+	}
+
+	func showInAppBrowserForCurrentFeed() {
+		masterFeedViewController.openInAppBrowser()
+	}
+	
 	func navigateToFeeds() {
 		masterFeedViewController?.focus()
 		selectArticle(nil)