FreshRSS
/
NetNewsWire
mirror of https://github.com/Ranchero-Software/NetNewsWire.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2867 from brehaut/main 

#2371 Checks footnote target before overriding browser default behavior
This commit is contained in:
Maurice Parker 2021-03-10 18:39:52 -06:00 committed by GitHub
parent 7d2f9d9cb9 b9ea58dc4f
commit 1b6ec8cfd7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Shared/Article Rendering/newsfoot.js
View File

@ -140,12 +140,17 @@
if (targetId) break; if (targetId) break;
} }
if (targetId === undefined) return; if (targetId === undefined) return;
// Only override the default behaviour when we know we can find the
// target element
const targetElement = document.getElementById(targetId);
if (targetElement === null) return;
ev.preventDefault(); ev.preventDefault();
installContainer(ev.target); installContainer(ev.target);
const content = document.querySelector(`[id='${targetId}']`).innerHTML;
void new Footnote(content, ev.target); void new Footnote(targetElement.innerHTML, ev.target);
}); });
// Handle clicks on the footnote reverse link // Handle clicks on the footnote reverse link