FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2024-12-20 14:33:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make feed icons show up more promptly and reliably in the timeline.

Browse Source
This commit is contained in:
Brent Simmons 2018-01-08 21:34:39 -08:00
parent 6d94372eef
commit 1b0648cd18
3 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Evergreen/Images/ImageDownloader.swift
View File

@ -131,6 +131,8 @@ private extension ImageDownloader {
func postImageDidBecomeAvailableNotification(_ url: String) {
NotificationCenter.default.post(name: .ImageDidBecomeAvailable, object: self, userInfo: [UserInfoKey.url: url])
DispatchQueue.main.async {
NotificationCenter.default.post(name: .ImageDidBecomeAvailable, object: self, userInfo: [UserInfoKey.url: url])
}
}
}

33
Evergreen/MainWindow/Timeline/TimelineViewController.swift
View File

@ -51,6 +51,7 @@ class TimelineViewController: NSViewController, UndoableCommandRunner {
private var didRegisterForNotifications = false
private let timelineFontSizeKVOKey = "values.{AppDefaults.Key.timelineFontSize}"
private var reloadAvailableCellsTimer: Timer?
private var articles = ArticleArray() {
didSet {
@ -117,6 +118,7 @@ class TimelineViewController: NSViewController, UndoableCommandRunner {
NotificationCenter.default.addObserver(self, selector: #selector(statusesDidChange(_:)), name: .StatusesDidChange, object: nil)
NotificationCenter.default.addObserver(self, selector: #selector(feedIconDidBecomeAvailable(_:)), name: .FeedIconDidBecomeAvailable, object: nil)
NotificationCenter.default.addObserver(self, selector: #selector(avatarDidBecomeAvailable(_:)), name: .AvatarDidBecomeAvailable, object: nil)
NotificationCenter.default.addObserver(self, selector: #selector(imageDidBecomeAvailable(_:)), name: .ImageDidBecomeAvailable, object: nil)
NSUserDefaultsController.shared.addObserver(self, forKeyPath: timelineFontSizeKVOKey, options: NSKeyValueObservingOptions(rawValue: 0), context: nil)
@ -347,6 +349,11 @@ class TimelineViewController: NSViewController, UndoableCommandRunner {
}
}
@objc func imageDidBecomeAvailable(_ note: Notification) {
queueReloadAvailableCells()
}
func fontSizeInDefaultsDidChange() {
TimelineCellData.emptyCache()
@ -554,6 +561,32 @@ extension TimelineViewController: NSTableViewDelegate {
private extension TimelineViewController {
func reloadAvailableCells() {
if let indexesToReload = tableView.indexesOfAvailableRows() {
reloadCells(for: indexesToReload)
}
}
func queueReloadAvailableCells() {
invalidateReloadTimer()
reloadAvailableCellsTimer = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: false) { (timer) in
self.reloadAvailableCells()
self.invalidateReloadTimer()
}
}
func invalidateReloadTimer() {
if let timer = reloadAvailableCellsTimer {
if timer.isValid {
timer.invalidate()
}
reloadAvailableCellsTimer = nil
}
}
func updateShowAvatars() {
if showFeedNames {

7
Frameworks/RSCore/RSCore/NSTableView+Extensions.swift
View File

@ -30,6 +30,13 @@ public extension NSTableView {
return indexes.isEmpty ? nil : indexes
}
func indexesOfAvailableRows() -> IndexSet? {
var indexes = IndexSet()
enumerateAvailableRowViews { indexes.insert($1) }
return indexes.isEmpty ? nil : indexes
}
func scrollTo(row: Int) {
guard let scrollView = self.enclosingScrollView else {