From 055770fe2263289f6a5e308b30a055e2d733939c Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Fri, 4 Jan 2019 17:20:32 -0500 Subject: [PATCH 1/2] changed font color to textColor so that it adapts to darkmode --- NetNewsWire/Resources/Credits.rtf | 28 +++++++++++++-------------- NetNewsWire/Resources/MAS/Credits.rtf | 26 ++++++++++++------------- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/NetNewsWire/Resources/Credits.rtf b/NetNewsWire/Resources/Credits.rtf index 6f4535ebd..9f75bfd28 100644 --- a/NetNewsWire/Resources/Credits.rtf +++ b/NetNewsWire/Resources/Credits.rtf @@ -1,44 +1,44 @@ -{\rtf1\ansi\ansicpg1252\cocoartf1671\cocoasubrtf100 +{\rtf1\ansi\ansicpg1252\cocoartf1671\cocoasubrtf200 {\fonttbl\f0\fnil\fcharset0 LucidaGrande-Bold;\f1\fnil\fcharset0 LucidaGrande;} -{\colortbl;\red255\green255\blue255;} -{\*\expandedcolortbl;;} +{\colortbl;\red255\green255\blue255;\red0\green0\blue0;} +{\*\expandedcolortbl;;\cssrgb\c0\c0\c0\cname textColor;} \vieww14060\viewh15660\viewkind0 \pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\sl360\slmult1\pardirnatural\partightenfactor0 -\f0\b\fs22 \cf0 By Brent Simmons\ +\f0\b\fs22 \cf2 By Brent Simmons\ {\field{\*\fldinst{HYPERLINK "http://inessential.com/"}}{\fldrslt inessential.com}} \f1\b0 \ \pard\pardeftab720\li360\sa60\partightenfactor0 -\cf0 \ +\cf2 \ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Credits: +\f0\b \cf2 Credits: \f1\b0 \ \pard\pardeftab720\li360\sa60\partightenfactor0 -\cf0 App icon and most other icons: {\field{\*\fldinst{HYPERLINK "https://twitter.com/BradEllis"}}{\fldrslt Brad Ellis}}\ +\cf2 App icon and most other icons: {\field{\*\fldinst{HYPERLINK "https://twitter.com/BradEllis"}}{\fldrslt Brad Ellis}}\ Major code contributors: {\field{\*\fldinst{HYPERLINK "https://github.com/olofhellman"}}{\fldrslt Olof Hellman}}, {\field{\*\fldinst{HYPERLINK "https://github.com/vincode-io"}}{\fldrslt Maurice Parker}}, and {\field{\*\fldinst{HYPERLINK "https://github.com/danielpunkass"}}{\fldrslt Daniel Jalkut\ }}\ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Acknowledgments: +\f0\b \cf2 Acknowledgments: \f1\b0 \ \pard\pardeftab720\li360\sa60\partightenfactor0 -{\field{\*\fldinst{HYPERLINK "https://github.com/ccgus/fmdb"}}{\fldrslt \cf0 FMDB}} (greatest SQLite wrapper ever in history) is by {\field{\*\fldinst{HYPERLINK "http://flyingmeat.com/"}}{\fldrslt Flying Meat Software}}.\ +{\field{\*\fldinst{HYPERLINK "https://github.com/ccgus/fmdb"}}{\fldrslt \cf2 FMDB}} (greatest SQLite wrapper ever in history) is by {\field{\*\fldinst{HYPERLINK "http://flyingmeat.com/"}}{\fldrslt Flying Meat Software}}.\ \pard\pardeftab720\li360\sa60\partightenfactor0 -{\field{\*\fldinst{HYPERLINK "https://sparkle-project.org/"}}{\fldrslt \cf0 Sparkle}} is by Sparkle Project.\ +{\field{\*\fldinst{HYPERLINK "https://sparkle-project.org/"}}{\fldrslt \cf2 Sparkle}} is by Sparkle Project.\ \ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Thanks:\ +\f0\b \cf2 Thanks:\ \pard\pardeftab720\li360\sa60\partightenfactor0 -\f1\b0 \cf0 Thanks to Sheila and my family; thanks to my friends in Seattle and around the globe; thanks to my co-workers and friends at {\field{\*\fldinst{HYPERLINK "https://www.omnigroup.com/"}}{\fldrslt The Omni Group}}; thanks to the ever-patient and ever-awesome NetNewsWire beta testers.\ +\f1\b0 \cf2 Thanks to Sheila and my family; thanks to my friends in Seattle and around the globe; thanks to my co-workers and friends at {\field{\*\fldinst{HYPERLINK "https://www.omnigroup.com/"}}{\fldrslt The Omni Group}}; thanks to the ever-patient and ever-awesome NetNewsWire beta testers.\ \ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Dedication:\ +\f0\b \cf2 Dedication:\ \pard\pardeftab720\li360\sa60\partightenfactor0 -\f1\b0 \cf0 NetNewsWire 5.0 is dedicated to Aaron Swartz, Derek Miller, and Alex King, who helped with earlier versions of NetNewsWire, who I miss.\ +\f1\b0 \cf2 NetNewsWire 5.0 is dedicated to Aaron Swartz, Derek Miller, and Alex King, who helped with earlier versions of NetNewsWire, who I miss.\ \ } \ No newline at end of file diff --git a/NetNewsWire/Resources/MAS/Credits.rtf b/NetNewsWire/Resources/MAS/Credits.rtf index 54d144f8a..0ccb7be02 100644 --- a/NetNewsWire/Resources/MAS/Credits.rtf +++ b/NetNewsWire/Resources/MAS/Credits.rtf @@ -1,42 +1,42 @@ -{\rtf1\ansi\ansicpg1252\cocoartf1671\cocoasubrtf100 +{\rtf1\ansi\ansicpg1252\cocoartf1671\cocoasubrtf200 {\fonttbl\f0\fnil\fcharset0 LucidaGrande-Bold;\f1\fnil\fcharset0 LucidaGrande;} -{\colortbl;\red255\green255\blue255;} -{\*\expandedcolortbl;;} +{\colortbl;\red255\green255\blue255;\red0\green0\blue0;} +{\*\expandedcolortbl;;\cssrgb\c0\c0\c0\cname textColor;} \vieww14060\viewh15660\viewkind0 \pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\sl360\slmult1\pardirnatural\partightenfactor0 -\f0\b\fs22 \cf0 By Brent Simmons\ +\f0\b\fs22 \cf2 By Brent Simmons\ {\field{\*\fldinst{HYPERLINK "http://inessential.com/"}}{\fldrslt inessential.com}} \f1\b0 \ \pard\pardeftab720\li360\sa60\partightenfactor0 -\cf0 \ +\cf2 \ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Credits: +\f0\b \cf2 Credits: \f1\b0 \ \pard\pardeftab720\li360\sa60\partightenfactor0 -\cf0 App icon and most other icons: {\field{\*\fldinst{HYPERLINK "https://twitter.com/BradEllis"}}{\fldrslt Brad Ellis}}\ +\cf2 App icon and most other icons: {\field{\*\fldinst{HYPERLINK "https://twitter.com/BradEllis"}}{\fldrslt Brad Ellis}}\ Major code contributors: {\field{\*\fldinst{HYPERLINK "https://github.com/olofhellman"}}{\fldrslt Olof Hellman}}, {\field{\*\fldinst{HYPERLINK "https://github.com/vincode-io"}}{\fldrslt Maurice Parker}}, and {\field{\*\fldinst{HYPERLINK "https://github.com/danielpunkass"}}{\fldrslt Daniel Jalkut\ }}\ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Acknowledgments: +\f0\b \cf2 Acknowledgments: \f1\b0 \ \pard\pardeftab720\li360\sa60\partightenfactor0 -{\field{\*\fldinst{HYPERLINK "https://github.com/ccgus/fmdb"}}{\fldrslt \cf0 FMDB}} (greatest SQLite wrapper ever in history) is by {\field{\*\fldinst{HYPERLINK "http://flyingmeat.com/"}}{\fldrslt Flying Meat Software}}.\ +{\field{\*\fldinst{HYPERLINK "https://github.com/ccgus/fmdb"}}{\fldrslt \cf2 FMDB}} (greatest SQLite wrapper ever in history) is by {\field{\*\fldinst{HYPERLINK "http://flyingmeat.com/"}}{\fldrslt Flying Meat Software}}.\ \ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Thanks:\ +\f0\b \cf2 Thanks:\ \pard\pardeftab720\li360\sa60\partightenfactor0 -\f1\b0 \cf0 Thanks to Sheila and my family; thanks to my friends in Seattle and around the globe; thanks to my co-workers and friends at {\field{\*\fldinst{HYPERLINK "https://www.omnigroup.com/"}}{\fldrslt The Omni Group}}; thanks to the ever-patient and ever-awesome NetNewsWire beta testers.\ +\f1\b0 \cf2 Thanks to Sheila and my family; thanks to my friends in Seattle and around the globe; thanks to my co-workers and friends at {\field{\*\fldinst{HYPERLINK "https://www.omnigroup.com/"}}{\fldrslt The Omni Group}}; thanks to the ever-patient and ever-awesome NetNewsWire beta testers.\ \ \pard\pardeftab720\sa60\partightenfactor0 -\f0\b \cf0 Dedication:\ +\f0\b \cf2 Dedication:\ \pard\pardeftab720\li360\sa60\partightenfactor0 -\f1\b0 \cf0 NetNewsWire 5.0 is dedicated to Aaron Swartz, Derek Miller, and Alex King, who helped with earlier versions of NetNewsWire, who I miss.\ +\f1\b0 \cf2 NetNewsWire 5.0 is dedicated to Aaron Swartz, Derek Miller, and Alex King, who helped with earlier versions of NetNewsWire, who I miss.\ \ } \ No newline at end of file From 9b6ace9f3082493047ca963fe18bdc5e4aeeb5a3 Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Sat, 5 Jan 2019 13:59:02 -0500 Subject: [PATCH 2/2] added Accessibility technote --- Technotes/Accessibility.md | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Technotes/Accessibility.md diff --git a/Technotes/Accessibility.md b/Technotes/Accessibility.md new file mode 100644 index 000000000..87e87fafe --- /dev/null +++ b/Technotes/Accessibility.md @@ -0,0 +1,37 @@ +# Accessibility + +Millions of Mac users have some disability or special needs. They use screen readers and special +hardware to open up a world that they would otherwise be cut off from. With a small amount of +developer work, we can help these users live better lives. + +Because NetNewsWire utilizes standard AppKit controls and views, accessibility is already built in. +However this is only a starting point. Any customized controls and views will have accessibility +work and the application as a whole has to be tested to make sure users can operate if effeciently. + +This document lays the groundwork to ensure that NetNewsWire has first class accessibility features. + +#### Application Design + +- Support full keyboard navigation +- Don’t override built-in keyboard shortcuts (by default) +- Provide alternatives for drag-and-drop operations + +#### Audit + +The Accessibility Inspector included with the developer tools includes an automated audit tool. This +tool didn't find an issues when initially run against NetNewsWire. Additional auditing will be +performed using the Inspector functionality within the Accessibility Inspector tool. + +#### Testing + +Manual testing using VoiceOver and Dictation will be done to provide more realworld-like feedback. + +#### Reporting Accessibility Issues + +The results of the accessiblity audit should get filed as separate bugs on Github. + +#### Success Criteria + +- Should be fully navigatable using the keyboard +- Should be fully navigatable using Dictation +- SHould be fully discoverable using VoiceOver \ No newline at end of file