FreshRSS/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire.git synced 2024-12-25 17:12:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Validate unread counts on fetching articles. Fix #274.

Browse Source
This commit is contained in:
Brent Simmons 2017-12-26 11:27:55 -08:00
parent 817a69e618
commit 0b2d7c6733
1 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Frameworks/Account/Account.swift
View File

@ -329,12 +329,35 @@ public final class Account: DisplayNameProvider, UnreadCountProvider, Container,
public func fetchArticles(for feed: Feed) -> Set<Article> {
return database.fetchArticles(for: feed)
let articles = database.fetchArticles(for: feed)
validateUnreadCount(feed, articles)
return articles
}
public func fetchArticles(folder: Folder) -> Set<Article> {
return database.fetchUnreadArticles(for: folder.flattenedFeeds())
let feeds = folder.flattenedFeeds()
let articles = database.fetchUnreadArticles(for: feeds)
feeds.forEach { validateUnreadCount($0, articles) }
return articles
}
private func validateUnreadCount(_ feed: Feed, _ articles: Set<Article>) {
// articles must contain all the unread articles for the feed.
// The unread number should match the feed’s unread count.
let feedUnreadCount = articles.reduce(0) { (result, article) -> Int in
if article.feed == feed && !article.status.read {
return result + 1
}
return result
}
if feedUnreadCount != feed.unreadCount {
assertionFailure("Expected feed.unreadCount \(feed.unreadCount) to equal number of fetched unread articles \(feedUnreadCount).")
feed.unreadCount = feedUnreadCount
}
}
public func fetchUnreadCountForToday(_ callback: @escaping (Int) -> Void) {