Commit Graph

6051 Commits

Author SHA1 Message Date
Alexandre Alapetite 314077a457
PHPStan prepare exceptions (#6037)
Take advantage of
https://phpstan.org/blog/bring-your-exceptions-under-control

Minimum changes to pass `tooWideThrowType` and `implicitThrows`.

Revert some mistakes from:
https://github.com/FreshRSS/FreshRSS/pull/5504
Preparation needed before new PRs of the same type:
https://github.com/FreshRSS/FreshRSS/pull/5962

Fix several wrong PHPDocs and catches:

> Method ... has ...Exception in PHPDoc @throws tag but it's not thrown.

> Dead catch - ...Exception is never thrown in the try block.
2024-01-15 10:36:30 +01:00
Alexandre Alapetite 52f6c8399b
Explicit PHP version for Composer (#6039)
* Explicit PHP version for Composer
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/6038
Ensure that we do not depend on incompatible libraries like in
https://github.com/FreshRSS/FreshRSS/pull/6030

* Explicit version for PHPStan
Due to changes in types, we only support PHPStan in PHP 8 mode
2024-01-15 10:32:30 +01:00
Alexandre Alapetite 74ed1e6c57
Fix PHP 7.4 compatibility (#6038)
Some recent PRs have broken PHP 7.4 compatibility due to `mixed` typing.
2024-01-13 17:02:39 +01:00
eta-orionis 9c97d8ca72
JSONFeeds, JSON scraping, and POST requests for feeds (#5662)
* allow POST requests for feeds

* added json dotpath and jsonfeed subscriptions. No translation strings yet

* debug and fix jsonfeed parser

* bugfix params saved when editing feed

* added translations for JSON features

* Update docs for web scraping

* make fix-all
and revert unrelated changes, plus a few manual fixes, but there are still several type errors

* Fix some i18n

* refactor json parsing for both feed types

* cleanup unnecessary comment

* refactored generation of SimplePie for XPath and JSON feeds

* Fix merge error

* Update to newer FreshRSS code

* A bit of refactoring

* doc, whitespace

* JSON Feed is in two words

* Add support for array syntax

* Whitespace

* Add OPML export/import

* Work on i18n

* Accept application/feed+json

* Rework POST

* Fix update

* OPML for cURL options

* Fix types

* Fix Typos

---------

Co-authored-by: Erion Elmasllari <elmasllari@factorsixty.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-01-10 08:23:45 +01:00
Kasimir Cash 9a80dde238
2297 cli parameters consistency (#6028)
* Updates do-install params

* Adds parseCliParams to _cli.php

* Updates do-install to use parseCliParams

* Updates reconfigure to use parseCliParams

* Fixes bug mail_login => email

* Update create-user to use parseCliParams

* Minor refactor

* Updates update-user to use parseCliParams

* Fix no_default_feeds => no-default-feeds

* Refactors arrays

* Updates CLI Readme

* Adds docblocks to _cli functions

* Sets vars in _cli functions

* Fixes indentation

* Meeting coding standards around colons

* Meeting PHPStan standards

* Removes stray whitespace

* Meeting PHPStan Next Level standards

* More specific typing

* Maintaining types

* Typing around getopt()

* Fixes typo

* Fixes typo perameters -> parameters

* Removes unused variable

* Rewrites deprecation warning message
2024-01-09 23:01:17 +01:00
Alexandre Alapetite c89073d60e
Update dev dependencies (#6023) 2024-01-05 08:45:21 +01:00
Alexandre Alapetite 4704c11d17
Update to PHPMailer 6.9.1 (#6022) 2024-01-05 08:45:07 +01:00
Simone 889746cb10
Update CREDITS.md (#6019) 2024-01-03 16:40:20 +01:00
Simone 6075ee8158
i18n: Italian: fixed-typo (#6018)
Non sure if there are other occurrences.
2024-01-03 16:21:36 +01:00
Alexandre Alapetite 70e71b8364
Auto-label (#5954)
Add labels automatically to incoming articles
fix https://github.com/FreshRSS/FreshRSS/issues/2380
fix https://github.com/FreshRSS/FreshRSS/issues/2420
fix https://github.com/FreshRSS/FreshRSS/issues/3279
fix https://github.com/FreshRSS/FreshRSS/discussions/4947
fix https://github.com/FreshRSS/FreshRSS/issues/5728
fix https://github.com/FreshRSS/FreshRSS/issues/5599
2024-01-03 11:23:06 +01:00
Alexandre Alapetite 1e5f5078ed
Sanitize parsing list of extensions (#6016)
fix https://github.com/FreshRSS/FreshRSS/issues/6015
2024-01-03 10:26:09 +01:00
Alexandre Alapetite e240ee1caf
API allow negative feed IDs (#6010)
For future features (e.g. save articles by URL, save a manual note, ...), it would be good to allow special feeds, and to use negative integers for that. The rest of FreshRSS seems to be already ready, and there was only the Google Reader API, which required positive integers for feed IDs.
I quickly tested apps such as News+, EasyRSS, Rreadrops, which seem fine with that, but help welcome to test compatibility more thoroughly.
2024-01-02 19:23:09 +01:00
laxmanpradhan 77108ea19e
Authentik oAuth setup documentation updates (#5969)
* Update 16_OpenID-Connect-Authentik.md

updated docs

* Add files via upload

* Update 16_OpenID-Connect-Authentik.md

Updated documentation with many clarifications. The most important one is the redirect URL which must include the port or it will not work. To ensure compatibility, I have recommended both URLs be added, with and without the port. Example docker-compose also added with traefik reverse proxy.

* Reduce screenshot size

* Fixes and improvements

* Allow changing auth to HTTP

---------

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2023-12-30 23:45:31 +01:00
Alexandre Alapetite a3ebfe76ea
Docker Debian disable unused PHP modules (#5994)
https://github.com/FreshRSS/FreshRSS/issues/5993
2023-12-30 23:42:57 +01:00
András Marczinkó 0c178fe562
Translated the websub help line in the Hungarian translation (#6005) 2023-12-30 23:41:15 +01:00
Alexandre Alapetite 9c104ee6bb
Prepare next dev version 2023-12-30 17:29:27 +01:00
Alexandre Alapetite 227233b4ef
Release 1.23.1 2023-12-30 17:17:00 +01:00
maTh 6a43d06566
fix:remove duplicated lines that are given in frss.css (#5999) 2023-12-29 22:58:28 +01:00
András Marczinkó 9dec2af35d
Fixed peroid names in the Hungarian translation (#6000) 2023-12-29 22:46:04 +01:00
Alexandre Alapetite 386c982443
Doc Web git update (#5995)
https://github.com/FreshRSS/FreshRSS/discussions/5991
2023-12-29 13:36:43 +01:00
Alexandre Alapetite 39952f57fb
Minor .dockerignore (#5996) 2023-12-29 13:36:30 +01:00
yzqzss 2bd9f63030
fix: `base_url` becomes empty after saving configuration (#5992)
* fix: `base_url` becomes empty after saving configuration

* Just remove the line

* Use read-ony instead
https://developer.mozilla.org/docs/Web/HTML/Attributes/readonly#attribute_interactions

* Revert for websub

* Changelog

---------

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2023-12-28 20:06:26 +01:00
Alexandre Alapetite 08345d0a95
Changelog 2023-12-28 14:10:32 +01:00
Alexandre Alapetite 65c6c2d5cb
Fix export with MySQL (#5988)
fix https://github.com/FreshRSS/FreshRSS/issues/5982
2023-12-28 13:09:51 +01:00
Alexandre Alapetite 8b090ee4a3
Changelog 2023-12-27 15:28:12 +01:00
Alexandre Alapetite d65f77c081
More robust assignment of categories to feeds (#5986)
Several minor cases, none of which should really be necessary
Might help:
https://github.com/FreshRSS/FreshRSS/issues/5981
https://github.com/FreshRSS/FreshRSS/issues/5982
2023-12-27 15:18:36 +01:00
Alexandre Alapetite e968964538
Fix show_tags_max (#5978)
fix https://github.com/FreshRSS/FreshRSS/issues/5975
Regression from https://github.com/FreshRSS/FreshRSS/pull/5830
2023-12-26 16:30:32 +01:00
Alexandre Alapetite bf1eda8c05
Fix extensions enableByList (#5979)
fix https://github.com/FreshRSS/FreshRSS/issues/5976
fix https://github.com/YunoHost-Apps/freshrss_ynh/pull/176
2023-12-26 12:17:52 +01:00
Zhiyuan Zheng ec7fd382e5
Update zh-cn translations (#5977)
* Add zh-cn translation.

* Update admin.php

* Update conf.php

* Update conf.php

* Update feedback.php

* Update gen.php

* Update sub.php
2023-12-26 11:38:15 +01:00
Alexandre Alapetite 941b370fe5
Start 1.23.1-dev 2023-12-24 11:37:36 +01:00
Alexandre Alapetite a67c11c52d
Release 1.23.0 2023-12-24 11:22:44 +01:00
Alexandre Alapetite ad990a21a1
Fix extensions getUserConfiguration
fix https://github.com/FreshRSS/FreshRSS/issues/5970
Regression from https://github.com/FreshRSS/FreshRSS/pull/5957
2023-12-23 11:34:18 +01:00
Alexandre Alapetite ac5980231b
API add unsubscribe example (#5965) 2023-12-23 11:07:14 +01:00
Alexandre Alapetite 6d2e53178b
Typed Minz_Extension (#5957)
Replaces https://github.com/FreshRSS/FreshRSS/pull/5837
The signature of methods supposed to be overriden by existing thid-party extensions cannot be modified
2023-12-22 11:03:47 +01:00
Alexandre Alapetite c7a3281a73
Fix notifications (#5959)
The notification about wrong login was not working. Noticed while working on https://github.com/FreshRSS/FreshRSS/pull/5955
This was due to timing of when the notification is retrieved.
Simplified code to make the logic easier and more robust.
2023-12-22 11:03:32 +01:00
Alexandre Alapetite bd9e33a25c
Changelog 2023-12-20 23:15:15 +01:00
Alexandre Alapetite 79604aa4b3
Fix login (#5955)
fix https://github.com/FreshRSS/FreshRSS/issues/5953
Regression due to https://github.com/FreshRSS/FreshRSS/pull/5946
2023-12-20 16:36:55 +01:00
Alexandre Alapetite a80a5f48a1
Pass PHPStan level 8 (#5946)
* Pass PHPStan level 8
And prepare for PHPStan level 9 https://phpstan.org/user-guide/rule-levels

* Revert wrong replace in comment

* Fix PHPStan level 8

* Update PHPStan and other dev dependencies

* Remove obsolete comment

* noVariableVariables and towards bleedingEdge
https://github.com/phpstan/phpstan-strict-rules
https://phpstan.org/blog/what-is-bleeding-edge

* More bleedingEdge

* A bit more PHPStan level 9

* More PHPStan level 9

* Prepare for booleansInConditions
Ignore int and null

* Revert wrong line

* More fixes

* Fix keep_max_n_unread

* Stricter attribute functions

* Stricter callHooks and more PHPStan level 9

* More typing

* A tiny more
2023-12-18 17:59:16 +01:00
Alexandre Alapetite 6bb45a8726
Add filter actions (auto mark read) at category and global levels (#5942)
* Add filter actions (auto mark read) at category level
fix https://github.com/FreshRSS/FreshRSS/issues/3497

* Add filter actions (auto mark read) at global level
fix https://github.com/FreshRSS/FreshRSS/issues/2788

* Fix feed category ID

* Minor comment
2023-12-15 23:04:29 +01:00
Alexandre Alapetite a3ed826913
Remove variable default_category (#5945)
Not really used, and causing bug in https://github.com/FreshRSS/FreshRSS/pull/5942

```
Fatal error: Uncaught Error: Typed property FreshRSS_View::$default_category must not be accessed before initialization in /var/www/FreshRSS/app/views/helpers/category/update.phtml:218 Stack trace: #0 /var/www/FreshRSS/lib/Minz/View.php(93): include() #1 /var/www/FreshRSS/lib/Minz/View.php(143): Minz_View->includeFile() #2 /var/www/FreshRSS/app/views/category/update.phtml(9): Minz_View->renderHelper() #3 /var/www/FreshRSS/lib/Minz/View.php(93): include('...') #4 /var/www/FreshRSS/lib/Minz/View.php(115): Minz_View->includeFile() #5 /var/www/FreshRSS/lib/Minz/View.php(75): Minz_View->render() #6 /var/www/FreshRSS/lib/Minz/Dispatcher.php(59): Minz_View->build() #7 /var/www/FreshRSS/lib/Minz/FrontController.php(61): Minz_Dispatcher->run() #8 /var/www/FreshRSS/p/i/index.php(59): Minz_FrontController->run() #9 {main} thrown in /var/www/FreshRSS/app/views/helpers/category/update.phtml on line 218
```
2023-12-14 22:11:04 +01:00
Alexandre Alapetite 6a04503c7e
Fix read_when_same_title_in_feed (#5937)
fix https://github.com/FreshRSS/FreshRSS/issues/5936
2023-12-10 14:05:11 +01:00
Kasimir Cash ea6b8b7c6f
Fix font priority for languages using Han characters (#5930)
* Remove chinese fonts from themes (#5670)

* Adds name to credits
2023-12-10 12:42:08 +01:00
Alexandre Alapetite f7c160b9af
Alpine 3.19 (#5933)
https://alpinelinux.org/posts/Alpine-3.19.0-released.html
Apache/2.4.58, PHP 8.2.13
2023-12-10 12:41:49 +01:00
Alexandre Alapetite b46ea88c35
Fix archiving (#5935)
fix https://github.com/FreshRSS/FreshRSS/issues/5934
Regression from https://github.com/FreshRSS/FreshRSS/pull/5830
2023-12-10 12:41:24 +01:00
Alexandre Alapetite 803fa8fdb5
Fix PHP7 susbtr (#5929)
fix https://github.com/FreshRSS/FreshRSS/issues/5928
`susbstr` might return false in PHP7
Regression from https://github.com/FreshRSS/FreshRSS/pull/5830
2023-12-06 11:58:49 +01:00
Alexandre Alapetite 8bff77c45e
Fix export (#5927)
Regression from https://github.com/FreshRSS/FreshRSS/pull/5830
2023-12-06 08:51:42 +01:00
Alexandre Alapetite 133892a89e
Better debug SQL error (#5916)
* Better debug SQL error

* Fix check
2023-12-03 22:30:15 +01:00
Alexandre Alapetite f0d4f2762d
Rework keepmax (#5905)
* Rework keepmax
fix https://github.com/FreshRSS/FreshRSS/issues/5702
fix https://github.com/FreshRSS/FreshRSS/issues/5870

* More WIP

* Minor progress

* Progress

* Beta

* Improved debug message

* Revert noCommit

* Fix variable reset

* Remove debug syslogs
2023-12-03 19:52:02 +01:00
András Marczinkó eb2c2d9a01
Updated Hungarian translation (#5918)
* Updated Hungarian translation

* Fix typos config

---------

Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2023-12-03 14:08:48 +01:00
Alexandre Alapetite 8c18dc16a9
Allow reas-as-scroll in important view (#5906)
And within a single feed
See https://github.com/FreshRSS/FreshRSS/pull/5782#issuecomment-1810065152
2023-12-03 11:35:36 +01:00