FreshRSS
/
FreshRSS
mirror of https://github.com/FreshRSS/FreshRSS.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix: Favicon with protocol-relative URLs have duplicate slashes. (#6068) 

The URL of favicons with protocol-relative URL's already start with "//" so by adding it again it will result in "http:////url" and the icon will never be retrieved.
This commit is contained in:
Thomas Renes 2024-01-26 11:08:10 +01:00 committed by GitHub
parent d61734a5e0
commit 0c023a7b5c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/favicons.php
View File

@ -92,7 +92,7 @@ function searchFavicon(string &$url): string {
// Handle protocol-relative URLs by adding the current URL's scheme
if (substr($href, 0, 2) === '//') {
$href = ($urlParts['scheme'] ?? 'https') . '://' . $href;
$href = ($urlParts['scheme'] ?? 'https') . ':' . $href;
}
$href = SimplePie_IRI::absolutize($baseUrl, $href);