Reduce log spam from browsing preferences

These get called not only when preferences actually change, but also
when pages are loaded, so the logs are very noisy.
This commit is contained in:
José Rebelo 2025-02-23 22:22:22 +00:00
parent b81784f3b9
commit 82edf9095e

View File

@ -171,7 +171,7 @@ public abstract class AbstractPreferenceFragment extends PreferenceFragmentCompa
for (int i = 0; i < preferenceGroup.getPreferenceCount(); i++) { for (int i = 0; i < preferenceGroup.getPreferenceCount(); i++) {
final Preference preference = preferenceGroup.getPreference(i); final Preference preference = preferenceGroup.getPreference(i);
LOG.debug("Reloading {}", preference.getKey()); LOG.trace("Reloading {}", preference.getKey());
if (preference instanceof PreferenceCategory) { if (preference instanceof PreferenceCategory) {
reloadPreferences(sharedPreferences, (PreferenceCategory) preference); reloadPreferences(sharedPreferences, (PreferenceCategory) preference);
@ -188,7 +188,7 @@ public abstract class AbstractPreferenceFragment extends PreferenceFragmentCompa
private class SharedPreferencesChangeHandler implements SharedPreferences.OnSharedPreferenceChangeListener { private class SharedPreferencesChangeHandler implements SharedPreferences.OnSharedPreferenceChangeListener {
@Override @Override
public void onSharedPreferenceChanged(final SharedPreferences prefs, final String key) { public void onSharedPreferenceChanged(final SharedPreferences prefs, final String key) {
LOG.debug("Preference changed: {}", key); LOG.trace("Preference changed: {}", key);
if (key == null) { if (key == null) {
LOG.warn("Preference null, ignoring"); LOG.warn("Preference null, ignoring");
@ -214,8 +214,8 @@ public abstract class AbstractPreferenceFragment extends PreferenceFragmentCompa
} else if (preference instanceof EditTextPreference) { } else if (preference instanceof EditTextPreference) {
final EditTextPreference editTextPreference = (EditTextPreference) preference; final EditTextPreference editTextPreference = (EditTextPreference) preference;
editTextPreference.setText(prefs.getString(key, editTextPreference.getText())); editTextPreference.setText(prefs.getString(key, editTextPreference.getText()));
} else if (preference instanceof PreferenceScreen) { } else if (preference instanceof PreferenceScreen || Preference.class.equals(preference.getClass())) {
// Ignoring LOG.trace("Unknown preference class {} for {}, ignoring", preference.getClass(), key);
} else { } else {
LOG.warn("Unknown preference class {} for {}, ignoring", preference.getClass(), key); LOG.warn("Unknown preference class {} for {}, ignoring", preference.getClass(), key);
} }