Always name things positively. Negating things is bad for comprehension :-)

This commit is contained in:
cpfeiffer
2015-10-19 23:36:10 +02:00
parent 5a3990b9d2
commit 52f3ca5253
3 changed files with 6 additions and 4 deletions

View File

@@ -142,7 +142,7 @@ public abstract class AbstractBTLEDeviceSupport extends AbstractDeviceSupport im
return; return;
} }
Set<UUID> supportedServices = getSupportedServices(); Set<UUID> supportedServices = getSupportedServices();
mAvailableCharacteristics = new HashMap(); mAvailableCharacteristics = new HashMap<>();
for (BluetoothGattService service : discoveredGattServices) { for (BluetoothGattService service : discoveredGattServices) {
if (supportedServices.contains(service.getUuid())) { if (supportedServices.contains(service.getUuid())) {
List<BluetoothGattCharacteristic> characteristics = service.getCharacteristics(); List<BluetoothGattCharacteristic> characteristics = service.getCharacteristics();

View File

@@ -195,8 +195,9 @@
<string name="chart_steps">Steps</string> <string name="chart_steps">Steps</string>
<string name="liveactivity_live_activity">Live Activity</string> <string name="liveactivity_live_activity">Live Activity</string>
<string name="weeksteps_today_steps_description">Steps today, target: %1$s</string> <string name="weeksteps_today_steps_description">Steps today, target: %1$s</string>
<string name="pref_title_dont_ack_transfer">Do not ack activity data transfer</string>
<string name="pref_summary_dont_ack_transfers">If the activity data are not acked to the band, they will not be cleared. Useful if GB is used together with other apps.</string> <string name="pref_summary_dont_ack_transfers">If the activity data are not acked to the band, they will not be cleared. Useful if GB is used together with other apps.</string>
<string name="pref_summary_keep_data_on_device">Will keep activity data on the Mi Band even after synchronization. Useful if GB is used together with other apps.</string>
<string name="pref_title_dont_ack_transfer">Do not ack activity data transfer</string>
<string name="live_activity_steps_history">Steps History</string> <string name="live_activity_steps_history">Steps History</string>
<string name="live_activity_current_steps_per_minute">Current steps/min</string> <string name="live_activity_current_steps_per_minute">Current steps/min</string>
<string name="live_activity_total_steps">Total Steps</string> <string name="live_activity_total_steps">Total Steps</string>
@@ -208,4 +209,5 @@
<string name="abstract_chart_fragment_kind_not_worn">Not Worn</string> <string name="abstract_chart_fragment_kind_not_worn">Not Worn</string>
<string name="device_not_connected">Not connected.</string> <string name="device_not_connected">Not connected.</string>
<string name="user_feedback_all_alarms_disabled">All alarms disabled</string> <string name="user_feedback_all_alarms_disabled">All alarms disabled</string>
<string name="pref_title_keep_data_on_device">Keep activity data on device</string>
</resources> </resources>

View File

@@ -166,8 +166,8 @@
android:title="@string/pref_title_development_miaddr" /> android:title="@string/pref_title_development_miaddr" />
<CheckBoxPreference <CheckBoxPreference
android:key="mi_dont_ack_transfer" android:key="mi_dont_ack_transfer"
android:title="@string/pref_title_dont_ack_transfer" android:title="@string/pref_title_keep_data_on_device"
android:summary="@string/pref_summary_dont_ack_transfers" android:summary="@string/pref_summary_keep_data_on_device"
android:defaultValue="false" /> android:defaultValue="false" />
</PreferenceCategory> </PreferenceCategory>
</PreferenceScreen> </PreferenceScreen>