From 3645e36ab65d5fee2350b29358e8085e1052cfce Mon Sep 17 00:00:00 2001
From: Arjan Schrijver <a_gadgetbridge@anymore.nl>
Date: Fri, 16 Jul 2021 12:24:33 +0200
Subject: [PATCH] Fossil Hybrid HR: Make hardcoded strings translatable

---
 app/src/main/AndroidManifest.xml                 |  2 +-
 .../layout/dialog_hybridhr_watchface_widget.xml  | 16 ++++++++--------
 ...ity_hybridhr_watchface_designer_actionbar.xml |  4 ++--
 app/src/main/res/menu/appmanager_context.xml     |  2 +-
 app/src/main/res/values/strings.xml              | 12 ++++++++++++
 5 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 395e8fca6..98f586d9a 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -620,7 +620,7 @@
             android:parentActivityName=".devices.qhybrid.HRConfigActivity" />
         <activity
             android:name=".devices.qhybrid.HybridHRWatchfaceDesignerActivity"
-            android:label="Watchface designer"
+            android:label="@string/qhybrid_title_watchface_designer"
             android:parentActivityName=".activities.appmanager.AppManagerActivity" />
         <activity
             android:name=".devices.um25.Activity.DataActivity"
diff --git a/app/src/main/res/layout/dialog_hybridhr_watchface_widget.xml b/app/src/main/res/layout/dialog_hybridhr_watchface_widget.xml
index 9f45751c8..1201ca873 100644
--- a/app/src/main/res/layout/dialog_hybridhr_watchface_widget.xml
+++ b/app/src/main/res/layout/dialog_hybridhr_watchface_widget.xml
@@ -7,7 +7,7 @@
     <TextView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Type:" />
+        android:text="@string/watchface_dialog_widget_type" />
 
     <Spinner
         android:id="@+id/watchface_widget_type_spinner"
@@ -17,7 +17,7 @@
     <TextView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="X coordinate (max 240):" />
+        android:text="@string/watchface_dialog_widget_x_coordinate" />
 
     <EditText
         android:id="@+id/watchface_widget_pos_x"
@@ -28,7 +28,7 @@
     <TextView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Y coordinate (max 240):" />
+        android:text="@string/watchface_dialog_widget_y_coordinate" />
 
     <EditText
         android:id="@+id/watchface_widget_pos_y"
@@ -39,7 +39,7 @@
     <TextView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Position presets:" />
+        android:text="@string/watchface_dialog_widget_presets" />
 
     <LinearLayout
         android:layout_width="match_parent"
@@ -48,22 +48,22 @@
             android:id="@+id/watchface_widget_preset_top"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="Top"/>
+            android:text="@string/watchface_dialog_widget_preset_top"/>
         <Button
             android:id="@+id/watchface_widget_preset_bottom"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="Bottom"/>
+            android:text="@string/watchface_dialog_widget_preset_bottom"/>
         <Button
             android:id="@+id/watchface_widget_preset_left"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="Left"/>
+            android:text="@string/watchface_dialog_widget_preset_left"/>
         <Button
             android:id="@+id/watchface_widget_preset_right"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="Right"/>
+            android:text="@string/watchface_dialog_widget_preset_right"/>
     </LinearLayout>
 
 </LinearLayout>
\ No newline at end of file
diff --git a/app/src/main/res/menu/activity_hybridhr_watchface_designer_actionbar.xml b/app/src/main/res/menu/activity_hybridhr_watchface_designer_actionbar.xml
index 0fede6d35..fac80ec6b 100644
--- a/app/src/main/res/menu/activity_hybridhr_watchface_designer_actionbar.xml
+++ b/app/src/main/res/menu/activity_hybridhr_watchface_designer_actionbar.xml
@@ -2,13 +2,13 @@
     xmlns:app="http://schemas.android.com/apk/res-auto">
     <item
         android:id="@+id/button_preview_watchface"
-        android:title="Preview on watch"
+        android:title="@string/button_watchface_preview"
         app:showAsAction="always"
         android:icon="@drawable/ic_watch_bw"
         />
     <item
         android:id="@+id/button_save_watchface"
-        android:title="Save and apply"
+        android:title="@string/button_watchface_save_apply"
         app:showAsAction="always"
         android:icon="@drawable/ic_done"
         />
diff --git a/app/src/main/res/menu/appmanager_context.xml b/app/src/main/res/menu/appmanager_context.xml
index aa0055e9a..ba828c320 100644
--- a/app/src/main/res/menu/appmanager_context.xml
+++ b/app/src/main/res/menu/appmanager_context.xml
@@ -2,7 +2,7 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android" >
     <item
         android:id="@+id/appmanager_app_edit"
-        android:title="Edit"/>
+        android:title="@string/appmanager_app_edit"/>
     <item
         android:id="@+id/appmanager_app_reinstall"
         android:title="@string/appmananger_app_reinstall"/>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 4ef88850e..b7d68c04f 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1215,4 +1215,16 @@
     <string name="watchface_widget_type_weather">Weather</string>
     <string name="watchface_widget_type_steps">Steps</string>
     <string name="watchface_widget_type_heart_rate">Heart rate</string>
+    <string name="button_watchface_preview">Preview on watch</string>
+    <string name="button_watchface_save_apply">Save and apply</string>
+    <string name="appmanager_app_edit">Edit</string>
+    <string name="watchface_dialog_widget_type">Type:</string>
+    <string name="watchface_dialog_widget_x_coordinate">X coordinate (max 240):</string>
+    <string name="watchface_dialog_widget_y_coordinate">Y coordinate (max 240):</string>
+    <string name="watchface_dialog_widget_presets">Position presets:</string>
+    <string name="watchface_dialog_widget_preset_top">Top</string>
+    <string name="watchface_dialog_widget_preset_bottom">Bottom</string>
+    <string name="watchface_dialog_widget_preset_left">Left</string>
+    <string name="watchface_dialog_widget_preset_right">Right</string>
+    <string name="qhybrid_title_watchface_designer">Watchface designer</string>
 </resources>
\ No newline at end of file