From 18afddac2933113d646312091b3beec1dd4c46fa Mon Sep 17 00:00:00 2001 From: TaaviE Date: Mon, 27 Jul 2020 18:52:23 +0300 Subject: [PATCH] Made the version string generation use a specific locale for generation, trying to avoid potential localization issues --- .../devices/miband/AbstractMiBandFWHelper.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/miband/AbstractMiBandFWHelper.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/miband/AbstractMiBandFWHelper.java index 105c31262..7f0837a79 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/miband/AbstractMiBandFWHelper.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/miband/AbstractMiBandFWHelper.java @@ -20,14 +20,16 @@ package nodomain.freeyourgadget.gadgetbridge.devices.miband; import android.content.Context; import android.net.Uri; +import androidx.annotation.NonNull; + import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.io.BufferedInputStream; import java.io.IOException; import java.io.InputStream; +import java.util.Locale; -import androidx.annotation.NonNull; import nodomain.freeyourgadget.gadgetbridge.GBApplication; import nodomain.freeyourgadget.gadgetbridge.R; import nodomain.freeyourgadget.gadgetbridge.impl.GBDevice; @@ -74,10 +76,12 @@ public abstract class AbstractMiBandFWHelper { public abstract int getFirmware2Version(); public static String formatFirmwareVersion(int version) { - if (version == -1) + if (version == -1) { return GBApplication.getContext().getString(R.string._unknown_); + } - return String.format("%d.%d.%d.%d", + return String.format(Locale.UK, + "%d.%d.%d.%d", version >> 24 & 255, version >> 16 & 255, version >> 8 & 255,