From 3a3038711f2adaf1c708e61064994441ac98edf7 Mon Sep 17 00:00:00 2001
From: thrillfall <thrillfall@users.noreply.github.com>
Date: Wed, 25 Aug 2021 20:25:08 +0200
Subject: [PATCH] make retrievel episode actions without guid more explanatory

---
 lib/Core/EpisodeAction/EpisodeActionSaver.php | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/lib/Core/EpisodeAction/EpisodeActionSaver.php b/lib/Core/EpisodeAction/EpisodeActionSaver.php
index a263cf6..a67f2d8 100644
--- a/lib/Core/EpisodeAction/EpisodeActionSaver.php
+++ b/lib/Core/EpisodeAction/EpisodeActionSaver.php
@@ -84,17 +84,30 @@ class EpisodeActionSaver
 		);
 
 		if ($episodeActionEntityToUpdate === null && $episodeActionEntity->getGuid() !== null) {
-			$episodeActionEntityToUpdate = $this->episodeActionRepository->findByEpisodeIdentifier(
-				$episodeActionEntity->getEpisode(),
-				$userId
+			$episodeActionEntityToUpdate = $this->getOldEpisodeActionByEpisodeUrl(
+				$episodeActionEntity->getEpisode(), $userId
 			);
 		}
-		$idEpisodeActionEntityToUpdate = $episodeActionEntityToUpdate->getId();
-		$episodeActionEntity->setId($idEpisodeActionEntityToUpdate);
+
+		$episodeActionEntity->setId($episodeActionEntityToUpdate->getId());
 
 		return $this->episodeActionWriter->update($episodeActionEntity);
 	}
 
+	/**
+	 * @param string $episodeUrl
+	 * @param string $userId
+	 *
+	 * @return EpisodeActionEntity|null
+	 */
+	private function getOldEpisodeActionByEpisodeUrl(string $episodeUrl, string $userId): ?EpisodeActionEntity
+	{
+		return $this->episodeActionRepository->findByEpisodeIdentifier(
+			$episodeUrl,
+			$userId
+		);
+	}
+
 	/**
 	 * @param EpisodeAction $episodeAction
 	 * @param string $userId