From 2b82e9e9c928e5fef02c9d60a47027262774f70c Mon Sep 17 00:00:00 2001
From: Kalle Fagerberg <kalle.f8@proton.me>
Date: Sat, 17 Sep 2022 17:03:49 +0200
Subject: [PATCH] Added PodcastData parsing/toArray tests

---
 lib/Core/PodcastData/PodcastData.php          |   6 +-
 .../Unit/Core/PodcastData/PodcastDataTest.php | 111 ++++++++++++++++++
 2 files changed, 114 insertions(+), 3 deletions(-)
 create mode 100644 tests/Unit/Core/PodcastData/PodcastDataTest.php

diff --git a/lib/Core/PodcastData/PodcastData.php b/lib/Core/PodcastData/PodcastData.php
index 1357819..8b7ee10 100644
--- a/lib/Core/PodcastData/PodcastData.php
+++ b/lib/Core/PodcastData/PodcastData.php
@@ -35,12 +35,12 @@ class PodcastData {
 		$channel = $xml->channel;
 		return new PodcastData(
 			title: (string)$channel->title,
-			author: self::getXPathContent($xml, '/rss/channel/itunes:author'),
+			author: (string)self::getXPathContent($xml, '/rss/channel/itunes:author'),
 			link: (string)$channel->link,
 			description: (string)$channel->description,
 			image:
-				self::getXPathContent($xml, '/rss/channel/image/url')
-				?? self::getXPathAttribute($xml, '/rss/channel/itunes:image/@href'),
+				(string)(self::getXPathContent($xml, '/rss/channel/image/url')
+				?? self::getXPathAttribute($xml, '/rss/channel/itunes:image/@href')),
 			fetchedAtUnix: $fetchedAtUnix ?? (new DateTime())->getTimestamp(),
 		);
 	}
diff --git a/tests/Unit/Core/PodcastData/PodcastDataTest.php b/tests/Unit/Core/PodcastData/PodcastDataTest.php
new file mode 100644
index 0000000..b7b2e18
--- /dev/null
+++ b/tests/Unit/Core/PodcastData/PodcastDataTest.php
@@ -0,0 +1,111 @@
+<?php
+declare(strict_types=1);
+
+namespace OCA\GPodderSync\Tests\Unit\Core\PodcastData;
+
+use OCA\GPodderSync\Core\PodcastData\PodcastData;
+use Test\TestCase;
+
+class EpisodeActionTest extends TestCase {
+	public function testToArray(): void {
+		$podcastData = new PodcastData('title1', 'author1', 'http://example.com/', 'description1', 'http://example.com/image.jpg', 1337);
+		$expected = [
+			'title' => 'title1',
+			'author' => 'author1',
+			'link' => 'http://example.com/',
+			'description' => 'description1',
+			'image' => 'http://example.com/image.jpg',
+			'fetchedAtUnix' => 1337,
+		];
+		$this->assertSame($expected, $podcastData->toArray());
+	}
+
+	public function testFromArray(): void {
+		$podcastData = new PodcastData('title1', 'author1', 'http://example.com/', 'description1', 'http://example.com/image.jpg', 1337);
+		$expected = $podcastData->toArray();
+		$fromArray = PodcastData::fromArray($expected);
+		$this->assertSame($expected, $fromArray->toArray());
+	}
+
+	public function testParseRssXml(): void {
+		$xml = '<?xml version="1.0" encoding="UTF-8"?>
+		<rss version="2.0"
+		  xmlns:atom="http://www.w3.org/2005/Atom"
+		  xmlns:content="http://purl.org/rss/1.0/modules/content/"
+		  xmlns:dc="http://purl.org/dc/elements/1.1/"
+		  xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd"
+		  xmlns:podcast="https://podcastindex.org/namespace/1.0"
+		>
+			<channel>
+				<title>The title of this Podcast</title>
+				<copyright>All rights reserved</copyright>
+				<link>http://example.com</link>
+				<atom:link href="https://example.com/feed" rel="self" type="application/rss+xml" />
+				<atom:link href="https://example.com" rel="alternate" type="text/html" />
+				<language>en-us</language>
+				<description>Some long description</description>
+				<itunes:author>The Podcast Author</itunes:author>
+				<itunes:summary>Some long description</itunes:summary>
+				<itunes:explicit>no</itunes:explicit>
+				<itunes:image href="https://example.com/image.jpg"/>
+				<itunes:keywords>nextcloud, gpodder</itunes:keywords>
+				<itunes:owner>
+					<itunes:name>Owner of the podcast</itunes:name>
+					<itunes:email>editors@example.com</itunes:email>
+				</itunes:owner>
+				<itunes:category text="Technology">
+					<itunes:category text="Podcast Tools"/>
+				</itunes:category>
+				<podcast:funding url="https://example.com/funding">Support our work</podcast:funding>
+				<podcast:person role="host" img="https://avatars.githubusercontent.com/u/15801468?s=80&amp;v=4" href="https://github.com/thrillfall">thrillfall</podcast:person>
+				<podcast:person role="host" img="https://avatars.githubusercontent.com/u/2477952?s=80&amp;v=4" href="https://github.com/jilleJr">jilleJr</podcast:person>
+			</channel>
+		</rss>
+		';
+
+		$podcastData = PodcastData::parseRssXml($xml, fetchedAtUnix: 1337);
+		$expected = [
+			'title' => 'The title of this Podcast',
+			'author' => 'The Podcast Author',
+			'link' => 'http://example.com',
+			'description' => 'Some long description',
+			'image' => 'https://example.com/image.jpg',
+			'fetchedAtUnix' => 1337,
+		];
+		$this->assertSame($expected, $podcastData->toArray());
+	}
+
+	public function testParseRssXmlPartial(): void {
+		$xml = '<?xml version="1.0" encoding="UTF-8"?>
+		<rss version="2.0"
+		  xmlns:atom="http://www.w3.org/2005/Atom"
+		  xmlns:content="http://purl.org/rss/1.0/modules/content/"
+		  xmlns:dc="http://purl.org/dc/elements/1.1/"
+		  xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd"
+		  xmlns:podcast="https://podcastindex.org/namespace/1.0"
+		>
+			<channel>
+				<title>The title of this Podcast</title>
+				<copyright>All rights reserved</copyright>
+				<link>http://example.com</link>
+				<itunes:author>The Podcast Author</itunes:author>
+				<image>
+					<alt>Some image</alt>
+					<!-- intentionally skipping <url> -->
+				</image>
+			</channel>
+		</rss>
+		';
+
+		$podcastData = PodcastData::parseRssXml($xml, fetchedAtUnix: 1337);
+		$expected = [
+			'title' => 'The title of this Podcast',
+			'author' => 'The Podcast Author',
+			'link' => 'http://example.com',
+			'description' => '',
+			'image' => '',
+			'fetchedAtUnix' => 1337,
+		];
+		$this->assertSame($expected, $podcastData->toArray());
+	}
+}