From 0d6492e99d98ce3ad635931fdb63f0e3e4647f39 Mon Sep 17 00:00:00 2001 From: Jonathan Flueren Date: Mon, 23 May 2022 22:17:05 +0200 Subject: [PATCH] Set default since timestamp to 0 --- lib/Controller/EpisodeActionController.php | 2 +- lib/Controller/SubscriptionChangeController.php | 14 ++------------ 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/lib/Controller/EpisodeActionController.php b/lib/Controller/EpisodeActionController.php index f0cef9a..cdefe1f 100644 --- a/lib/Controller/EpisodeActionController.php +++ b/lib/Controller/EpisodeActionController.php @@ -53,7 +53,7 @@ class EpisodeActionController extends Controller { * @param int $since * @return JSONResponse */ - public function list(int $since): JSONResponse { + public function list(int $since = 0): JSONResponse { $episodeActions = $this->episodeActionRepository->findAll($since, $this->userId); $untypedEpisodeActionData = []; diff --git a/lib/Controller/SubscriptionChangeController.php b/lib/Controller/SubscriptionChangeController.php index d7c1cbd..9059aa0 100644 --- a/lib/Controller/SubscriptionChangeController.php +++ b/lib/Controller/SubscriptionChangeController.php @@ -54,8 +54,8 @@ class SubscriptionChangeController extends Controller { * @param int|null $since * @return JSONResponse */ - public function list(int $since = null): JSONResponse { - $sinceDatetime = $this->createDateTimeFromTimestamp($since); + public function list(int $since = 0): JSONResponse { + $sinceDatetime = (new DateTime)->setTimestamp($since); return new JSONResponse([ "add" => $this->extractUrlList($this->subscriptionChangeRepository->findAllSubscribed($sinceDatetime, $this->userId)), "remove" => $this->extractUrlList($this->subscriptionChangeRepository->findAllUnSubscribed($sinceDatetime, $this->userId)), @@ -63,16 +63,6 @@ class SubscriptionChangeController extends Controller { ]); } - /** - * @param int|null $since - * @return DateTime - */ - private function createDateTimeFromTimestamp(?int $since): DateTime { - return ($since !== null) - ? (new DateTime)->setTimestamp($since) - : (new DateTime('-1 week')); - } - /** * @param array $allSubscribed * @return mixed