From ef64dfb8aa93c23efdd2d4c2d175aed8db8785bc Mon Sep 17 00:00:00 2001 From: Joshua Goins Date: Wed, 29 Jan 2025 16:57:06 -0500 Subject: [PATCH] Don't allow opening an invalid fullscreen episode image This MouseArea is still enabled even if no entry is playing, which results in a fun bug where you can tap the image and nothing ever shows up. If we're not playing anything, disable the MouseArea. Also disable the pointing hand cursor in this case, too. --- src/qml/Desktop/DesktopPlayerControls.qml | 3 ++- src/qml/Desktop/HeaderBar.qml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qml/Desktop/DesktopPlayerControls.qml b/src/qml/Desktop/DesktopPlayerControls.qml index 0d33bac9..22a76031 100644 --- a/src/qml/Desktop/DesktopPlayerControls.qml +++ b/src/qml/Desktop/DesktopPlayerControls.qml @@ -100,7 +100,8 @@ FocusScope { visible: headerBar.handlePosition === 0 MouseArea { anchors.fill: parent - cursorShape: Qt.PointingHandCursor + cursorShape: AudioManager.entry ? Qt.PointingHandCursor : Qt.ArrowCursor + enabled: AudioManager.entry onClicked: { headerBar.openFullScreenImage(); } diff --git a/src/qml/Desktop/HeaderBar.qml b/src/qml/Desktop/HeaderBar.qml index 5a66f08d..bac6ff28 100644 --- a/src/qml/Desktop/HeaderBar.qml +++ b/src/qml/Desktop/HeaderBar.qml @@ -143,7 +143,8 @@ FocusScope { MouseArea { anchors.fill: parent - cursorShape: Qt.PointingHandCursor + cursorShape: AudioManager.entry ? Qt.PointingHandCursor : Qt.ArrowCursor + enabled: AudioManager.entry onClicked: { openFullScreenImage(); }