Apply 17 suggestion(s) to 7 file(s)

src/qml/EntryPage.qml

@@ -26,7 +26,7 @@ Kirigami.ScrollablePage {
     Connections {
         target: entry
         function onQueueStatusChanged() {
-            if (entry.queueStatus === false) {
+            if (!entry.queueStatus) {
                 // this entry has just been removed from the queue
                 if (pageStack.depth > 1) {
                     if (pageStack.get(0).lastEntry) {
@@ -52,6 +52,7 @@ Kirigami.ScrollablePage {
         Controls.Label {
             Layout.margins: Kirigami.Units.gridUnit
             id: text
+            Layout.margins: Kirigami.Units.gridUnit
             text: page.entry.content
             baseUrl: page.entry.baseUrl
             textFormat: Text.RichText
@@ -123,21 +124,13 @@ Kirigami.ScrollablePage {
         Kirigami.Action {
             text: entry.read ? i18n("Unmark as Played") : i18n("Mark as Played")
             onTriggered: {
-                if(entry.read) {
+                entry.read = !entry.read
-                    entry.read = false
-                } else {
-                    entry.read = true
-                }
             }
         },
         Kirigami.Action {
             text: entry.new ? i18n("Unmark as New") : i18n("Mark as New")
             onTriggered: {
-                if(entry.new) {
+                entry.new = !entry.new
-                    entry.new = false
-                } else {
-                    entry.new = true
-                }
             }
         }
     ]

src/qml/ErrorListPage.qml

@@ -72,6 +72,7 @@ Kirigami.ScrollablePage {
     ListView {
         anchors.fill: parent
         id: errorList
+        anchors.fill: parent
         visible: count !== 0
         model: ErrorLogModel
 
@@ -83,7 +84,7 @@ Kirigami.ScrollablePage {
     actions.main: Kirigami.Action {
         text: i18n("Clear all errors")
         iconName: "edit-clear-all"
-        visible: !(errorList.count === 0)
+        visible: errorList.count > 0
         onTriggered: ErrorLogModel.clearAll()
     }
 }

src/qml/FooterBar.qml

@@ -18,7 +18,7 @@ Flickable {
 
     property bool portrait: (contentZone.height / contentZone.width) > 0.7
 
-    property bool isMaximized: contentY == contentHeight / 2
+    property bool isMaximized: contentY === contentHeight / 2
 
     boundsBehavior: Flickable.StopAtBounds
 

src/qml/GenericEntryDelegate.qml

@@ -4,7 +4,6 @@
    SPDX-License-Identifier: GPL-2.0-or-later
 */
 
-// Includes relevant modules used by the QML
 import QtQuick 2.14
 import QtQuick.Controls 2.14 as Controls
 import QtQuick.Layouts 1.14
@@ -13,7 +12,6 @@ import QtMultimedia 5.15
 import QtGraphicalEffects 1.15
 import org.kde.alligator 1.0
 
-
 Kirigami.SwipeListItem {
     id: listItem
     alwaysVisibleActions: true