improve query definition

This commit is contained in:
Tobias Fella 2020-02-29 00:55:16 +01:00
parent fbd8057f14
commit 0c780eb199
No known key found for this signature in database
GPG Key ID: E55EDAB3CA5D9925
4 changed files with 6 additions and 6 deletions

View File

@ -69,7 +69,7 @@ void EntryListModel::fetch()
{
connect(&Fetcher::instance(), &Fetcher::finished, this, [this]() {
beginResetModel();
QSqlQuery query = QSqlQuery(QSqlDatabase::database());
QSqlQuery query(QSqlDatabase::database());
query.prepare(QStringLiteral("SELECT id, title, content FROM Entries WHERE feed=:feed;"));
query.bindValue(QStringLiteral(":feed"), m_feed);
query.exec();

View File

@ -30,7 +30,7 @@
FeedListModel::FeedListModel(QObject *parent)
: QAbstractListModel(parent)
{
QSqlQuery query = QSqlQuery(QSqlDatabase::database());
QSqlQuery query(QSqlDatabase::database());
query.exec(QStringLiteral("SELECT name, url FROM Feeds"));
beginInsertRows(QModelIndex(), 0, query.size());
while (query.next()) {
@ -66,7 +66,7 @@ void FeedListModel::add_feed(QString url)
beginInsertRows(QModelIndex(), feeds.size(), feeds.size());
feeds.append(Feed(url));
endInsertRows();
QSqlQuery query = QSqlQuery(QSqlDatabase::database());
QSqlQuery query(QSqlDatabase::database());
query.prepare(QStringLiteral("INSERT INTO Feeds VALUES (:url, :name);"));
query.bindValue(QStringLiteral(":url"), url);
query.bindValue(QStringLiteral(":name"), url);
@ -76,7 +76,7 @@ void FeedListModel::add_feed(QString url)
void FeedListModel::remove_feed(int index)
{
Feed toRemove = feeds[index];
QSqlQuery query = QSqlQuery(QSqlDatabase::database());
QSqlQuery query(QSqlDatabase::database());
query.prepare(QStringLiteral("DELETE FROM Feeds WHERE name=:name AND url=url;"));
query.bindValue(QStringLiteral(":url"), toRemove.url());
query.bindValue(QStringLiteral(":name"), toRemove.name());

View File

@ -44,7 +44,7 @@ void Fetcher::fetch(QUrl url)
Syndication::FeedPtr feed = Syndication::parserCollection()->parse(*document, QStringLiteral("Atom"));
QSqlDatabase db = QSqlDatabase::database();
QSqlQuery query = QSqlQuery(db);
QSqlQuery query(db);
for (const auto &entry : feed->items()) {
query = QSqlQuery(db);

View File

@ -50,7 +50,7 @@ int main(int argc, char *argv[])
db.setDatabaseName(databasePath + "/database.db3");
db.open();
QSqlQuery query = QSqlQuery(db);
QSqlQuery query(db);
query.exec(QStringLiteral("CREATE TABLE IF NOT EXISTS Feeds (name TEXT, url TEXT);"));
query.exec(QStringLiteral("CREATE TABLE IF NOT EXISTS Entries (feed TEXT, id TEXT UNIQUE, title TEXT, content TEXT);"));
query.exec(QStringLiteral("CREATE TABLE IF NOT EXISTS Authors (id TEXT, name TEXT, uri TEXT, email TEXT);"));