4.5.3 commit

This commit is contained in:
Xilin Jia 2024-04-03 19:45:47 +00:00
parent 40ec9deb06
commit 3094eb1103
9 changed files with 26 additions and 14 deletions

View File

@ -149,8 +149,8 @@ android {
// Version code schema (not used):
// "1.2.3-beta4" -> 1020304
// "1.2.3" -> 1020395
versionCode 3020122
versionName "4.5.2"
versionCode 3020123
versionName "4.5.3"
def commit = ""
try {

View File

@ -179,7 +179,7 @@ open class SubscriptionsAdapter(mainActivity: MainActivity) :
producer.text = drawerItem.producer
coverImage.contentDescription = drawerItem.title
if (drawerItem.counter > 0) {
if (drawerItem.counter >= 0) {
// TODO: need to use more specific number
count.text = NumberFormat.getInstance().format(drawerItem.counter.toLong()) + " episodes"
// count.text = NumberFormat.getInstance().format(drawerItem.feed.items.size.toLong()) + " episodes"

View File

@ -25,14 +25,14 @@ import java.lang.ref.WeakReference
binding.editText.text = Editable.Factory.getInstance().newEditable(fallbackSpeed.toString())
MaterialAlertDialogBuilder(activity)
.setView(binding.root)
.setTitle(R.string.edit_fast_forward_speed)
.setTitle(R.string.edit_fallback_speed)
.setPositiveButton(android.R.string.ok) { _: DialogInterface?, _: Int ->
var speed = binding.editText.text.toString().toFloatOrNull() ?: 0.0f
when {
speed < 0.0f -> speed = 0.0f
speed > 1.5f -> speed = 1.5f
speed > 3.0f -> speed = 3.0f
}
fallbackSpeed = String.format("%.1f", speed).toFloat()
fallbackSpeed = String.format("%.2f", speed).toFloat()
}
.setNegativeButton(R.string.cancel_label, null)
.show()

View File

@ -10,7 +10,7 @@
<androidx.fragment.app.FragmentContainerView
android:id="@+id/playerFragment1"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="@dimen/external_player_height"
android:layout_gravity="top"
android:elevation="8dp"
android:outlineProvider="none"
@ -78,7 +78,7 @@
<androidx.fragment.app.FragmentContainerView
android:id="@+id/playerFragment2"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="@dimen/external_player_height"
android:layout_gravity="bottom"
android:layout_alignParentBottom="true"
tools:layout_height="@dimen/external_player_height" />

View File

@ -64,13 +64,12 @@
<LinearLayout
android:layout_width="match_parent"
android:layout_height="0dp"
android:layout_weight="1"
android:layout_height="75dp"
android:orientation="horizontal">
<ImageView
android:id="@+id/imgvCover"
android:layout_width="70dp"
android:layout_width="75dp"
android:layout_height="match_parent"
android:cropToPadding="true"
android:scaleType="fitCenter"
@ -89,6 +88,7 @@
android:layout_height="@dimen/audioplayer_playercontrols_length_big"
android:layout_centerHorizontal="true"
android:layout_centerVertical="false"
android:layout_alignParentTop="true"
android:layout_marginStart="@dimen/audioplayer_playercontrols_margin"
android:layout_marginLeft="@dimen/audioplayer_playercontrols_margin"
android:layout_marginEnd="@dimen/audioplayer_playercontrols_margin"
@ -106,6 +106,7 @@
android:layout_width="@dimen/audioplayer_playercontrols_length"
android:layout_height="@dimen/audioplayer_playercontrols_length"
android:layout_centerVertical="false"
android:layout_alignParentTop="true"
android:layout_marginStart="@dimen/audioplayer_playercontrols_margin"
android:layout_marginLeft="@dimen/audioplayer_playercontrols_margin"
android:layout_toStartOf="@id/butPlay"
@ -138,6 +139,7 @@
android:layout_width="@dimen/audioplayer_playercontrols_length"
android:layout_height="@dimen/audioplayer_playercontrols_length"
android:layout_centerVertical="false"
android:layout_alignParentTop="true"
android:layout_marginEnd="@dimen/audioplayer_playercontrols_margin"
android:layout_marginRight="@dimen/audioplayer_playercontrols_margin"
android:layout_toStartOf="@id/butRev"
@ -168,6 +170,7 @@
android:layout_width="@dimen/audioplayer_playercontrols_length"
android:layout_height="@dimen/audioplayer_playercontrols_length"
android:layout_centerVertical="false"
android:layout_alignParentTop="true"
android:layout_marginEnd="@dimen/audioplayer_playercontrols_margin"
android:layout_marginRight="@dimen/audioplayer_playercontrols_margin"
android:layout_toEndOf="@id/butPlay"
@ -200,6 +203,7 @@
android:layout_width="@dimen/audioplayer_playercontrols_length"
android:layout_height="@dimen/audioplayer_playercontrols_length"
android:layout_centerVertical="false"
android:layout_alignParentTop="true"
android:layout_marginStart="@dimen/audioplayer_playercontrols_margin"
android:layout_marginLeft="@dimen/audioplayer_playercontrols_margin"
android:layout_toEndOf="@id/butFF"

View File

@ -63,7 +63,7 @@
android:layout_height="wrap_content"
android:textColor="?android:attr/textColorSecondary"
android:lines="1"
android:text="number episodes" />
android:text="0 episodes" />
</LinearLayout>
<ImageView

View File

@ -5,7 +5,7 @@
<dimen name="drawer_corner_size">16dp</dimen>
<dimen name="widget_margin">0dp</dimen>
<dimen name="widget_inner_radius">4dp</dimen>
<dimen name="external_player_height">125dp</dimen>
<dimen name="external_player_height">130dp</dimen>
<dimen name="text_size_micro">12sp</dimen>
<dimen name="text_size_small">14sp</dimen>
<dimen name="text_size_navdrawer">16sp</dimen>

View File

@ -733,6 +733,7 @@
<string name="edit_url_menu">Edit feed URL</string>
<string name="edit_url_confirmation_msg">Changing the RSS address can easily break the playback state and episode listings of the podcast. We do NOT recommend changing it and will NOT provide support if anything goes wrong. This cannot be undone. The broken subscription CANNOT be repaired by simply changing the address back. We suggest creating a backup before continuing.</string>
<string name="edit_fast_forward_speed">Edit fast forward speed</string>
<string name="edit_fallback_speed">Edit fallback speed</string>
<!-- PodciniSP -->
<string name="sp_apps_importing_feeds_msg">Importing subscriptions from single-purpose apps&#8230;</string>

View File

@ -208,4 +208,11 @@
* revamped audio player class, merged external player in
* speed setting now allows setting with three options: current audio, podcast, and global.
* added a bit bottom margin for the numbers in player
* added a bit bottom margin for the numbers in player
## 4.5.3
* corrected wrong caption of "Edit fallback speed"
* adjusted layout and button dimension and alignments in the bottom player control
* fallback speed setting is now capped at 0.0 and 3.0 and allows for 2-digit precision
* corrected episode count display in subscriptions list when the feed has 0 episodes