d8a010ad48
Merge pull request #3100 from orionlee/bugfix_bulk_action_ui_survive_split_screen_3088
...
bugfix - bulk actions - make UI survive upon split screen
2019-04-08 18:54:01 +02:00
f5956bcd56
Merge pull request #3101 from orionlee/bugfix_add_podcast_by_url_case_no_feed_in_html_3099
...
bugfix - add podcast by URL - show error dialog when URL points to no feed
2019-04-08 18:53:32 +02:00
345e6863c3
bugfix #3099 - add podcast by URL - show error dialog when URL points to no feed.
2019-04-07 14:56:15 -07:00
1928411694
bugfix #3088 - bulk edit - make UI survive upon split screen
2019-04-07 14:27:29 -07:00
156a20734a
Fix Sonic playback
2019-04-07 12:54:12 +02:00
2c9cb25eda
Merge branch 'develop' into exoplayer-main-thread
2019-04-07 11:52:24 +02:00
3fdf6af1a3
Merge pull request #2974 from orionlee/bugfix_rxjava2_null_returns_2966
...
Fix rxjava2 null returns
2019-04-07 11:35:13 +02:00
ebe32e795a
Executing all ExoPlayer methods on main thread
2019-04-07 00:19:02 +02:00
e16f44ad5d
bugfix - rxjava2 null return - wrap nullable return with Optional
2019-04-06 14:22:53 -07:00
20f1445c06
fix rebase conflicts - remove the incorrect @NonNull from rxjava
2019-04-06 14:19:16 -07:00
c04f340ae2
#2966 RxJava2 null - case underlying method has needs to return null.
...
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.
Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
2019-04-06 13:43:12 -07:00
1655d234af
#2966 RxJava2 null - case the underlying method may return null, but
...
should never happen in the code path, e.g.,
return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
onError() to handle null case
Rx observer : underlying sources marked as @Nullable
ItemFragment.load : .loadInBackground
MediaplayerActivity.checkFavorite : DBReader.getFeedItem
ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
ItemlistFragment.loadItems : .loadData
2019-04-06 13:43:11 -07:00
0472bb9237
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
2019-04-06 13:43:11 -07:00
670fc124eb
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
2019-04-06 13:43:11 -07:00
5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145
...
Bulk remove from queue
2019-04-06 21:45:55 +02:00
31194e02a5
Merge pull request #3093 from AntennaPod/bugfix/3084-queue-undo-single
...
Create new adapter to show single item after undo
2019-04-06 21:32:36 +02:00
74fdabba69
Show single item after undo in EpisodesFragment
2019-04-06 21:32:03 +02:00
cb14fd930f
refactor - rename string resource name `remove_episode_lable` , which was ambiguous with typos, to `delete_episode_label`
...
- non-default string resources to be handled by Transifex
2019-04-06 11:27:20 -07:00
075547947e
tweak - batch edit UI - support longer action label
2019-04-06 11:15:35 -07:00
3bf880e34a
remove comment to reduce mental work per review feedback
2019-04-06 11:15:35 -07:00
86bf3ef3e0
remove outdated comment - support for vector drawables for pre Android 5 devices is here to stay.
2019-04-06 11:15:34 -07:00
0204c1cebd
tweak - bulk edit UI - remove hiding FAB during scroll per review feedback
2019-04-06 11:15:34 -07:00
3311b4371e
tweak - bulk edit UI - use Snackbar for selection message
...
- to be consistent with the action message in previous commit.
2019-04-06 11:15:34 -07:00
cc43af110a
tweak - bulk edit UI - show a message after an action is applied.
2019-04-06 11:15:14 -07:00
46f7805a96
refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without custom codes.
2019-04-06 11:12:34 -07:00
6c3033409d
Create new adapter to show single item after undo
2019-04-06 16:28:07 +02:00
b3fbf0b4aa
refactor - UI - remove the old (and now used) select all / none /intermediate icons
2019-04-04 14:05:51 -07:00
836334798d
refactor - UI - make OPML import screen use the new select all / none icons as well (so that only single set of icons are needed)
2019-04-04 13:58:50 -07:00
d186309066
bulk edit - UI - new select all / none icons, based on
...
standard Material icons.
2019-04-04 13:50:55 -07:00
dfe2241b4c
bulk remove episodes from queue - UI - icon for dark themes.
2019-04-04 13:12:09 -07:00
4797d3ae56
Merge pull request #3086 from ByteHamster/fix-double-slash-url
...
Specifying base url
2019-04-04 19:06:34 +02:00
643173de14
Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716
...
Fix phantom service notification
2019-04-04 11:59:30 +02:00
f2d103736d
Merge pull request #3085 from ByteHamster/new-items-count
...
Respect 'keep updated' for new items counter
2019-04-04 01:16:26 +02:00
b683d33bcb
bulk edit - refactor - reorder method parameter for DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API.
2019-04-03 14:21:35 -07:00
bcaba92851
bulk edit - refactor - factorize common codes in binding action to its UI and actual logic.
2019-04-03 14:15:05 -07:00
1052b393d2
bulk edit - refactor - rename menu ids, to be consistent with single edit counterparts
2019-04-03 13:40:55 -07:00
a1d718a59a
bulk edit - refactor - rename internal constant flags so that the names are consistent
2019-04-03 13:31:32 -07:00
4322e8646f
bulk edit - UI tweak - rename "Remove Episode" to "Delete Episode", to be consistent with other UIs
2019-04-03 13:27:31 -07:00
ce013bb225
Specifying base url
...
Fixes <a href="//example.com"> links
2019-04-03 18:53:11 +02:00
46510c808a
Respect 'keep updated' for new items counter
2019-04-03 18:11:55 +02:00
7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates
...
Mobile updates: Allow images
2019-04-03 17:43:53 +02:00
b6e50c61d6
Merge pull request #3060 from jatinkumarg/issue-3052
...
Added empty views to the PlayBack History, Queue,and Downloads
2019-04-03 17:42:09 +02:00
788e75515a
Review changes
2019-04-03 17:29:44 +02:00
48cf33d7da
bulk edit - no longer defaulted to check all
2019-04-02 17:34:48 -07:00
3768dfb0ff
bulk edit - "N selected" UI logic
2019-04-02 17:34:05 -07:00
b8bb908b67
fix typo in comments
2019-04-02 16:56:22 -07:00
364c9a308d
bulk remove from queue - backend - implement the new API
2019-04-02 15:59:27 -07:00
70287a740e
bulk remove from queue - backend - refactor existing logic to support bulk remove
2019-04-02 14:59:12 -07:00
f6370cc2b9
Renamed text view ids and added tools namespace
2019-04-02 17:36:27 -04:00
7d78b88a1c
bulk remove from queue - frontend logic, with a stub backend.
2019-04-02 14:11:22 -07:00
Martin Fietz
orionlee
ByteHamster
H. Lehmann
Jatin Kumar