bhlee
f1d5c00f3b
Resolves #3235 . Refer to the changes.
...
- Remove android:screenOrientation="portrait" for rotating.
- Remove override onConfigurationChanged function that does nothing.
2019-07-13 20:14:16 +09:00
H. Lehmann
c8fc1f90e0
Merge pull request #3265 from ByteHamster/storage-label
...
Added total space to storage select dialog
2019-07-12 22:51:11 +02:00
ByteHamster
b5b2bccda4
Added total space to storage select dialog
2019-07-12 18:59:43 +02:00
ByteHamster
eda23ca4bb
Updated SearchPreference
2019-07-12 14:35:38 +02:00
H. Lehmann
9f6529d4bc
Merge branch 'develop' into 2747-completed-downloads-update
2019-07-11 12:43:30 +02:00
H. Lehmann
e78e4d5656
Merge pull request #3261 from archibishop/fix-removing-wrong-favourite-message
...
Fix removing wrong favourite message
2019-07-11 12:42:14 +02:00
Wagubi Brian
782fce76d0
Fix removing wrong favoruite message
2019-07-10 12:29:48 +03:00
H. Lehmann
9e72780bc8
Merge pull request #3254 from jas14/feed-rotation-crash-3245
...
New ViewModel for loading feed preferences across lifecycle
2019-07-06 15:10:57 +02:00
H. Lehmann
ce649ec087
Merge pull request #3249 from archibishop/imagecover-playpause-fuctionality
...
Extend play/pause functionality to Image Cover
2019-07-06 15:00:30 +02:00
Wagubi Brian
e887996053
Extend play/pause functionality to Image Cover
2019-07-02 21:58:30 +03:00
Joe Stein
3b6cfb711f
New ViewModel for loading feed preferences across lifecycle
2019-07-02 18:33:32 +02:00
Wagubi Brian
7f1f725bfe
validate username for characters not accepted.
2019-06-26 04:50:18 +03:00
Anderson Mesquita
8e95ed75ab
Fix recycler and empty view hide/show logic
...
The `emptyViewHandler` already handles hiding and showing both the empty
view and the recycler view on data changes, so this commit removes this
part of the logic from the episodes fragment.
It also hides the empty view right after creating the recycle adapter
for the first time (when the fragment is created) to prevent the
progress bar and the empty view from being displayed at the same time.
`createRecycleAdapter()` signature was changed to make it explicit that
it depends on both the `recyclerView` and `emptyViewHandler`. Similarly,
`onFragmentLoaded()`, since it also depends on the new data that gets
loaded.
2019-06-24 09:32:06 -04:00
Anderson Mesquita
bb8b1fc58f
Reorganize subscription fragment lifecycle
2019-06-24 08:38:04 -04:00
Anderson Mesquita
fd07a10f03
Reorganize search fragment lifecycle
2019-06-24 08:38:04 -04:00
Anderson Mesquita
5e5dfa5584
Reorganize playback history lifecycle
2019-06-24 08:38:04 -04:00
Anderson Mesquita
90d5208402
Reorganize item fragments lifecycle
2019-06-24 08:38:04 -04:00
Anderson Mesquita
e22adbe451
Reorganize DownloadLogFragment lifecycle
2019-06-24 08:38:04 -04:00
Anderson Mesquita
bbcec5d0aa
Reorganize Episode Fragments lifecycle
...
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
Anderson Mesquita
aabe370db3
Fix whitespace
2019-06-24 08:38:04 -04:00
Anderson Mesquita
486ceed0ef
Reorganize downloads fragments lifecycle
...
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747 ), so this registers/unregisters on view create/destroy.
Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.
There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.
Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.
[1]: https://developer.android.com/guide/components/fragments
Closes : #2747
2019-06-24 08:38:04 -04:00
Anderson Mesquita
a556183d60
Extract methods from onViewCreated
2019-06-24 08:38:04 -04:00
Anderson Mesquita
69f116904d
Fix IDE warnings
...
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
Anderson Mesquita
56dc16802a
Fix whitespace
2019-06-24 08:38:04 -04:00
ByteHamster
f3cd43b972
Cleanup
2019-06-14 10:45:45 +02:00
ByteHamster
5a7cbdfaca
Added authentication and episode filter dialogs
2019-06-14 10:34:55 +02:00
ByteHamster
8f11f8a271
Updated feed settings screen
2019-06-14 00:38:34 +02:00
H. Lehmann
8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
...
Restructured preferences code
2019-06-13 23:38:18 +02:00
ByteHamster
85ef61f4ef
Removed deleted receiver from manifest
2019-06-13 23:18:12 +02:00
ByteHamster
99acff3b8f
Restructured preferences code
2019-06-13 23:12:41 +02:00
H. Lehmann
3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
...
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
Unknown
ee1809001d
don't override summary value in PreferenceController
2019-06-04 23:58:17 +02:00
H. Lehmann
405db1f169
Merge pull request #3164 from ByteHamster/work-manager
...
Work manager
2019-06-03 11:59:23 +02:00
ByteHamster
8dc4c9ff56
Upgrade preferences independently from database
2019-06-03 11:56:44 +02:00
Unknown
605e02fa70
add pref_episode_cache_summary
2019-06-01 18:16:47 +02:00
ByteHamster
f05132a716
Allow to disable auto updates
2019-05-28 18:11:12 +02:00
ByteHamster
4443d629fc
Merge branch 'develop' into work-manager
2019-05-28 17:56:05 +02:00
ByteHamster
ce8adc4b26
Use annotation processor for EventBus
2019-05-28 17:26:09 +02:00
H. Lehmann
d81cb2ff39
Merge pull request #3043 from CedricCabessa/remaining_time_playback_speed
...
Fixes #2197 : Remaining time playback speed
2019-05-28 15:52:54 +02:00
Cédric Cabessa
60771673dc
rename category title to match with "playback speeds"
...
also rename the key to be consistent with the content
2019-05-28 12:03:28 +02:00
H. Lehmann
f563fe48b5
Merge pull request #3207 from ByteHamster/sort-description
...
Sort options: 'old to new' instead of 'ascending'
2019-05-27 22:54:21 +02:00
Anderson Mesquita
2450b0817b
Replace action/callback utils with ItemActionButton
...
This just replaces all previous usages of `ActionButtonUtils` and
`DefaultActionButtonCallback` with the newly created `ItemActionButton`
class.
2019-05-27 16:06:55 -04:00
Anderson Mesquita
1d64057fd4
Extract action button utils/callback into classes
...
This splits the logic in `ActionButtonUtils` and
`DefaultActionButtonCallback` into multiple specialized classes to
reduce duplication figuring out which button/action to use while at the
same time making each individual button to have a single responsability.
2019-05-27 16:01:54 -04:00
ByteHamster
81a3d756eb
Sort options: 'old to new' instead of 'ascending'
2019-05-27 21:09:55 +02:00
Martin Fietz
c327fd59c9
Merge pull request #3206 from ByteHamster/clear-text-traffic
...
Clear text traffic in shownotes
2019-05-27 19:24:46 +02:00
ByteHamster
2d5995d1a5
Allow mixed content
2019-05-27 13:06:52 +02:00
ByteHamster
5ea11ca748
Allow cleartext traffic
2019-05-27 12:48:49 +02:00
H. Lehmann
46103883ce
Merge pull request #3191 from jas14/stricter-db-import
...
Check SQLite3 magic bytes before import
2019-05-27 12:44:44 +02:00
H. Lehmann
35770dc2e2
Merge pull request #3198 from jas14/fix-3196
...
Avoid error delivery to disposed Disposable
2019-05-27 12:41:33 +02:00
Joe Stein
382860d65e
Avoid error delivery to disposed Disposable
2019-05-23 08:48:34 -04:00