Commit Graph

1858 Commits

Author SHA1 Message Date
H. Lehmann eaa1527fac
Merge pull request #3278 from ByteHamster/empty-view
Updated empty views
2019-07-22 19:05:39 +02:00
H. Lehmann 865cb65470
Merge pull request #3240 from ByteHamster/combined-search
WIP: Combined podcast search
2019-07-22 19:05:21 +02:00
ByteHamster 613703ba95 Removed unused imports 2019-07-22 19:02:36 +02:00
ByteHamster a5df1c075d Targeting Android API 28 2019-07-22 18:50:56 +02:00
ByteHamster 94ba9dfd46 Using EmptyViewHandler for chapters fragment 2019-07-22 12:49:16 +02:00
ByteHamster a409f439ac Updated appearance of empty view 2019-07-22 12:49:11 +02:00
H. Lehmann fb294315a9
Merge pull request #3272 from andersonvom/3225-remove-new-flag
Reword "Mark as seen" to "Remove 'new' flag"
2019-07-14 17:47:50 +02:00
Anderson Mesquita c38d7bad6b Reword "Mark as seen" to "Remove 'new' flag"
This avoids the confusion between "Mark as seen" and "Mark as played".

Closes: #3225
2019-07-14 11:16:52 -04:00
H. Lehmann 539802ba04
Merge pull request #3267 from libliboom/develop
Removed screenOrientation attributes in manifest
2019-07-14 14:40:33 +02:00
bhlee 53073c958c add android:imeOptions="flagNoFullscreen" attribute in EditText 2019-07-14 21:14:54 +09:00
bhlee 329750ca01 add android:imeOptions="flagNoFullscreen" attribute in EditText 2019-07-14 21:09:56 +09:00
H. Lehmann 3b4fd3f414
Merge pull request #3271 from ByteHamster/fix-batch-edit
Fixed batch edit items grayed out on API 23 and 24
2019-07-14 10:30:10 +02:00
bhlee 339569421a add android:imeOptions="flagNoFullscreen" attribute in EditText 2019-07-14 01:48:50 +09:00
ByteHamster 5e1ab265b5 Fixed batch edit items grayed out on API 23 and 24 2019-07-13 17:47:27 +02:00
H. Lehmann 9fe4fed874
Merge pull request #3233 from jas14/pad-scrubber
Pad scrubber on large devices
2019-07-13 17:01:36 +02:00
H. Lehmann ed338edea4
Merge pull request #3266 from ByteHamster/remove-flattr
Removed Flattr support
2019-07-13 15:04:05 +02:00
bhlee f1d5c00f3b Resolves #3235. Refer to the changes.
- Remove android:screenOrientation="portrait" for rotating.
- Remove override onConfigurationChanged function that does nothing.
2019-07-13 20:14:16 +09:00
H. Lehmann c8fc1f90e0
Merge pull request #3265 from ByteHamster/storage-label
Added total space to storage select dialog
2019-07-12 22:51:11 +02:00
ByteHamster 641ee60cbf Removed Flattr support 2019-07-12 19:28:22 +02:00
ByteHamster b5b2bccda4 Added total space to storage select dialog 2019-07-12 18:59:43 +02:00
ByteHamster cbf3a2102f Simplified encoding query 2019-07-12 15:28:33 +02:00
ByteHamster 3962fdd6f8 Added CombinedSearcher for podcasts 2019-07-12 15:24:06 +02:00
ByteHamster eda23ca4bb Updated SearchPreference 2019-07-12 14:35:38 +02:00
H. Lehmann 9f6529d4bc
Merge branch 'develop' into 2747-completed-downloads-update 2019-07-11 12:43:30 +02:00
H. Lehmann e78e4d5656
Merge pull request #3261 from archibishop/fix-removing-wrong-favourite-message
Fix removing wrong favourite message
2019-07-11 12:42:14 +02:00
Wagubi Brian 782fce76d0 Fix removing wrong favoruite message 2019-07-10 12:29:48 +03:00
H. Lehmann 9e72780bc8
Merge pull request #3254 from jas14/feed-rotation-crash-3245
New ViewModel for loading feed preferences across lifecycle
2019-07-06 15:10:57 +02:00
H. Lehmann ce649ec087
Merge pull request #3249 from archibishop/imagecover-playpause-fuctionality
Extend play/pause functionality to Image Cover
2019-07-06 15:00:30 +02:00
Wagubi Brian e887996053 Extend play/pause functionality to Image Cover 2019-07-02 21:58:30 +03:00
Joe Stein 3b6cfb711f New ViewModel for loading feed preferences across lifecycle 2019-07-02 18:33:32 +02:00
Joe Stein 4bc8821845 Increase scrubber padding for large devices 2019-07-01 12:31:14 +02:00
ByteHamster 2d91292937 Combined podcast search 2019-06-26 08:27:19 +02:00
Wagubi Brian 7f1f725bfe validate username for characters not accepted. 2019-06-26 04:50:18 +03:00
Anderson Mesquita 8e95ed75ab Fix recycler and empty view hide/show logic
The `emptyViewHandler` already handles hiding and showing both the empty
view and the recycler view on data changes, so this commit removes this
part of the logic from the episodes fragment.

It also hides the empty view right after creating the recycle adapter
for the first time (when the fragment is created) to prevent the
progress bar and the empty view from being displayed at the same time.

`createRecycleAdapter()` signature was changed to make it explicit that
it depends on both the `recyclerView` and `emptyViewHandler`. Similarly,
`onFragmentLoaded()`, since it also depends on the new data that gets
loaded.
2019-06-24 09:32:06 -04:00
Anderson Mesquita bb8b1fc58f Reorganize subscription fragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita fd07a10f03 Reorganize search fragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita 5e5dfa5584 Reorganize playback history lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita 90d5208402 Reorganize item fragments lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita e22adbe451 Reorganize DownloadLogFragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita bbcec5d0aa Reorganize Episode Fragments lifecycle
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
Anderson Mesquita aabe370db3 Fix whitespace 2019-06-24 08:38:04 -04:00
Anderson Mesquita 486ceed0ef Reorganize downloads fragments lifecycle
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747), so this registers/unregisters on view create/destroy.

Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.

There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.

Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.

[1]: https://developer.android.com/guide/components/fragments

Closes: #2747
2019-06-24 08:38:04 -04:00
Anderson Mesquita a556183d60 Extract methods from onViewCreated 2019-06-24 08:38:04 -04:00
Anderson Mesquita 69f116904d Fix IDE warnings
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
Anderson Mesquita 56dc16802a Fix whitespace 2019-06-24 08:38:04 -04:00
ByteHamster f3cd43b972 Cleanup 2019-06-14 10:45:45 +02:00
ByteHamster 5a7cbdfaca Added authentication and episode filter dialogs 2019-06-14 10:34:55 +02:00
ByteHamster 8f11f8a271 Updated feed settings screen 2019-06-14 00:38:34 +02:00
H. Lehmann 8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
Restructured preferences code
2019-06-13 23:38:18 +02:00
ByteHamster 85ef61f4ef Removed deleted receiver from manifest 2019-06-13 23:18:12 +02:00