ByteHamster
cfaccef2b3
Actually return instance in getInstance
...
This probably fixes all those "db deleted" issues and mysterious NPEs
Previously, the synchronized keyword on open() and close() was useless
because it was synchronizing on different objects in each thread.
2018-04-06 12:02:03 +02:00
ByteHamster
67b01f6ec8
Use generic export message instead of OPML
...
The same message is shown for HTML and OPML. Fixes #2462 .
Additionally, using string formatting now instead of just "+"
2018-04-05 16:26:01 +02:00
Martin Fietz
43f450433e
Merge pull request #2607 from ByteHamster/content-encoded
...
Fixes empty contentEncoded
2018-04-03 21:59:02 +02:00
ByteHamster
68a0373d9f
Merge remote-tracking branch 'upstream/develop' into layout-improvements
2018-04-02 21:13:39 +02:00
ByteHamster
146ec02395
Extracted color resource
2018-04-02 21:13:13 +02:00
Martin Fietz
9cd9d455c8
Merge pull request #2568 from ByteHamster/crashfix
...
Fixed crash if media file exists but can not be read
2018-04-01 23:21:27 +02:00
Martin Fietz
894c7b6360
Merge pull request #2598 from orionlee/upgrade_android_gradle_plugin_v3
...
Upgrade android gradle plugin v3
2018-04-01 23:19:44 +02:00
ByteHamster
97b5779c4a
Remove nested if
2018-03-23 15:47:41 +01:00
ByteHamster
5048eb10d2
Use description for shownotes if it is longer than contentEncoded
2018-03-23 15:46:00 +01:00
ByteHamster
afb9f7db6a
Fixes empty contentEncoded
2018-03-23 14:33:23 +01:00
ByteHamster
4213d8fc8b
Fixed crash if media file exists but can not be read
...
Happens when exporting db and importing it into debug version
because media files are located in an app-private folder
2018-03-22 22:15:58 +01:00
Martin Fietz
6dbe772345
Merge pull request #2569 from ByteHamster/white-icon
...
Removed large icon from notification
2018-03-18 10:19:20 +01:00
Martin Fietz
0262325e36
Merge pull request #2574 from ByteHamster/forensics
...
Backup corrupted db
2018-03-18 10:17:32 +01:00
orionlee
1a55348849
remove the deprecated publishNonDefault
2018-03-13 12:35:48 -07:00
orionlee
cd8f220ce0
robotium-solo : corrected its dependency as androidTestImplementation in app/
2018-03-13 12:28:13 -07:00
orionlee
95037f67ad
dependencies: replace deprecated compile with implementation / api
2018-03-13 11:34:29 -07:00
orionlee
b71e61a221
Upgrade to Android Gradle Plugin v3.0.1 - bare minimal to get it built, ignoring depercation warnings
...
Details:
- upgraded buildtools to the latest (minimum 26.0.2 required)
- retired retrolambda
- added flavorDimensions (v3 requirement)
- Migrate dependency configurations for local modules (:core)
- Declaration of resources update in styles.xml (AAPT2 requirement)
- upgraded plugin github play-publisher to v1.2.0
2018-03-13 09:51:50 -07:00
Jan Niehusmann
f514a439e2
Fix possible NPE accessing image.download_url
...
May fix #2386 . If so, thanks to @cyplo who provided the logcat output
which directed me to that code path.
2018-03-04 22:19:03 +01:00
ByteHamster
f90d3c2e7b
Backup corrupted db
...
This might allow some forensics if #2463 happens. Maybe it also
allows to recover some of the files manually.
2018-02-20 23:22:51 +01:00
ByteHamster
6e5b639608
Removed large icon
...
Closes #2541 .
We do not need the same icon twice.
As the icon is displayed white-on-white, it is not visible anyways.
This also gives more space to the notification text
2018-02-17 18:09:08 +01:00
Martin Fietz
287bb5f7e1
Merge pull request #2550 from ByteHamster/download-range
...
Hotfix for servers not accepting the Range header
2018-01-24 08:04:12 +01:00
ByteHamster
bc9d39dedf
Hotfix for servers not accepting the Range header
...
Because of #2339 , the file always exists when starting a download.
There is still an issue with the server parsing "Range: bytes=0-"
incorrectly, but this commit should make the error appear less often.
Related to #2539
2018-01-23 23:31:08 +01:00
Martin Fietz
94e8c2d92b
Merge pull request #2549 from AntennaPod/bugfix/corrupt-database
...
Synchronize opening and closing of the database
2018-01-22 21:50:55 +01:00
Martin Fietz
f7de8a0e44
Synchronize opening and closing of the database
2018-01-22 21:45:38 +01:00
H. Lehmann
77b199d005
Merge pull request #2547 from ByteHamster/improve-export-naming
...
Improved wording (Closes #2545 )
2018-01-22 13:18:28 +01:00
ByteHamster
8b041be8aa
Improved export success wording ( Closes #2545 )
2018-01-21 23:37:41 +01:00
Martin Fietz
82378f3647
Merge branch 'develop' into stringbuilder
2018-01-21 22:12:54 +01:00
Andrew Gaul
278e93880e
Prefer StringBuilder over StringBuffer
...
The latter has unnecessary synchronization. Found via error-prone.
2018-01-21 13:04:57 -08:00
Martin Fietz
2a792c3c75
Remove useless comment
2018-01-21 13:08:36 +01:00
Martin Fietz
86f6c001c1
Inline variables
2018-01-21 13:05:10 +01:00
Martin Fietz
a6c33d3b2c
Fix style
2018-01-21 13:03:00 +01:00
Martin Fietz
d3491d1858
Merge branch 'develop' into refactor
...
# Conflicts:
# app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
# core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java
2018-01-21 11:10:20 +01:00
Martin Fietz
f7c048e5b4
Update translations
2018-01-21 11:00:15 +01:00
Martin Fietz
e6498393a6
Merge pull request #2445 from ByteHamster/export
...
Database import/export
2018-01-21 10:51:16 +01:00
Martin Fietz
9adbf83182
Merge pull request #2543 from gaul/static-final
...
Make some static fields final
2018-01-21 10:03:52 +01:00
Andrew Gaul
404f241891
Make some static fields final
...
Adding final prohibits modification and allows initialization of
primitive and String fields at compile time instead of runtime in
clinit:
https://developer.android.com/training/articles/perf-tips.html#UseFinal
Found via error-prone.
2018-01-20 18:28:21 -08:00
Andrew Gaul
118d9103c1
Make some inner classes static
...
This avoids an implicit this field and can help GC. Found via
error-prone.
2018-01-20 18:26:08 -08:00
Martin Fietz
e4770e7edc
PlayerStatus and playable fields cannot be final
2018-01-19 17:25:47 +01:00
Martin Fietz
99f01bdc90
Add throws to avoid interface clash
2018-01-14 18:42:50 +01:00
Martin Fietz
b38d016ec3
Remove catch for exception that is never thrown
2018-01-14 18:41:26 +01:00
Martin Fietz
c12fedf392
Merge folder configuration
2018-01-14 18:17:08 +01:00
Martin Fietz
e9700b0627
Lookup service via application context to avoid memory leak
2018-01-14 18:14:15 +01:00
Martin Fietz
3cb8f27e49
Remove unnecessary interface modifiers
2018-01-14 18:09:15 +01:00
Martin Fietz
b80d6a7914
Remove redundant throws clauses
2018-01-14 18:06:24 +01:00
Martin Fietz
a49048c7f6
Add final modifiers
2018-01-14 18:05:45 +01:00
Martin Fietz
b86b6caec8
Weaken declaration access
2018-01-14 18:04:54 +01:00
Martin Fietz
eaa9947869
Fix pointless arithmetic expression
2018-01-14 18:03:22 +01:00
Martin Fietz
d7e1b0f977
Replace StringBuilder with String
2018-01-14 18:02:13 +01:00
Martin Fietz
01fa0a56ea
Replace manual array t collection copy
2018-01-14 17:59:51 +01:00
Martin Fietz
53dc62ec0f
Remove unused imports
2018-01-14 17:51:24 +01:00