Commit Graph

1222 Commits

Author SHA1 Message Date
orionlee 1a55348849 remove the deprecated publishNonDefault 2018-03-13 12:35:48 -07:00
orionlee cd8f220ce0 robotium-solo : corrected its dependency as androidTestImplementation in app/ 2018-03-13 12:28:13 -07:00
orionlee 95037f67ad dependencies: replace deprecated compile with implementation / api 2018-03-13 11:34:29 -07:00
orionlee b71e61a221 Upgrade to Android Gradle Plugin v3.0.1 - bare minimal to get it built, ignoring depercation warnings
Details:
- upgraded buildtools to the latest (minimum 26.0.2 required)
- retired retrolambda
- added flavorDimensions (v3 requirement)
- Migrate dependency configurations for local modules (:core)
- Declaration of resources update in styles.xml (AAPT2 requirement)
- upgraded plugin github play-publisher to v1.2.0
2018-03-13 09:51:50 -07:00
Jan Niehusmann f514a439e2 Fix possible NPE accessing image.download_url
May fix #2386. If so, thanks to @cyplo who provided the logcat output
which directed me to that code path.
2018-03-04 22:19:03 +01:00
Martin Fietz 287bb5f7e1
Merge pull request #2550 from ByteHamster/download-range
Hotfix for servers not accepting the Range header
2018-01-24 08:04:12 +01:00
ByteHamster bc9d39dedf Hotfix for servers not accepting the Range header
Because of #2339, the file always exists when starting a download.
There is still an issue with the server parsing "Range: bytes=0-"
incorrectly, but this commit should make the error appear less often.

Related to #2539
2018-01-23 23:31:08 +01:00
Martin Fietz 94e8c2d92b
Merge pull request #2549 from AntennaPod/bugfix/corrupt-database
Synchronize opening and closing of the database
2018-01-22 21:50:55 +01:00
Martin Fietz f7de8a0e44 Synchronize opening and closing of the database 2018-01-22 21:45:38 +01:00
H. Lehmann 77b199d005
Merge pull request #2547 from ByteHamster/improve-export-naming
Improved wording (Closes #2545)
2018-01-22 13:18:28 +01:00
ByteHamster 8b041be8aa Improved export success wording (Closes #2545) 2018-01-21 23:37:41 +01:00
Martin Fietz 82378f3647
Merge branch 'develop' into stringbuilder 2018-01-21 22:12:54 +01:00
Andrew Gaul 278e93880e Prefer StringBuilder over StringBuffer
The latter has unnecessary synchronization.  Found via error-prone.
2018-01-21 13:04:57 -08:00
Martin Fietz 2a792c3c75 Remove useless comment 2018-01-21 13:08:36 +01:00
Martin Fietz 86f6c001c1 Inline variables 2018-01-21 13:05:10 +01:00
Martin Fietz a6c33d3b2c Fix style 2018-01-21 13:03:00 +01:00
Martin Fietz d3491d1858 Merge branch 'develop' into refactor
# Conflicts:
#	app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
#	core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java
2018-01-21 11:10:20 +01:00
Martin Fietz f7c048e5b4 Update translations 2018-01-21 11:00:15 +01:00
Martin Fietz e6498393a6
Merge pull request #2445 from ByteHamster/export
Database import/export
2018-01-21 10:51:16 +01:00
Martin Fietz 9adbf83182
Merge pull request #2543 from gaul/static-final
Make some static fields final
2018-01-21 10:03:52 +01:00
Andrew Gaul 404f241891 Make some static fields final
Adding final prohibits modification and allows initialization of
primitive and String fields at compile time instead of runtime in
clinit:

https://developer.android.com/training/articles/perf-tips.html#UseFinal

Found via error-prone.
2018-01-20 18:28:21 -08:00
Andrew Gaul 118d9103c1 Make some inner classes static
This avoids an implicit this field and can help GC.  Found via
error-prone.
2018-01-20 18:26:08 -08:00
Martin Fietz e4770e7edc PlayerStatus and playable fields cannot be final 2018-01-19 17:25:47 +01:00
Martin Fietz 99f01bdc90 Add throws to avoid interface clash 2018-01-14 18:42:50 +01:00
Martin Fietz b38d016ec3 Remove catch for exception that is never thrown 2018-01-14 18:41:26 +01:00
Martin Fietz c12fedf392 Merge folder configuration 2018-01-14 18:17:08 +01:00
Martin Fietz e9700b0627 Lookup service via application context to avoid memory leak 2018-01-14 18:14:15 +01:00
Martin Fietz 3cb8f27e49 Remove unnecessary interface modifiers 2018-01-14 18:09:15 +01:00
Martin Fietz b80d6a7914 Remove redundant throws clauses 2018-01-14 18:06:24 +01:00
Martin Fietz a49048c7f6 Add final modifiers 2018-01-14 18:05:45 +01:00
Martin Fietz b86b6caec8 Weaken declaration access 2018-01-14 18:04:54 +01:00
Martin Fietz eaa9947869 Fix pointless arithmetic expression 2018-01-14 18:03:22 +01:00
Martin Fietz d7e1b0f977 Replace StringBuilder with String 2018-01-14 18:02:13 +01:00
Martin Fietz 01fa0a56ea Replace manual array t collection copy 2018-01-14 17:59:51 +01:00
Martin Fietz 53dc62ec0f Remove unused imports 2018-01-14 17:51:24 +01:00
Martin Fietz a8e4fcf1b0 Replace for loop with foreach 2018-01-14 17:50:59 +01:00
Martin Fietz cbc3b23753 Replace explicit type with <> 2018-01-14 17:50:32 +01:00
Martin Fietz 7b2d7e80a4 Replace lambda with method reference 2018-01-14 17:48:11 +01:00
Martin Fietz 332943effb Replace anonymous type with lambda 2018-01-14 17:47:43 +01:00
Martin Fietz 33f8ead4a0 Fix error 2018-01-10 22:58:52 +01:00
Martin Fietz c4d19b7163 Silence warnings 2018-01-10 22:50:56 +01:00
Martin Fietz ba3eb5e784 Remove assertions 2018-01-10 21:56:08 +01:00
H. Lehmann 2c9582c947
Merge pull request #2534 from AntennaPod/sdk_int_lt_14
Replace code for SDK version lower than 14
2018-01-10 18:26:54 +01:00
H. Lehmann be569bfb14
Merge pull request #2531 from AntennaPod/remove_nineoldandroids
Replace ViewHelper
2018-01-10 15:24:34 +01:00
Martin Fietz 89366d97d1 Replace code for SDK version lower than 14 2018-01-09 21:03:30 +01:00
Martin Fietz 59a1b4a2bb Cleanup executeAsync 2018-01-09 20:13:14 +01:00
Martin Fietz eaf007ecac Replace ViewHelper 2018-01-09 19:59:51 +01:00
Martin Fietz 4d156118cc
Merge pull request #2520 from dirkmueller/include_cleanup
Cleanup order/remove unused includes
2018-01-07 20:11:01 +01:00
Dirk Mueller bbbff0bc73 Cleanup order/remove unused includes
This is the result of Android Studio's include cleanup
Macro. This removes some no longer used includes, simplifying
the code a bit. The rest is grouping and resorting alphabetically.
2018-01-07 19:26:23 +01:00
Dirk Mueller 234e3ddbc2 Fix small whitespace error
This causes Android Lint to barf as it can not detect
the VIBRATE permission being requested.
2018-01-07 15:51:04 +01:00