Commit Graph

1545 Commits

Author SHA1 Message Date
ByteHamster 3fce9490c2 Do not overwrite feed description with item description 2018-07-13 10:18:29 +02:00
ByteHamster 683e576987 Do not show badges for ongoing notifications (Closes #2724) 2018-07-13 09:38:34 +02:00
ByteHamster 53a3b85272 Actually stop PlaybackService 2018-07-13 09:23:36 +02:00
H. Lehmann eff72db7c4
Merge pull request #2754 from AntennaPod/bugfix/2749-parse-error
Assume version 2.0 for RSS if property is missing
2018-07-09 12:43:25 +02:00
ByteHamster 37f407dc07 Do not authenticate image without user 2018-07-07 09:48:12 +02:00
Martin Fietz 43911c3dab Assume version 2.0 for RSS if property is missing 2018-07-07 09:09:57 +02:00
ByteHamster 8a0769d466 Better feed parser errors 2018-07-06 10:10:21 +02:00
ByteHamster a9d9a5ac42 Added Exoplayer to new method 2018-07-04 23:54:04 +02:00
ByteHamster 3d1646c205 Merge branch 'develop' into exo-player 2018-07-04 23:53:02 +02:00
ByteHamster 67d3115049 Only highlight currently playing item if playback service is running
Killing the service while playing left the queue entry highlighted
2018-07-04 23:28:19 +02:00
ByteHamster dc8bd43d06 Merge branch 'develop' into playbackservice-improvements 2018-07-04 22:51:30 +02:00
H. Lehmann c9c2e68d7b
Merge pull request #2718 from ByteHamster/broadcasts
Limit broadcasts to current app
2018-06-26 17:31:42 +02:00
ByteHamster de21ff42d9 Applied suggestions 2018-06-10 11:04:29 +02:00
ByteHamster 1331c92c1d Do not call error handler when shutting down playback service 2018-06-10 10:31:51 +02:00
H. Lehmann 11c3a45f6e
Merge branch 'develop' into prevent-thrashing 2018-06-08 20:40:57 +02:00
H. Lehmann ac2acc65c3
Merge branch 'develop' into remove-unused-code 2018-06-08 20:27:11 +02:00
ByteHamster 83a9df2657 Merge branch 'develop' into exo-player 2018-06-08 20:14:57 +02:00
H. Lehmann f0151501a5
Merge pull request #2726 from ByteHamster/feedimage
Removed FeedImage
2018-06-08 20:13:36 +02:00
ByteHamster 9fb695822a Removed delibertate fallthrough 2018-06-08 00:28:32 +02:00
ByteHamster e282250c08 Fixed image url of Feed 2018-06-08 00:15:43 +02:00
Martin Fietz f933cd226b
Merge pull request #2728 from ByteHamster/alifeflow-develop
True Black Theme for AMOLED
2018-06-06 21:53:10 +02:00
ByteHamster c2ace74156 Stop service on status change 2018-06-06 18:37:33 +02:00
ByteHamster 0ece32ab0e Move old image url to new column 2018-06-06 18:01:23 +02:00
ByteHamster 1b84cbbef1 Merge branch 'develop' into feedimage 2018-06-06 17:25:05 +02:00
Martin Fietz 77b03dc2d9
Merge pull request #2727 from ByteHamster/db-update-handler
Moved database upgrades to their own class
2018-06-06 17:02:45 +02:00
ByteHamster bb716ce9ea Moved playing background into attr 2018-06-06 16:32:41 +02:00
ByteHamster ca6639892d Fixed build 2018-06-06 16:16:42 +02:00
ByteHamster 2a8408d84d Merge branch 'develop' of https://github.com/alifeflow/AntennaPod into alifeflow-develop 2018-06-06 16:09:15 +02:00
ByteHamster 9cf71f85b9 Using utils 2018-06-06 16:05:05 +02:00
ByteHamster e15451177b Moved database upgrades to their own class 2018-06-06 15:17:39 +02:00
ByteHamster 8fa3180446 Restored tests 2018-06-06 15:08:46 +02:00
ByteHamster 9b738ca5d4 Fixed feed item display 2018-06-06 14:52:50 +02:00
ByteHamster fa48076175 Write feed url to database 2018-06-06 00:15:19 +02:00
ByteHamster eba0817ee0 Prevent crash 2018-06-06 00:08:22 +02:00
ByteHamster abb13dc447 Database scheme update 2018-06-06 00:07:21 +02:00
ByteHamster ba2233430e Removed FeedImage 2018-06-05 23:52:19 +02:00
ByteHamster 02186a3f0d Limit broadcasts to current app 2018-05-29 23:25:19 +02:00
ByteHamster 632906df07 PlaybackService notification setup improvements 2018-05-29 23:12:13 +02:00
ByteHamster 9df23ebbf6 Removed unused code 2018-05-27 20:07:29 +02:00
ByteHamster 7e59ac0e75 Executing core unit tests on CircleCI 2018-05-27 19:30:01 +02:00
orionlee 2058f3c0b3 #2577: ensure that during feeds update, automatic (episodes) download will
download the latest ones by waiting the feeds update complete before
starting autodownload.
2018-05-27 10:06:07 -07:00
H. Lehmann fe92c98661
Merge pull request #2700 from orionlee/fix_core_test_coverage_etc
Fix core tests: default coverage, consistent convention, etc.
2018-05-27 19:05:10 +02:00
H. Lehmann 532d822b3c
Merge branch 'develop' into exo-player 2018-05-26 23:45:18 +02:00
H. Lehmann 39a462431f
Merge pull request #2667 from ByteHamster/api-26-support
Api 26 support
2018-05-26 23:39:35 +02:00
ByteHamster 443f6315fa Moved methods into AutoUpdateManager 2018-05-26 23:30:06 +02:00
ByteHamster b3e02e215c Simplified AutoUpdateManager 2018-05-26 23:25:18 +02:00
ByteHamster 9ce48bd86b Added a refreshAllFeeds method without callback 2018-05-26 23:20:47 +02:00
ByteHamster aa25ab5ff4 Added examples to notification descriptions 2018-05-26 23:18:01 +02:00
ByteHamster badc839804 Gpodder sync does not need a notification anymore 2018-05-26 23:14:07 +02:00
ByteHamster 3edbbe8c53 Moved notification utils to other package 2018-05-26 23:13:16 +02:00
brad 6bda6405b8
avoid unused context parameter 2018-05-20 23:01:14 -07:00
orionlee 1f14d8482e core tests: DateUtilsTest - states why it remains to be an androidTest. 2018-05-18 13:44:00 -07:00
orionlee eb0ef1e201 core tests: Make DownloadServiceTest be a unit test (the portion of
DownloadService tested is all in-memory logic).
2018-05-18 13:42:39 -07:00
orionlee 46ae3e0b00 core tests: Convert tests that are effectively unit tests to be one
(standard android junit tests). Provides implementations for
android platform utils needed (in unit test environment):
1. android.util.Log, 2. android.text.TextUtils.isEmpty()
2018-05-18 13:21:36 -07:00
orionlee f05c7e23ef core tests fix: use consistent convention that tests are in the same
java package as the classes under test.
2018-05-17 14:56:18 -07:00
orionlee 7dd4e5caa1 core tests fix: ensure running test suite (gradlew connectedAndroidTest)
include all test. The existing config does not include the tests
in feed/ directory.
2018-05-17 14:55:51 -07:00
orionlee da85e00bd9 Give FeedUpdateReceiver a human-friendly label per review feedback. 2018-05-15 15:20:56 -07:00
Koen Glotzbach 6e876db9b6
Update strings.xml
Improve preference description following https://github.com/AntennaPod/AntennaPod/issues/1560#issuecomment-172252386. Not sure if same change should be applied also to string "pref_hardwarePreviousButtonRestarts_sum"
2018-05-14 23:34:37 +02:00
orionlee e021d4e147 #2686: Allow feeds update to be triggered by external apps. 2018-05-12 13:50:37 -07:00
ByteHamster 407f92be12 Merge branch 'develop' into api-26-support 2018-05-07 20:02:07 +02:00
ByteHamster d7d614f33f Fixed compile error and warning about mixed support versions 2018-05-06 23:15:55 +02:00
ByteHamster f6082f5808 Using builder to call PlaybackService 2018-05-06 19:46:31 +02:00
ByteHamster 4411b0ffaa Fix possible missing sync calls 2018-05-06 19:21:02 +02:00
ByteHamster cb70aeb3cf Code style improvements 2018-05-06 19:15:40 +02:00
ByteHamster 22f791e05f Moved auto update handling to new class 2018-05-06 19:07:25 +02:00
ByteHamster 61f8000352 Using callback instead of sync/async methods 2018-05-06 18:52:16 +02:00
Martin Fietz f6faca95c0
Merge pull request #2673 from ByteHamster/preference-support
Switched to PreferenceFragmentCompat
2018-05-06 17:45:25 +02:00
Martin Fietz b156458d83
Merge pull request #2646 from vimsick/fast-forward
Fix Bluetooth Forward Skip Button for Android 8
2018-05-06 17:37:53 +02:00
Martin Fietz 930330fbb4
Merge pull request #2675 from ByteHamster/delete-feed-while-playing
Stop playback service when feed is deleted
2018-05-05 18:41:48 +02:00
ByteHamster 304696d59e Stop playback service when item of deleted feed is played
Closes #2425
2018-05-05 18:24:32 +02:00
Martin Fietz 121f1d9d79
Merge pull request #2671 from ByteHamster/content-encoded-addition
Fix empty contentEncoded
2018-05-05 18:24:09 +02:00
ByteHamster a270d4fc03 Migrated Gpodnet to JobIntentService, so it does not need notification 2018-05-05 15:10:08 +02:00
ByteHamster 7a768e9809 Fixed widget if service is not running 2018-05-05 14:32:04 +02:00
ByteHamster 7107819a6a Moved widget from app to core 2018-05-05 14:04:12 +02:00
ByteHamster 0b54d97a0a Switched widget to JobIntentService 2018-05-05 13:39:57 +02:00
H. Lehmann dacd7787bc
Merge pull request #2664 from orionlee/share_link_improvement_2579
Share link improvement 2579
2018-05-04 23:31:39 +02:00
ByteHamster ca3d6b9a3d Persist job through reboot 2018-05-04 22:47:53 +02:00
ByteHamster eeb032e938 Notify system when job is done 2018-05-04 22:41:53 +02:00
ByteHamster a97b524a05 Review changes #2 2018-05-04 22:23:15 +02:00
ByteHamster 686801fea2 Switched to PreferenceCompat 2018-05-04 19:06:32 +02:00
ByteHamster f66e19845c Review changes 2018-05-04 14:36:32 +02:00
ByteHamster 9f0d187efd Fix empty contentEncoded
This code duplication was forgotten in #2607
2018-05-04 13:57:55 +02:00
ByteHamster ffdfefc35d Fixed fresh install crash 2018-05-03 19:36:40 +02:00
ByteHamster 2190101cf9 Added JobScheduler for feed updates 2018-05-03 19:11:30 +02:00
ByteHamster 3e98ab61ea Start PlaybackService lazily to allow using ForegroundService 2018-05-03 19:11:30 +02:00
ByteHamster 7ad176ce29 Added notification categories
Android treats IMPORTANCE_DEFAULT as IMPORTANCE_HIGH
https://issuetracker.google.com/issues/65108694
2018-05-03 19:11:28 +02:00
ByteHamster 1d0459b126 Updated build tools 2018-05-03 19:11:00 +02:00
orionlee 4c7531d277 Flatten nested ifs, per @ByteHamster feedback 2018-05-02 13:53:56 -07:00
orionlee 9dcbddf371 Issue #2580: Expose "Mark as seen" as a context menu item in Episode
screen, in addition to the existing swipe in Episode > New tab.
2018-05-02 13:15:14 -07:00
ByteHamster 719545fd3d Prevent thrashing the database by opening and closing rapidly
Reduces number of real close() calls to the database
from multiple times per second to one single time
2018-05-02 21:52:21 +02:00
orionlee ab0f413185 Make FeedItemUtil.getLinkWithFallback(item) tolerates null item. 2018-04-30 15:49:18 -07:00
orionlee 345fcc17d0 FeedItem Visit Website tweak: use feed website as a fallback,
analogous to how share FeedItem link work.
Applicable to both feed playback screen and feed information screen.
2018-04-30 15:44:19 -07:00
orionlee 4bba6b30a1 Issue #2579: Provide share Link in episode playback screen even
when the episode has no link - Use podcast link as the fallback.
Also bug fix share link with position: to include epsiode
and podcast title.
2018-04-30 15:03:04 -07:00
mr-intj 7be44370f6 * Using Camel Case for methods
* Use braces on single-line blocks
2018-04-30 14:44:13 -07:00
mr-intj 91120d98a4 Added "Random" and "Smart Shuffle" items at the bottom of the Queue|Sort menu.
Added "Permutor" interface to allow specification of reordering logic to be specified in QueueSorter (vs. DBWriter), similar to the existing sort logic.

Added "Random" and "Smart Shuffle" strings to core/src/main/res/values (did not add translations for non-English languages)

Closes #2366, Closes #2602
2018-04-27 17:30:40 -07:00
ByteHamster c977e70106 Removed duplicate String 2018-04-22 20:49:41 +02:00
ByteHamster 8b72f35147 Merge branch 'develop' into exo-player 2018-04-22 20:48:00 +02:00
ByteHamster 94bf3cd734 I deleted a line accidentally 2018-04-22 20:41:20 +02:00
Martin Fietz e9695a426f
Merge pull request #2634 from ByteHamster/preference-rework
Preferences rework
2018-04-22 20:35:13 +02:00
ByteHamster f2ee5d7ff2 Renamed Services to Integrations 2018-04-22 19:20:11 +02:00
ByteHamster 74a8d34354 Added network icon 2018-04-22 19:16:03 +02:00
ByteHamster 03f1af6ad4 Disable items correctly in autodownload 2018-04-22 18:51:10 +02:00
ByteHamster bb42ddbd56 MasterSwitchPreference 2018-04-22 18:41:43 +02:00
ByteHamster 33e695b519 Automation category 2018-04-22 17:49:20 +02:00
Martin Fietz e12751986b
Merge pull request #2564 from xisberto/adaptive_icon
Adaptive icon
2018-04-22 17:25:33 +02:00
ByteHamster 8c6f40b0a2 Fixed miniplayer position after start
Casting magic values to int is not a good idea...
2018-04-22 14:41:05 +02:00
ByteHamster 56aa64725c Merge branch 'develop' into preference-rework 2018-04-22 10:01:46 +02:00
ByteHamster 6d3fc04f52 Merge branch 'develop' into exo-player 2018-04-22 09:43:59 +02:00
Martin Fietz c9a2bbc2c9
Merge pull request #2654 from ydinath/ReplaceDeprecatedLang3Methods
Replace deprecated org.apache.commons.lang3 methods
2018-04-22 09:23:51 +02:00
Martin Fietz 4edaa2e6fc
Merge pull request #2639 from ByteHamster/fix-play-button
Don't pause directly after starting
2018-04-22 09:14:09 +02:00
Martin Fietz ff22099b88
Merge pull request #2641 from ByteHamster/feed-info-and-settings
Split feed info and settings
2018-04-22 08:59:39 +02:00
Martin Fietz cca1de8d0d
Merge pull request #2637 from ByteHamster/apply-actions
Changed batch edit icon and name
2018-04-22 08:29:24 +02:00
Martin Fietz a9e269b3bf
Merge pull request #2506 from ByteHamster/picture-in-picture
Added Picure in picture
2018-04-22 08:07:05 +02:00
ByteHamster e4f7d65273 Variable for exoplayer version 2018-04-21 18:39:43 +02:00
ByteHamster df8f90083c Cleanup 2018-04-21 18:13:24 +02:00
ByteHamster d50dcac96e Added ExoPlayer setting 2018-04-21 17:58:14 +02:00
ydinath a837485363 Fix formatting 2018-04-21 10:28:16 -04:00
ydinath 8c628d98b9 Replace deprecated org.apache.commons.lang3 methods with org.apache.commons.text methods 2018-04-21 10:27:11 -04:00
Spencer Visick d652bd2184 Fix Bluetooth Forward Skip Button for Android 8
It appears that Oreo has changed the behavior for Bluetooth KeyEvents.
Starting with Android 8.0, KeyEvent.getSource() returns 0 (unknown
source).

This change explicitly sets when a key press is sent from a
notification, or lockscreen event. Otherwise we use the
customer-defined skip behavior.
2018-04-19 21:39:21 -07:00
ByteHamster 06dab67b03 Fixed some warnings 2018-04-19 22:11:29 +02:00
ByteHamster 7e61de3f65 Added streaming support 2018-04-19 21:46:41 +02:00
ByteHamster 9cf32a2aa9 Added ExoPlayer 2018-04-19 21:39:55 +02:00
alifeflow 12ee8d89b2 [True Black] Fix UI Elements
Add true black style for progress bar
Add true black style for item description
Add true black style for web description
2018-04-14 15:05:37 +09:00
alifeflow deb2cea72f [True Black] Cleaning up Code
Remove unused imports and redundant values
Coding style adjustment
2018-04-14 14:28:28 +09:00
ByteHamster c9fdc05784 Split feed info and settings 2018-04-13 15:39:51 +02:00
ByteHamster 2924955b61 Don't pause directly after starting
When registering the receiver, it immediately receives
a headset unplugged event (broadcast is sticky) and pauses
playback again in some cases. We are only interested in status
changes, so we can just return.

Fixes #2635
2018-04-12 23:12:08 +02:00
ByteHamster c5bdf341fa Changed batch edit icon and name
Closes #1146
2018-04-11 17:15:59 +02:00
ByteHamster 0f80fac680 Allow to continue playback when leaving player 2018-04-11 12:15:49 +02:00
ByteHamster 0b96588b10 Using attr icons in preferences 2018-04-11 00:41:44 +02:00
ByteHamster 1afe8888d1 Changed icons 2018-04-10 23:50:32 +02:00
ByteHamster 5a2dca2840 Removed misc settings 2018-04-10 23:41:41 +02:00
ByteHamster 8ad9ef6c19 Added categories 2018-04-10 23:33:04 +02:00
ByteHamster 47909464af Extracted string resources 2018-04-10 22:14:25 +02:00
ByteHamster d757abedbc Removing PiP option for unsupported devices 2018-04-09 22:20:43 +02:00
ByteHamster 64221f7f56 Allow to enter PiP automatically 2018-04-09 19:43:50 +02:00
ByteHamster 562bbf21f0 Split up two different uses of the string 'New'
Closes #2348
2018-04-09 18:33:06 +02:00
ByteHamster 0a5a31a169 Merge branch 'develop' into picture-in-picture 2018-04-08 23:23:03 +02:00
Martin Fietz 4e63bfb11c Update translations 2018-04-07 18:03:49 +02:00
Martin Fietz ccd29a9991
Merge pull request #2618 from hannesa2/AndroidStudio_3.1
update to AndroidStudio 3.1
2018-04-07 17:49:24 +02:00
Martin Fietz c5e99c92b3
Merge pull request #2626 from ByteHamster/failed-url
Showing URL for failed downloads
2018-04-07 17:34:52 +02:00
ByteHamster e7ce5c669e Using Bill Pugh Singleton Implementation 2018-04-07 16:21:57 +02:00
ByteHamster cfaccef2b3 Actually return instance in getInstance
This probably fixes all those "db deleted" issues and mysterious NPEs
Previously, the synchronized keyword on open() and close() was useless
because it was synchronizing on different objects in each thread.
2018-04-06 12:02:03 +02:00
ByteHamster e41bc7bd61 Showing URL for failed downloads
Closes #1082
2018-04-05 18:25:19 +02:00
ByteHamster 67b01f6ec8 Use generic export message instead of OPML
The same message is shown for HTML and OPML. Fixes #2462.
Additionally, using string formatting now instead of just "+"
2018-04-05 16:26:01 +02:00
Hannes Achleitner 9e83deb069 Code format just in one file (no logic change) 2018-04-04 13:52:30 +02:00
Martin Fietz 43f450433e
Merge pull request #2607 from ByteHamster/content-encoded
Fixes empty contentEncoded
2018-04-03 21:59:02 +02:00
ByteHamster 02da84b93a Merge remote-tracking branch 'upstream/develop' into picture-in-picture 2018-04-02 22:19:09 +02:00
ByteHamster 68a0373d9f Merge remote-tracking branch 'upstream/develop' into layout-improvements 2018-04-02 21:13:39 +02:00
ByteHamster 146ec02395 Extracted color resource 2018-04-02 21:13:13 +02:00
Martin Fietz 9cd9d455c8
Merge pull request #2568 from ByteHamster/crashfix
Fixed crash if media file exists but can not be read
2018-04-01 23:21:27 +02:00
Martin Fietz 894c7b6360
Merge pull request #2598 from orionlee/upgrade_android_gradle_plugin_v3
Upgrade android gradle plugin v3
2018-04-01 23:19:44 +02:00
alifeflow 05f923ebe2 [Ture Black] True Black Theme for AMOLED
Add true black themese
Modified code that fails to support three themes
2018-03-25 16:02:35 +09:00
ByteHamster 97b5779c4a Remove nested if 2018-03-23 15:47:41 +01:00
ByteHamster 5048eb10d2 Use description for shownotes if it is longer than contentEncoded 2018-03-23 15:46:00 +01:00
ByteHamster afb9f7db6a Fixes empty contentEncoded 2018-03-23 14:33:23 +01:00
ByteHamster 4213d8fc8b Fixed crash if media file exists but can not be read
Happens when exporting db and importing it into debug version
because media files are located in an app-private folder
2018-03-22 22:15:58 +01:00
Martin Fietz 6dbe772345
Merge pull request #2569 from ByteHamster/white-icon
Removed large icon from notification
2018-03-18 10:19:20 +01:00
Martin Fietz 0262325e36
Merge pull request #2574 from ByteHamster/forensics
Backup corrupted db
2018-03-18 10:17:32 +01:00
orionlee 1a55348849 remove the deprecated publishNonDefault 2018-03-13 12:35:48 -07:00
orionlee cd8f220ce0 robotium-solo : corrected its dependency as androidTestImplementation in app/ 2018-03-13 12:28:13 -07:00
orionlee 95037f67ad dependencies: replace deprecated compile with implementation / api 2018-03-13 11:34:29 -07:00
orionlee b71e61a221 Upgrade to Android Gradle Plugin v3.0.1 - bare minimal to get it built, ignoring depercation warnings
Details:
- upgraded buildtools to the latest (minimum 26.0.2 required)
- retired retrolambda
- added flavorDimensions (v3 requirement)
- Migrate dependency configurations for local modules (:core)
- Declaration of resources update in styles.xml (AAPT2 requirement)
- upgraded plugin github play-publisher to v1.2.0
2018-03-13 09:51:50 -07:00
Jan Niehusmann f514a439e2 Fix possible NPE accessing image.download_url
May fix #2386. If so, thanks to @cyplo who provided the logcat output
which directed me to that code path.
2018-03-04 22:19:03 +01:00
ByteHamster f90d3c2e7b Backup corrupted db
This might allow some forensics if #2463 happens. Maybe it also
allows to recover some of the files manually.
2018-02-20 23:22:51 +01:00
ByteHamster 6e5b639608 Removed large icon
Closes #2541.
We do not need the same icon twice.
As the icon is displayed white-on-white, it is not visible anyways.
This also gives more space to the notification text
2018-02-17 18:09:08 +01:00
Humberto Fraga 45440d775f Removing old files and changing references.
Splash screen now follows icon color.
2018-02-10 16:52:18 -03:00
Humberto Fraga 7f0ba828fa Adding new ic_launcher files 2018-02-10 16:45:29 -03:00
Martin Fietz 287bb5f7e1
Merge pull request #2550 from ByteHamster/download-range
Hotfix for servers not accepting the Range header
2018-01-24 08:04:12 +01:00
ByteHamster bc9d39dedf Hotfix for servers not accepting the Range header
Because of #2339, the file always exists when starting a download.
There is still an issue with the server parsing "Range: bytes=0-"
incorrectly, but this commit should make the error appear less often.

Related to #2539
2018-01-23 23:31:08 +01:00
Martin Fietz 94e8c2d92b
Merge pull request #2549 from AntennaPod/bugfix/corrupt-database
Synchronize opening and closing of the database
2018-01-22 21:50:55 +01:00
Martin Fietz f7de8a0e44 Synchronize opening and closing of the database 2018-01-22 21:45:38 +01:00
H. Lehmann 77b199d005
Merge pull request #2547 from ByteHamster/improve-export-naming
Improved wording (Closes #2545)
2018-01-22 13:18:28 +01:00
ByteHamster 8b041be8aa Improved export success wording (Closes #2545) 2018-01-21 23:37:41 +01:00
H. Lehmann 5526937698
Merge branch 'develop' into picture-in-picture 2018-01-21 22:50:47 +01:00
Martin Fietz 82378f3647
Merge branch 'develop' into stringbuilder 2018-01-21 22:12:54 +01:00
Andrew Gaul 278e93880e Prefer StringBuilder over StringBuffer
The latter has unnecessary synchronization.  Found via error-prone.
2018-01-21 13:04:57 -08:00
Martin Fietz 2a792c3c75 Remove useless comment 2018-01-21 13:08:36 +01:00
Martin Fietz 86f6c001c1 Inline variables 2018-01-21 13:05:10 +01:00
Martin Fietz a6c33d3b2c Fix style 2018-01-21 13:03:00 +01:00
Martin Fietz d3491d1858 Merge branch 'develop' into refactor
# Conflicts:
#	app/src/main/java/de/danoeh/antennapod/activity/MediaplayerInfoActivity.java
#	core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java
2018-01-21 11:10:20 +01:00
Martin Fietz f7c048e5b4 Update translations 2018-01-21 11:00:15 +01:00
Martin Fietz e6498393a6
Merge pull request #2445 from ByteHamster/export
Database import/export
2018-01-21 10:51:16 +01:00
Martin Fietz 9adbf83182
Merge pull request #2543 from gaul/static-final
Make some static fields final
2018-01-21 10:03:52 +01:00
Andrew Gaul 404f241891 Make some static fields final
Adding final prohibits modification and allows initialization of
primitive and String fields at compile time instead of runtime in
clinit:

https://developer.android.com/training/articles/perf-tips.html#UseFinal

Found via error-prone.
2018-01-20 18:28:21 -08:00
Andrew Gaul 118d9103c1 Make some inner classes static
This avoids an implicit this field and can help GC.  Found via
error-prone.
2018-01-20 18:26:08 -08:00
Martin Fietz e4770e7edc PlayerStatus and playable fields cannot be final 2018-01-19 17:25:47 +01:00
Martin Fietz 99f01bdc90 Add throws to avoid interface clash 2018-01-14 18:42:50 +01:00
Martin Fietz b38d016ec3 Remove catch for exception that is never thrown 2018-01-14 18:41:26 +01:00
Martin Fietz c12fedf392 Merge folder configuration 2018-01-14 18:17:08 +01:00
Martin Fietz e9700b0627 Lookup service via application context to avoid memory leak 2018-01-14 18:14:15 +01:00
Martin Fietz 3cb8f27e49 Remove unnecessary interface modifiers 2018-01-14 18:09:15 +01:00
Martin Fietz b80d6a7914 Remove redundant throws clauses 2018-01-14 18:06:24 +01:00
Martin Fietz a49048c7f6 Add final modifiers 2018-01-14 18:05:45 +01:00
Martin Fietz b86b6caec8 Weaken declaration access 2018-01-14 18:04:54 +01:00
Martin Fietz eaa9947869 Fix pointless arithmetic expression 2018-01-14 18:03:22 +01:00
Martin Fietz d7e1b0f977 Replace StringBuilder with String 2018-01-14 18:02:13 +01:00
Martin Fietz 01fa0a56ea Replace manual array t collection copy 2018-01-14 17:59:51 +01:00
Martin Fietz 53dc62ec0f Remove unused imports 2018-01-14 17:51:24 +01:00
Martin Fietz a8e4fcf1b0 Replace for loop with foreach 2018-01-14 17:50:59 +01:00
Martin Fietz cbc3b23753 Replace explicit type with <> 2018-01-14 17:50:32 +01:00