Commit Graph

1818 Commits

Author SHA1 Message Date
Anderson Mesquita aabe370db3 Fix whitespace 2019-06-24 08:38:04 -04:00
Anderson Mesquita 486ceed0ef Reorganize downloads fragments lifecycle
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747), so this registers/unregisters on view create/destroy.

Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.

There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.

Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.

[1]: https://developer.android.com/guide/components/fragments

Closes: #2747
2019-06-24 08:38:04 -04:00
Anderson Mesquita a556183d60 Extract methods from onViewCreated 2019-06-24 08:38:04 -04:00
Anderson Mesquita 69f116904d Fix IDE warnings
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
Anderson Mesquita 56dc16802a Fix whitespace 2019-06-24 08:38:04 -04:00
ByteHamster f3cd43b972 Cleanup 2019-06-14 10:45:45 +02:00
ByteHamster 5a7cbdfaca Added authentication and episode filter dialogs 2019-06-14 10:34:55 +02:00
ByteHamster 8f11f8a271 Updated feed settings screen 2019-06-14 00:38:34 +02:00
H. Lehmann 8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
Restructured preferences code
2019-06-13 23:38:18 +02:00
ByteHamster 85ef61f4ef Removed deleted receiver from manifest 2019-06-13 23:18:12 +02:00
ByteHamster 99acff3b8f Restructured preferences code 2019-06-13 23:12:41 +02:00
H. Lehmann 3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
Unknown ee1809001d don't override summary value in PreferenceController 2019-06-04 23:58:17 +02:00
H. Lehmann 405db1f169
Merge pull request #3164 from ByteHamster/work-manager
Work manager
2019-06-03 11:59:23 +02:00
ByteHamster 8dc4c9ff56 Upgrade preferences independently from database 2019-06-03 11:56:44 +02:00
Unknown 605e02fa70 add pref_episode_cache_summary 2019-06-01 18:16:47 +02:00
ByteHamster f05132a716 Allow to disable auto updates 2019-05-28 18:11:12 +02:00
ByteHamster 4443d629fc Merge branch 'develop' into work-manager 2019-05-28 17:56:05 +02:00
ByteHamster ce8adc4b26 Use annotation processor for EventBus 2019-05-28 17:26:09 +02:00
H. Lehmann d81cb2ff39
Merge pull request #3043 from CedricCabessa/remaining_time_playback_speed
Fixes #2197: Remaining time playback speed
2019-05-28 15:52:54 +02:00
Cédric Cabessa 60771673dc rename category title to match with "playback speeds"
also rename the key to be consistent with the content
2019-05-28 12:03:28 +02:00
H. Lehmann f563fe48b5
Merge pull request #3207 from ByteHamster/sort-description
Sort options: 'old to new' instead of 'ascending'
2019-05-27 22:54:21 +02:00
Anderson Mesquita 2450b0817b Replace action/callback utils with ItemActionButton
This just replaces all previous usages of `ActionButtonUtils` and
`DefaultActionButtonCallback` with the newly created `ItemActionButton`
class.
2019-05-27 16:06:55 -04:00
Anderson Mesquita 1d64057fd4 Extract action button utils/callback into classes
This splits the logic in `ActionButtonUtils` and
`DefaultActionButtonCallback` into multiple specialized classes to
reduce duplication figuring out which button/action to use while at the
same time making each individual button to have a single responsability.
2019-05-27 16:01:54 -04:00
ByteHamster 81a3d756eb Sort options: 'old to new' instead of 'ascending' 2019-05-27 21:09:55 +02:00
Martin Fietz c327fd59c9
Merge pull request #3206 from ByteHamster/clear-text-traffic
Clear text traffic in shownotes
2019-05-27 19:24:46 +02:00
ByteHamster 2d5995d1a5 Allow mixed content 2019-05-27 13:06:52 +02:00
ByteHamster 5ea11ca748 Allow cleartext traffic 2019-05-27 12:48:49 +02:00
H. Lehmann 46103883ce
Merge pull request #3191 from jas14/stricter-db-import
Check SQLite3 magic bytes before import
2019-05-27 12:44:44 +02:00
H. Lehmann 35770dc2e2
Merge pull request #3198 from jas14/fix-3196
Avoid error delivery to disposed Disposable
2019-05-27 12:41:33 +02:00
Joe Stein 382860d65e Avoid error delivery to disposed Disposable 2019-05-23 08:48:34 -04:00
Joe Stein 4f3fa6246e Added test for shutdown/widget updater race in PSTM 2019-05-21 18:36:04 -04:00
Joe Stein 09e138b51f Check SQLite3 magic bytes before import 2019-05-20 17:41:20 -04:00
H. Lehmann c98a7c0c38
Merge pull request #3136 from andersonvom/develop
Add progress bar with space information to data folder selection dialog
2019-05-19 19:38:37 +02:00
Anderson Mesquita e4a17562cb Improve space wording on choose data folder dialog
This makes it clear that the number refers to the **free** space left on
the device, as opposed to the total space available.
2019-05-19 13:25:27 -04:00
Anderson Mesquita 9396d41dcc Add space usage bar to data folder dialog
This displays a progress bar with the amount of used/free space in each
storage location to make it easier to identify storage devices. This is
particularly useful for devices that use non-standard names.

Reference: #3049
2019-05-19 13:25:27 -04:00
Anderson Mesquita 683f7e46a2 Extract data folder dialog layout
This is in preparation to add a progress bar displaying the amount of
used/free space in the dialog (#3049). Since we'll need a custom view to
do it, this extracts the layout beforehand.
2019-05-19 13:25:27 -04:00
Anderson Mesquita 31adff0dcc Extract methods in ChooseDataFolderDialog
This makes the main `showDialog()` method a bit shorter by extracting
behavior into shorter methods.
2019-05-19 13:25:27 -04:00
ByteHamster b2ea26d489 No longer try to remove log 2019-05-19 19:23:33 +02:00
H. Lehmann a8b05c3c66
Merge pull request #3165 from ByteHamster/opml-import-mismatch
Removed opml pick action
2019-05-19 19:22:14 +02:00
H. Lehmann 0b6930517a
Merge pull request #3109 from ByteHamster/eventbus-v3
Eventbus v3
2019-05-19 19:19:52 +02:00
ByteHamster 55874607df No longer need to listen to serviceEvent. PlaybackController does that automatically 2019-05-19 19:14:11 +02:00
ByteHamster ccbcdb6861 Fixed crash 2019-05-19 19:01:26 +02:00
ByteHamster 73744e3d4c Merge branch 'develop' into eventbus-v3 2019-05-19 18:59:03 +02:00
H. Lehmann fa03edf419
Merge pull request #3177 from andersonvom/fix-episodes-searchbar
Prevent actionbar items from moving when searching for episodes
2019-05-19 18:46:07 +02:00
Martin Fietz 5db139958a
Merge pull request #3162 from andersonvom/2853-chapter-scrolling
Scroll to chapter currently being played
2019-05-19 12:14:56 +02:00
Martin Fietz 8f93e3b2e2
Merge pull request #3172 from andersonvom/3169-cover-fragment-small-screen
Fix cover fragment in small screens
2019-05-19 12:01:45 +02:00
Martin Fietz 751670a659
Merge pull request #3168 from ByteHamster/about-open-browser
About screen: Open web links in browser
2019-05-19 11:34:17 +02:00
ByteHamster b89271329b Bumped version to 1.7.2b 2019-05-17 19:20:10 +02:00
H. Lehmann 1a327a2aae
Merge pull request #3188 from ByteHamster/revert-playbackservice-changes
Revert playbackservice changes
2019-05-17 15:23:41 +02:00