1826 Commits

Author SHA1 Message Date
H. Lehmann
7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates
Mobile updates: Allow images
2019-04-03 17:43:53 +02:00
H. Lehmann
b6e50c61d6
Merge pull request #3060 from jatinkumarg/issue-3052
Added empty views to the PlayBack History, Queue,and Downloads
2019-04-03 17:42:09 +02:00
ByteHamster
788e75515a Review changes 2019-04-03 17:29:44 +02:00
orionlee
3768dfb0ff bulk edit - "N selected" UI logic 2019-04-02 17:34:05 -07:00
orionlee
364c9a308d bulk remove from queue - backend - implement the new API 2019-04-02 15:59:27 -07:00
orionlee
70287a740e bulk remove from queue - backend - refactor existing logic to support bulk remove 2019-04-02 14:59:12 -07:00
orionlee
7d78b88a1c bulk remove from queue - frontend logic, with a stub backend. 2019-04-02 14:11:22 -07:00
orionlee
737f7571ab UI Prototype for Batch Edit Episodes rework (from #1145) 2019-04-02 11:47:57 -07:00
ByteHamster
6fe171fac9 Use ApOkHttpUrlLoader for all images
Probably got broken during my Glide update.
When using append or prepend, Glide uses the next one in the chain if ApOkHttpUrlLoader blocks
2019-04-02 17:41:21 +02:00
ByteHamster
0fda36b9b3 Add preference to allow mobile updates of images 2019-04-02 17:41:15 +02:00
Borjan Tchakaloff
c589bd2022 Validate that the *new* and *not played* are also exclusive
The FeedItem state is actually a tri-state, complement the test
coverage by checking that the state changes from *new* to
*not played*.
2019-03-31 21:26:53 +02:00
Borjan Tchakaloff
6ebf1defe7 Validate that the item state is only changed when needed
Follow-up to commit 8172d87477dd593745d4776417ef3dd7884d17fb (#3067)
that adds test coverage for the resolved issue.

Also, fix that commit by making the update condition more explicit:
the FeedItem state is only changed when a state switch is necessary.
In other words, an item marked as *new* that gets downloaded should
lose the *new* mark and gain the *unplayed* mark instead.
2019-03-31 16:28:05 +02:00
Borjan Tchakaloff
cba4059063 Require the Mockito library for unit testing 2019-03-31 16:26:26 +02:00
Borjan Tchakaloff
3c7fd274de Validate that the *new* and *played* states are exclusive 2019-03-31 16:26:26 +02:00
H. Lehmann
c6344f5bc0
Merge pull request #3073 from deandreamatias/fix-button-shadow-3040
Fix #3040 Video playback control button shadow
2019-03-31 00:44:50 +01:00
Matias de Andrea
56456e0001 Delete unused drawable 2019-03-30 21:21:11 +01:00
Martin Fietz
f900046c66
Merge pull request #3068 from bibz/develop
Do not reset item "played" flag on media download
2019-03-30 11:12:46 +01:00
Matias de Andrea
7f3f2180cc Fixes #3040
- Delete unused icons
2019-03-29 22:27:26 +01:00
Matias de Andrea
007f92c291 Change the icons in interface #3040 2019-03-29 22:23:52 +01:00
Matias de Andrea
9e21695486 Add new vector icons #3040 2019-03-29 22:21:04 +01:00
Jatin Kumar
209b0b3880 Fixed typos 2019-03-29 14:20:11 -04:00
Matias de Andrea
09087b354d Fix #3040
- Change the size of the button circle background
2019-03-29 12:57:52 +01:00
H. Lehmann
42cbdbd989
Merge pull request #3066 from orionlee/bugfix_statistics_played_duration_inflated_2162
bugfix - statistics - inflated actual played duration
2019-03-27 20:51:13 +01:00
Jatin Kumar
bdf7bf6844 Fixes #3052: Added empty views to the Playback History, Queue, Downloads and Episodes 2019-03-27 04:16:06 -04:00
Borjan Tchakaloff
8172d87477 Do not reset item "played" flag on media download
If an item has already been played, downloading its media will not
reset that "played" flag.

Fixes: #3067
2019-03-25 15:41:39 +01:00
orionlee
0a01f6e00b #2162 bugfix - statistics - inflated actual played duration 2019-03-24 13:00:37 -07:00
Jatin Kumar
6662205167 Added empty views to the PlayBack History, Queue,and Downloads 2019-03-21 03:05:01 -04:00
Matthieu De Beule
e25659a128 Fix #3054: use UTF-8 to encode password and username for gpodder auth 2019-03-08 17:46:30 +01:00
orionlee
7a905c0570 remove the commented stopService() call (to avoid future confusion) 2019-03-05 15:07:16 -08:00
orionlee
24915785eb remove the stopService() per review (which might unnecessarily
stop the playback when unsupported media buttons are pressed.)
2019-03-05 15:01:48 -08:00
H. Lehmann
c1bfb9183c
Merge pull request #3013 from hannesa2/buildImprovements
Build improvements
2019-03-05 23:49:00 +01:00
orionlee
e94e95e844 remove dead codes 2019-03-04 13:46:11 -08:00
orionlee
600e0e561e coding style fix per review 2019-03-04 13:44:53 -08:00
H. Lehmann
c0f534e825
Merge pull request #3050 from ByteHamster/add-backup-keyword
Add backup keyword to search
2019-03-04 18:57:37 +01:00
ByteHamster
579b263a86 Add backup keyword to search 2019-03-04 14:33:39 +01:00
ByteHamster
c50d37fa1b Moved some implementation tests to unit tests 2019-03-03 23:55:52 +01:00
H. Lehmann
1593a06077
Merge pull request #3032 from shortspider/3031-TimecodeRegex
Change Timecode Regex
2019-03-03 23:26:32 +01:00
Nathan Mascitelli
1d0e701525 Another atempt at fixing the regex 2019-03-03 13:36:28 -05:00
Nathan Mascitelli
7e3ccd97da Fix regex 2019-03-02 12:12:26 -05:00
Nathan Mascitelli
6f69b4b140 Adjust regext to ignore X:Y timecodes 2019-03-02 08:47:52 -05:00
orionlee
a3389490bb ensure the service continues to run in the event it takes a long time for the service to load the media to play, e.g.,
streaming over a slow network.
2019-02-27 14:59:31 -08:00
orionlee
ab78c1d410 bug fix for Android8+: revert context.startService() calls back to
ContextCompat.startForegroundService(), to ensure PlaybackService
can be started.

While PlaybackService itself ensures it will be raised to foreground
when appropriate, Android 8+ forbids creating the (background)
services to begin with (and throw IllegalStateException) in some
situation (e.g., BroadcastReceiver).

https://developer.android.com/about/versions/oreo/android-8.0-changes#atap
2019-02-27 14:52:34 -08:00
orionlee
2c5db08e25 minor cleanup of Log codes and comments. 2019-02-27 14:52:34 -08:00
orionlee
221cd4b480 refactor stop PlaybackService setupNotification() - extract common
code as private helper.
2019-02-27 14:52:34 -08:00
orionlee
f0f8623937 refactor stop PlaybackService codes - remove legacy dead codes 2019-02-27 14:52:34 -08:00
orionlee
584865ad18 review stop PlaybackService codes (stopSelf, stopForeground, etc.) 2019-02-27 14:52:34 -08:00
orionlee
3f14fac479 remove static PlaybackService.started, in favor of the start state
managed by inner ServiceManager.
Also add a generic java8-like Optional class for use with RxJava2 where
null was to be returned (RxJava2 requires non-null).
2019-02-27 14:52:34 -08:00
orionlee
e26a54bdbc start playbackService code paths reviewed (context.startService() and
ContextCompat.startForegroundService())
2019-02-27 14:52:34 -08:00
orionlee
76fbab8e82 more #2716 - fix VideoPlayback upon hitting home button. 2019-02-27 14:52:34 -08:00
orionlee
f3980091a9 #2716 Prototype for the revamped PlaybackService to fix phantom
notification. Many rough edges. Notable TODOs are marked with [2716].
2019-02-27 14:52:34 -08:00