Andrew Gaul
|
404f241891
|
Make some static fields final
Adding final prohibits modification and allows initialization of
primitive and String fields at compile time instead of runtime in
clinit:
https://developer.android.com/training/articles/perf-tips.html#UseFinal
Found via error-prone.
|
2018-01-20 18:28:21 -08:00 |
|
Andrew Gaul
|
118d9103c1
|
Make some inner classes static
This avoids an implicit this field and can help GC. Found via
error-prone.
|
2018-01-20 18:26:08 -08:00 |
|
Martin Fietz
|
e4770e7edc
|
PlayerStatus and playable fields cannot be final
|
2018-01-19 17:25:47 +01:00 |
|
Martin Fietz
|
99f01bdc90
|
Add throws to avoid interface clash
|
2018-01-14 18:42:50 +01:00 |
|
Martin Fietz
|
e56e3868da
|
Variable cannot be final
|
2018-01-14 18:42:26 +01:00 |
|
Martin Fietz
|
b38d016ec3
|
Remove catch for exception that is never thrown
|
2018-01-14 18:41:26 +01:00 |
|
Martin Fietz
|
c12fedf392
|
Merge folder configuration
|
2018-01-14 18:17:08 +01:00 |
|
Martin Fietz
|
e9700b0627
|
Lookup service via application context to avoid memory leak
|
2018-01-14 18:14:15 +01:00 |
|
Martin Fietz
|
3cb8f27e49
|
Remove unnecessary interface modifiers
|
2018-01-14 18:09:15 +01:00 |
|
Martin Fietz
|
44f80a9831
|
static modifier is redundant for inner enums
|
2018-01-14 18:08:48 +01:00 |
|
Martin Fietz
|
b80d6a7914
|
Remove redundant throws clauses
|
2018-01-14 18:06:24 +01:00 |
|
Martin Fietz
|
a49048c7f6
|
Add final modifiers
|
2018-01-14 18:05:45 +01:00 |
|
Martin Fietz
|
b86b6caec8
|
Weaken declaration access
|
2018-01-14 18:04:54 +01:00 |
|
Martin Fietz
|
eaa9947869
|
Fix pointless arithmetic expression
|
2018-01-14 18:03:22 +01:00 |
|
Martin Fietz
|
e02baebf02
|
Use bulk operation instead of iteration
|
2018-01-14 18:02:56 +01:00 |
|
Martin Fietz
|
d7e1b0f977
|
Replace StringBuilder with String
|
2018-01-14 18:02:13 +01:00 |
|
Martin Fietz
|
919ee63c3c
|
Use StringBuilder for string concatenation in loop
|
2018-01-14 18:01:31 +01:00 |
|
Martin Fietz
|
e44a54c965
|
Remove redundant call to 'String.format()'
|
2018-01-14 18:00:57 +01:00 |
|
Martin Fietz
|
55e2ac4ebe
|
Remove redundant calls to toString()
|
2018-01-14 18:00:21 +01:00 |
|
Martin Fietz
|
01fa0a56ea
|
Replace manual array t collection copy
|
2018-01-14 17:59:51 +01:00 |
|
Martin Fietz
|
84b196746b
|
Replace single-argument 'Arrays.asList()' with 'Collections.singletonList()'
|
2018-01-14 17:58:15 +01:00 |
|
Martin Fietz
|
f8d1f32e9b
|
Replace equals with operator
|
2018-01-14 17:55:51 +01:00 |
|
Martin Fietz
|
bf41f1713d
|
Synchronization field must be final
|
2018-01-14 17:55:25 +01:00 |
|
Martin Fietz
|
7d98db8321
|
Collapse empty tag
|
2018-01-14 17:53:52 +01:00 |
|
Martin Fietz
|
53dc62ec0f
|
Remove unused imports
|
2018-01-14 17:51:24 +01:00 |
|
Martin Fietz
|
a8e4fcf1b0
|
Replace for loop with foreach
|
2018-01-14 17:50:59 +01:00 |
|
Martin Fietz
|
cbc3b23753
|
Replace explicit type with <>
|
2018-01-14 17:50:32 +01:00 |
|
Martin Fietz
|
26b938ce5b
|
Replace statement lambda with expression lambda
|
2018-01-14 17:48:52 +01:00 |
|
Martin Fietz
|
7b2d7e80a4
|
Replace lambda with method reference
|
2018-01-14 17:48:11 +01:00 |
|
Martin Fietz
|
332943effb
|
Replace anonymous type with lambda
|
2018-01-14 17:47:43 +01:00 |
|
Martin Fietz
|
7257a6c76e
|
Refactor
|
2018-01-13 17:36:04 +01:00 |
|
Martin Fietz
|
b98571ede8
|
Update gradle wrapper
|
2018-01-13 15:46:23 +01:00 |
|
Martin Fietz
|
648b6c9529
|
Remove superfluous logging
|
2018-01-10 23:26:58 +01:00 |
|
Martin Fietz
|
0774ed12e5
|
Move attributes to edittext
|
2018-01-10 23:26:20 +01:00 |
|
Martin Fietz
|
214d651735
|
LinearLayout should use 'layout_height="wrap_content"'
|
2018-01-10 23:23:22 +01:00 |
|
Martin Fietz
|
249bf9bc18
|
Do not treat position as fixed
|
2018-01-10 23:21:53 +01:00 |
|
Martin Fietz
|
33f8ead4a0
|
Fix error
|
2018-01-10 22:58:52 +01:00 |
|
Martin Fietz
|
c4d19b7163
|
Silence warnings
|
2018-01-10 22:50:56 +01:00 |
|
Martin Fietz
|
c524791c3c
|
Avoid NPEs
|
2018-01-10 22:44:52 +01:00 |
|
Martin Fietz
|
ce2aeb5e90
|
Use DecimalFormat
|
2018-01-10 22:42:59 +01:00 |
|
Martin Fietz
|
92184452e0
|
'ellipsize=start' and 'lines=1' can lead to crashes
|
2018-01-10 22:27:07 +01:00 |
|
Martin Fietz
|
ab287fe028
|
Silence warning
|
2018-01-10 22:20:31 +01:00 |
|
Martin Fietz
|
36a7261f89
|
Simplify
|
2018-01-10 22:16:51 +01:00 |
|
Martin Fietz
|
74b2d439c3
|
Replace deprecated method
|
2018-01-10 22:15:47 +01:00 |
|
Martin Fietz
|
5bacbff10b
|
Simplify
|
2018-01-10 22:04:51 +01:00 |
|
Martin Fietz
|
0238d24216
|
Replace deprecated method
|
2018-01-10 22:02:59 +01:00 |
|
Martin Fietz
|
21ac9d158f
|
Avoid NPE
|
2018-01-10 21:59:13 +01:00 |
|
Martin Fietz
|
ba3eb5e784
|
Remove assertions
|
2018-01-10 21:56:08 +01:00 |
|
Martin Fietz
|
220f549711
|
Reduce visibility
|
2018-01-10 21:46:11 +01:00 |
|
Martin Fietz
|
0c4a08ac56
|
Suppress inspection
|
2018-01-10 21:45:49 +01:00 |
|