90d5208402
Reorganize item fragments lifecycle
2019-06-24 08:38:04 -04:00
e22adbe451
Reorganize DownloadLogFragment lifecycle
2019-06-24 08:38:04 -04:00
bbcec5d0aa
Reorganize Episode Fragments lifecycle
...
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
aabe370db3
Fix whitespace
2019-06-24 08:38:04 -04:00
486ceed0ef
Reorganize downloads fragments lifecycle
...
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747 ), so this registers/unregisters on view create/destroy.
Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.
There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.
Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.
[1]: https://developer.android.com/guide/components/fragments
Closes : #2747
2019-06-24 08:38:04 -04:00
a556183d60
Extract methods from onViewCreated
2019-06-24 08:38:04 -04:00
69f116904d
Fix IDE warnings
...
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
56dc16802a
Fix whitespace
2019-06-24 08:38:04 -04:00
1580e93b94
Merge pull request #3229 from ByteHamster/feed-settings-update
...
Updated feed settings screen
2019-06-14 18:47:53 +02:00
f3cd43b972
Cleanup
2019-06-14 10:45:45 +02:00
5a7cbdfaca
Added authentication and episode filter dialogs
2019-06-14 10:34:55 +02:00
8f11f8a271
Updated feed settings screen
2019-06-14 00:38:34 +02:00
8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
...
Restructured preferences code
2019-06-13 23:38:18 +02:00
d21422a50f
Merge pull request #3228 from ByteHamster/removed-deleted-receiver
...
Removed deleted receiver from manifest
2019-06-13 23:22:18 +02:00
85ef61f4ef
Removed deleted receiver from manifest
2019-06-13 23:18:12 +02:00
99acff3b8f
Restructured preferences code
2019-06-13 23:12:41 +02:00
3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
...
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
d2b3d5f220
remove german translation
2019-06-07 09:47:55 +02:00
2949fe61b6
Merge pull request #3218 from ByteHamster/mobile-download
...
Clarified mobile updates setting
2019-06-06 00:18:51 +02:00
6712711ab2
Clarified setting
2019-06-05 23:50:52 +02:00
ee1809001d
don't override summary value in PreferenceController
2019-06-04 23:58:17 +02:00
80ecfacb81
Merge pull request #3215 from ByteHamster/crashes
...
Fixed ArrayIndexOutOfBoundsException
2019-06-03 12:40:45 +02:00
83201d27df
Merge pull request #3214 from ByteHamster/work-manager-disabled-auto-update
...
Handle disabled auto update
2019-06-03 12:39:19 +02:00
ba96311e87
Fixed ArrayIndexOutOfBoundsException
2019-06-03 12:32:38 +02:00
6a83d2a434
Handle disabled auto update
2019-06-03 12:19:34 +02:00
405db1f169
Merge pull request #3164 from ByteHamster/work-manager
...
Work manager
2019-06-03 11:59:23 +02:00
8dc4c9ff56
Upgrade preferences independently from database
2019-06-03 11:56:44 +02:00
5630bf756d
Revert "Start WorkManager on upgrade"
...
This reverts commit d372aa9577
2019-06-03 11:44:18 +02:00
d372aa9577
Start WorkManager on upgrade
2019-06-03 11:31:53 +02:00
605e02fa70
add pref_episode_cache_summary
2019-06-01 18:16:47 +02:00
eb92e1144b
Merge pull request #3212 from ByteHamster/issue-template
...
Updated to new issue template file structure
2019-05-29 19:36:25 +02:00
a3a3eec675
Updated to new issue template file structure
2019-05-29 19:13:29 +02:00
f05132a716
Allow to disable auto updates
2019-05-28 18:11:12 +02:00
4443d629fc
Merge branch 'develop' into work-manager
2019-05-28 17:56:05 +02:00
18d297a0e5
Merge pull request #3210 from ByteHamster/eventbus-annotation
...
Use annotation processor for EventBus
2019-05-28 17:52:39 +02:00
cb3b3ac578
Merge pull request #3174 from skitt/spread-smart-shuffle
...
Smart shuffle: spread episodes evenly
2019-05-28 17:44:12 +02:00
ce8adc4b26
Use annotation processor for EventBus
2019-05-28 17:26:09 +02:00
83a6d70387
bugfix #3009 - Podcast's feed search results listed in an odd order ( #3128 )
2019-05-28 16:44:18 +02:00
8380c18543
Merge pull request #2709 from brad/fix-2359
...
Display cover art for media in the widget
2019-05-28 16:29:43 +02:00
88854ea6ba
Make sure to clear old icon if loading fails
2019-05-28 16:23:46 +02:00
d81cb2ff39
Merge pull request #3043 from CedricCabessa/remaining_time_playback_speed
...
Fixes #2197 : Remaining time playback speed
2019-05-28 15:52:54 +02:00
60771673dc
rename category title to match with "playback speeds"
...
also rename the key to be consistent with the content
2019-05-28 12:03:28 +02:00
f563fe48b5
Merge pull request #3207 from ByteHamster/sort-description
...
Sort options: 'old to new' instead of 'ascending'
2019-05-27 22:54:21 +02:00
0e3a0862fe
Merge pull request #3160 from andersonvom/refactor-action-button
...
Refactor action button logic
2019-05-27 22:53:53 +02:00
2450b0817b
Replace action/callback utils with ItemActionButton
...
This just replaces all previous usages of `ActionButtonUtils` and
`DefaultActionButtonCallback` with the newly created `ItemActionButton`
class.
2019-05-27 16:06:55 -04:00
1d64057fd4
Extract action button utils/callback into classes
...
This splits the logic in `ActionButtonUtils` and
`DefaultActionButtonCallback` into multiple specialized classes to
reduce duplication figuring out which button/action to use while at the
same time making each individual button to have a single responsability.
2019-05-27 16:01:54 -04:00
81a3d756eb
Sort options: 'old to new' instead of 'ascending'
2019-05-27 21:09:55 +02:00
c327fd59c9
Merge pull request #3206 from ByteHamster/clear-text-traffic
...
Clear text traffic in shownotes
2019-05-27 19:24:46 +02:00
2d5995d1a5
Allow mixed content
2019-05-27 13:06:52 +02:00
5ea11ca748
Allow cleartext traffic
2019-05-27 12:48:49 +02:00
Anderson Mesquita
H. Lehmann
ByteHamster
Unknown
alimemonzx
Cédric Cabessa
Martin Fietz