Castopod/AntennaPod
1
0
Fork 0
mirror of https://github.com/AntennaPod/AntennaPod.git synced 2024-12-26 08:44:13 +01:00
Code Issues Packages Projects Releases Wiki Activity
4,942 Commits 4 Branches 122 Tags 205 MiB
8f93e3b2e2
Commit Graph

4942 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
orionlee
20f1445c06 fix rebase conflicts - remove the incorrect @NonNull from rxjava 2019-04-06 14:19:16 -07:00
orionlee
c04f340ae2 #2966 RxJava2 null - case underlying method has needs to return null. 
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.

Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
 2019-04-06 13:43:12 -07:00
orionlee
1655d234af #2966 RxJava2 null - case the underlying method may return null, but 
should never happen in the code path, e.g.,
 return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
 onError() to handle null case

Rx observer : underlying sources marked as @Nullable
 ItemFragment.load : .loadInBackground
 MediaplayerActivity.checkFavorite : DBReader.getFeedItem
 ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
 ItemlistFragment.loadItems : .loadData
 2019-04-06 13:43:11 -07:00
orionlee
0472bb9237 #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull 
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.

Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
 2019-04-06 13:43:11 -07:00
orionlee
670fc124eb #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull 
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.

Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
 2019-04-06 13:43:11 -07:00
H. Lehmann
5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145 
Bulk remove from queue
 2019-04-06 21:45:55 +02:00
H. Lehmann
31194e02a5
Merge pull request #3093 from AntennaPod/bugfix/3084-queue-undo-single 
Create new adapter to show single item after undo
 2019-04-06 21:32:36 +02:00
ByteHamster
74fdabba69 Show single item after undo in EpisodesFragment 2019-04-06 21:32:03 +02:00
orionlee
cb14fd930f refactor - rename string resource name remove_episode_lable , which was ambiguous with typos, to delete_episode_label 
- non-default string resources to be handled by Transifex
 2019-04-06 11:27:20 -07:00
orionlee
075547947e tweak - batch edit UI - support longer action label 2019-04-06 11:15:35 -07:00
orionlee
3bf880e34a remove comment to reduce mental work per review feedback 2019-04-06 11:15:35 -07:00
orionlee
86bf3ef3e0 remove outdated comment - support for vector drawables for pre Android 5 devices is here to stay. 2019-04-06 11:15:34 -07:00
orionlee
0204c1cebd tweak - bulk edit UI - remove hiding FAB during scroll per review feedback 2019-04-06 11:15:34 -07:00
orionlee
3311b4371e tweak - bulk edit UI - use Snackbar for selection message 
- to be consistent with the action message in previous commit.
 2019-04-06 11:15:34 -07:00
orionlee
cc43af110a tweak - bulk edit UI - show a message after an action is applied. 2019-04-06 11:15:14 -07:00
orionlee
46f7805a96 refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without custom codes. 2019-04-06 11:12:34 -07:00
Martin Fietz
6c3033409d Create new adapter to show single item after undo 2019-04-06 16:28:07 +02:00
orionlee
b3fbf0b4aa refactor - UI - remove the old (and now used) select all / none /intermediate icons 2019-04-04 14:05:51 -07:00
orionlee
836334798d refactor - UI - make OPML import screen use the new select all / none icons as well (so that only single set of icons are needed) 2019-04-04 13:58:50 -07:00
orionlee
d186309066 bulk edit - UI - new select all / none icons, based on 
standard Material icons.
 2019-04-04 13:50:55 -07:00
orionlee
dfe2241b4c bulk remove episodes from queue - UI - icon for dark themes. 2019-04-04 13:12:09 -07:00
Martin Fietz
4797d3ae56
Merge pull request #3086 from ByteHamster/fix-double-slash-url 
Specifying base url
 2019-04-04 19:06:34 +02:00
H. Lehmann
643173de14
Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716 
Fix phantom service notification
 2019-04-04 11:59:30 +02:00
H. Lehmann
f2d103736d
Merge pull request #3085 from ByteHamster/new-items-count 
Respect 'keep updated' for new items counter
 2019-04-04 01:16:26 +02:00
orionlee
b683d33bcb bulk edit - refactor - reorder method parameter for DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API. 2019-04-03 14:21:35 -07:00
orionlee
bcaba92851 bulk edit - refactor - factorize common codes in binding action to its UI and actual logic. 2019-04-03 14:15:05 -07:00
orionlee
1052b393d2 bulk edit - refactor - rename menu ids, to be consistent with single edit counterparts 2019-04-03 13:40:55 -07:00
orionlee
a1d718a59a bulk edit - refactor - rename internal constant flags so that the names are consistent 2019-04-03 13:31:32 -07:00
orionlee
4322e8646f bulk edit - UI tweak - rename "Remove Episode" to "Delete Episode", to be consistent with other UIs 2019-04-03 13:27:31 -07:00
ByteHamster
ce013bb225 Specifying base url 
Fixes <a href="//example.com"> links
 2019-04-03 18:53:11 +02:00
ByteHamster
46510c808a Respect 'keep updated' for new items counter 2019-04-03 18:11:55 +02:00
H. Lehmann
7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates 
Mobile updates: Allow images
 2019-04-03 17:43:53 +02:00
H. Lehmann
b6e50c61d6
Merge pull request #3060 from jatinkumarg/issue-3052 
Added empty views to the PlayBack History, Queue,and Downloads
 2019-04-03 17:42:09 +02:00
ByteHamster
788e75515a Review changes 2019-04-03 17:29:44 +02:00
orionlee
48cf33d7da bulk edit - no longer defaulted to check all 2019-04-02 17:34:48 -07:00
orionlee
3768dfb0ff bulk edit - "N selected" UI logic 2019-04-02 17:34:05 -07:00
orionlee
b8bb908b67 fix typo in comments 2019-04-02 16:56:22 -07:00
orionlee
364c9a308d bulk remove from queue - backend - implement the new API 2019-04-02 15:59:27 -07:00
orionlee
70287a740e bulk remove from queue - backend - refactor existing logic to support bulk remove 2019-04-02 14:59:12 -07:00
Jatin Kumar
f6370cc2b9 Renamed text view ids and added tools namespace 2019-04-02 17:36:27 -04:00
orionlee
7d78b88a1c bulk remove from queue - frontend logic, with a stub backend. 2019-04-02 14:11:22 -07:00
orionlee
acbb1cf5e2 document android:elevation API compatibility 2019-04-02 13:59:54 -07:00
orionlee
9925830fff batch edit - replace the bottom button UI with FAB Speed Dial (no new actions yet) 2019-04-02 13:52:34 -07:00
orionlee
9f854fbd3b fix speed dial buttons order 2019-04-02 11:47:57 -07:00
orionlee
53e2511642 ensure speed dials clickable (for pre-Android 5 devices) 2019-04-02 11:47:57 -07:00
orionlee
4918a743a7 stub speed action action listener 2019-04-02 11:47:57 -07:00
orionlee
f7fa0836ea make speed dials scrollable, so that they work in landscape / split window mode. 2019-04-02 11:47:57 -07:00
orionlee
737f7571ab UI Prototype for Batch Edit Episodes rework (from #1145) 2019-04-02 11:47:57 -07:00
ByteHamster
6fe171fac9 Use ApOkHttpUrlLoader for all images 
Probably got broken during my Glide update.
When using append or prepend, Glide uses the next one in the chain if ApOkHttpUrlLoader blocks
 2019-04-02 17:41:21 +02:00
ByteHamster
0fda36b9b3 Add preference to allow mobile updates of images 2019-04-02 17:41:15 +02:00