931c670398
Queue context menu refactor - hide Skip Episode (same as pre-refactor behavior)
2019-09-23 03:55:58 -07:00
27ce3c85c4
Queue context menu refactor - move queue menu definition xml reuse the generic one
2019-09-22 15:46:26 -07:00
6845052057
Queue context menu refactor - move queue-specific logic out of generic handler
2019-09-22 15:39:49 -07:00
c4f92881b1
Merge pull request #3437 from orionlee/easier_remove_new_flag_3302
...
Support remove new flag in Podcast screen and Podcast Episode Screen
2019-09-22 23:57:12 +02:00
9573e6b675
#3302 - refactor retire episode screen item context menu (and reuse the common item context menu)
2019-09-22 13:50:52 -07:00
ab7d36f77f
Merge pull request #3434 from orionlee/access_feed_from_player_2929
...
add Open Podcast to player screen
2019-09-22 22:44:48 +02:00
9c8eda170d
#2929 - review feedback: non-null feedItem requirement explicit
2019-09-22 13:28:25 -07:00
0daef525b0
#3302 - support remove new flag in Podcast screen and Podcast Episode Screen.
...
- moved the logic in Episodes Screen (AllEpisodesRecycleAdapter and EpisodesListFragment) to the generic FeedItemMenuHandler
2019-09-22 12:54:09 -07:00
427477b256
#2929 - minor coding style tweaks per review
2019-09-22 11:03:09 -07:00
e18d8f3514
#2929 - refactor common getFeedItem from playable logic in Player
2019-09-21 14:25:50 -07:00
0be47a8d19
#2929 - refactor common "Open Podcast" intent construction
2019-09-21 14:08:48 -07:00
fcb1a180ad
#2929 add Open Podcast to player screen
2019-09-21 13:52:04 -07:00
fec5c2c62b
#2977 fix incorrect label on Podcast Info Screen as well pre review.
2019-09-21 10:36:59 -07:00
39b202ff45
#2977 fix incorrect "share podcast url" label
2019-09-21 10:27:34 -07:00
64f26d0712
Merge pull request #3433 from ByteHamster/bug-report-section
...
Bug report section
2019-09-21 09:08:10 +02:00
c5dba814d2
Merge pull request #3403 from ByteHamster/follow-system-theme
...
Add option to follow system theme
2019-09-20 23:47:31 +02:00
fa3437960b
Merge pull request #3369 from ByteHamster/playback-speed-icon
...
Added playback speed icon
2019-09-20 23:46:59 +02:00
2dce723a8d
Added button to view mailing list
2019-09-20 23:38:13 +02:00
742bbc5c92
Updated FAQ icon and text
2019-09-20 23:30:00 +02:00
b931828736
Renamed crash report to bug report
2019-09-20 23:29:48 +02:00
9609eb6977
Removed link to known issues
2019-09-20 23:17:29 +02:00
de4f782e54
Merge pull request #3414 from ByteHamster/bug-report-screen
...
Added screen that shows crash info
2019-09-20 23:10:31 +02:00
46c8679fe2
Merge branch 'develop' into follow-system-theme
2019-09-20 23:06:56 +02:00
19fc4c1f0d
OPML export: Choose export folder ( #3175 )
2019-09-20 23:03:23 +02:00
c5c9fd78ca
Merge pull request #3413 from ByteHamster/allow-to-view-full-description
...
Showing full description when clicking item on podcast preview screen
2019-09-20 22:55:24 +02:00
1edf415c2d
Showing full description when clicking item on podcast preview screen
2019-09-20 22:51:39 +02:00
aaafd5d715
Merge branch 'develop' into lock-queue
2019-09-20 22:09:57 +02:00
569ee7cfdc
Merge pull request #3421 from ByteHamster/removed-unused-resources
...
Removed unused resources
2019-09-20 22:08:01 +02:00
ee02dc40fc
Merge pull request #3424 from ByteHamster/preferences-apply
...
Calling apply() on preferences edit
2019-09-20 22:06:19 +02:00
d394996970
Merge pull request #3425 from ByteHamster/cleanup
...
Removed unused code
2019-09-20 22:05:39 +02:00
f9e7e9aeb6
Bumped version to 1.7.3
2019-09-20 19:58:01 +02:00
e89f173326
Setting title
2019-09-16 00:11:33 +02:00
f17737e987
Added card flip animation to feed info fragment
2019-09-16 00:09:10 +02:00
26e47b9efd
Converted FeedInfo Activity to fragment
2019-09-15 23:48:26 +02:00
044fd7e7f9
Ensured playback preference is converted to consistent decimal format
...
Since you can't be sure floats compare equal to one another, the
preference list would not highlight certain playback values when they
were selected.
2019-09-15 21:57:37 +02:00
79c94112ef
Removed unused code
2019-09-14 21:14:16 +02:00
9cbb8d07dd
Removed comments
2019-09-14 20:56:33 +02:00
9a716ba4ac
Calling apply() on preferences edit
2019-09-14 20:52:27 +02:00
b805b41dd6
Using a single notification icon
2019-09-14 18:35:14 +02:00
d746121a9b
Included Media playback speed into controller getter
2019-09-14 00:13:19 +02:00
60eb41048f
Converted playback speed in media preferences to a float instead of String
2019-09-14 00:09:24 +02:00
684213c291
Moved logic for selecting playback speed entirely to UserPreferences
2019-09-13 23:53:42 +02:00
d0f19a2b14
Inlined getFeedPlaybackSpeed method on FeedItem
2019-09-13 23:27:55 +02:00
4990733477
Bumped version to 1.7.3-RC7
2019-09-13 22:26:22 +02:00
02a86b2dd2
Merge pull request #3420 from ByteHamster/media-player-default
...
Ensure that ExoPlayer is set
2019-09-13 22:25:04 +02:00
1fe451b9bb
Merge pull request #3419 from ByteHamster/crash-fixes
...
Fixed crash when controller is null
2019-09-13 22:24:44 +02:00
9ed3e54d9c
Ensure that ExoPlayer is set
2019-09-13 22:15:37 +02:00
46639c2a91
Fixed crash when controller is null
2019-09-13 22:10:59 +02:00
a91d44e787
Respect media speed for videos
2019-09-13 00:31:09 +02:00
4746b16b12
Changed type of media last playback speed to float from string
...
Also sets default to "magic" -1 value
2019-09-13 00:31:09 +02:00
00c1e7a3d3
Replaced for loop array copy with System.arraycopy calls
2019-09-12 23:49:32 +02:00
e7df195d3a
Formatted settings xml and moved setting one step down
2019-09-12 23:49:17 +02:00
7cc602a078
Set a descriptive summary on the per-feed playback speed setting
2019-09-12 11:06:05 +02:00
6b1a7a9162
Fixed playback speed issues when switching to next media
...
Fixes some issues related to the playback speed when playback was
completed or playback was paused and the app went away for awhile.
Now a media item which is "in progress" will remember its playback
speed so that it can be restored properly. The per-feed-media speed is
cleared once playback finishes, either by reaching the end or by the
user starting to play something different.
2019-09-12 10:57:16 +02:00
4054c330ac
Added per-feed playback speed setting
...
Fixes #375
2019-09-12 00:50:07 +02:00
5f01e5045a
Added screen that shows crash info
2019-09-11 23:43:05 +02:00
facc5dccf5
Added warning when locking queue
2019-09-11 22:33:16 +02:00
1f2511ddd9
Unlocking queue on next update
2019-09-11 22:09:18 +02:00
ee737d5d88
Merge pull request #3405 from ByteHamster/disable-fast-scroll
...
Disabled fast scroll
2019-09-11 22:00:27 +02:00
20d04c41f1
Cover and text are selectable. Show this on click
2019-09-11 17:04:25 +02:00
03f4e3eb65
Revert "Moved feed settings button away from scroll bar"
...
This reverts commit 15accaeb07
2019-09-11 13:31:54 +02:00
c012ac987e
Revert "Added fast scroll to item list"
...
This reverts commit b147b3c07a
2019-09-11 13:31:32 +02:00
ada0101b07
Bumped version to 1.7.3-RC6
2019-09-11 00:06:23 +02:00
eedd3ce755
Merge pull request #3399 from ByteHamster/remove-unused-color
...
Removed unused color resource
2019-09-10 23:57:53 +02:00
c4c1780da4
Add option to follow system theme
2019-09-10 23:43:01 +02:00
15accaeb07
Moved feed settings button away from scroll bar
2019-09-10 13:50:38 +02:00
bb72636c68
Removed unused color resource
2019-09-09 19:31:28 +02:00
6b79f740b2
Fixed crash when clicking keep sorted on empty queue
2019-09-09 17:59:35 +02:00
6dfff544e4
Added queue test
2019-09-09 17:58:10 +02:00
a6e131a542
Bumped version to 1.7.3-RC5
2019-09-06 08:10:26 +02:00
92e3da28bf
Bumped version to 1.7.3-RC4
2019-09-04 23:52:32 +02:00
efc1a54616
Merge pull request #3384 from orionlee/update_faq_link_to_https_3380
...
update FAQ link to https
2019-09-04 21:12:16 +02:00
755678f540
#3378 Add link to Privacy Policy
2019-09-04 10:44:19 -07:00
6b676010bb
#3380 update FAQ link to https
2019-09-04 10:30:34 -07:00
1e6b803182
Merge pull request #3377 from ByteHamster/combined-search
...
Disabled gpodnet in combined search
2019-09-03 23:32:37 +02:00
4497c952a9
#3374 batch edit fab: avoid call show repeatedly for potential complication per review
2019-09-03 14:22:23 -07:00
76cc31749a
Disabled gpodnet in combined search
2019-09-03 22:33:03 +02:00
695698dbec
#3373 fix batch edit deselect all text label
2019-09-03 12:09:29 -07:00
cbe61a6815
#3374 fix batch edit FAB overlay remains when deselect all
2019-09-03 11:50:23 -07:00
0ae092be3a
Merge pull request #3366 from ByteHamster/add-feed-improvements
...
Add feed improvements
2019-09-03 19:14:17 +02:00
87a1f5c2f4
Merge pull request #3365 from ByteHamster/batch-edit-fab
...
Batch edit screen FAB
2019-09-03 19:09:50 +02:00
79fddbcc83
Updated font size
2019-09-03 13:27:37 +02:00
11e68419f0
Added playback speed icon
2019-09-02 14:57:30 +02:00
4f9cde8fc7
Fixed playback speed button not cycling through options
2019-09-02 13:57:07 +02:00
a08105df2b
Allow to press enter to search
2019-09-02 00:15:54 +02:00
8b07cd9052
Prevent EditText getting focus and showing keyboard on startup on old Android versions
2019-09-02 00:15:28 +02:00
be364c2a2d
Fixed episodes getting displayed multiple times in multi window
2019-09-01 23:58:36 +02:00
e1b37462f2
Fixed FAB on a few Android versions
2019-09-01 23:57:38 +02:00
14936852d4
Bumped version to 1.7.3-RC3
2019-09-01 13:41:15 +02:00
2e0c8d1bab
More test cleanup
2019-09-01 13:40:20 +02:00
8e0e9cc4cb
Merge pull request #3359 from orionlee/fabspeeddial_attribution
...
FAB SpeedDial - add attribution in about screen
2019-09-01 10:00:11 +02:00
9fb280c2eb
FAB SpeedDial - add attribution in about screen
2019-08-31 16:54:36 -07:00
4cc0d01d98
Merge pull request #3358 from orionlee/fix_fabspeeddial_lint_error
...
Make the incorrect :app:lintVitalRelease error go away.
2019-09-01 01:37:29 +02:00
09297800e7
make the incorrect :app:lintVitalRelease error go away.
...
(The base named dimen comes from fab speeddial library, thus it is not actually missing)
2019-08-31 16:27:38 -07:00
6b685f77df
Use the updated API introduced in PR #3322
2019-08-31 14:31:28 -07:00
79199eec09
Merge pull request #3353 from ByteHamster/searchview
...
Collapse search view
2019-08-31 13:52:48 +02:00
be6c8c70b4
Added fast scroll to episodes fragment
2019-08-31 01:10:44 +02:00
b147b3c07a
Added fast scroll to item list
2019-08-31 00:56:21 +02:00
0333b2cecf
Collapse search view
2019-08-30 23:22:40 +02:00
8a3e4f8765
Merge pull request #3351 from ByteHamster/lazy-load-episodes
...
More episodes on all episodes
2019-08-30 15:10:45 +02:00
32937a842d
Moved options menu handling to child classes
2019-08-30 15:10:00 +02:00
862e86850f
Extracted episodes fragment
2019-08-30 15:10:00 +02:00
c99fd0f520
Renamed ItemlistFragment to FeedItemlistFragment
2019-08-30 15:10:00 +02:00
2ba91f4f33
More episodes on all episodes
2019-08-30 15:09:54 +02:00
e58dbfbd15
Allow to delete currently playing media
2019-08-30 14:26:57 +02:00
46af0e0c36
Merge pull request #3349 from ByteHamster/no-crash-after-dispose
...
Do not crash on undeliverable InterruptedException
2019-08-30 13:44:13 +02:00
af8dc2c9b9
Do not crash on undeliverable InterruptedException
2019-08-30 13:35:30 +02:00
17d6d7fbbf
Merge pull request #3345 from ByteHamster/queue-move
...
Disabled long-press drag
2019-08-30 13:10:39 +02:00
b0f97fdd89
Merge pull request #3348 from ByteHamster/translate-preference-search
...
Extracted preference search string resources
2019-08-30 13:03:21 +02:00
9ae179adce
Merge pull request #3343 from ByteHamster/video-playback-speed
...
Allow to adjust video playback speed
2019-08-30 13:03:06 +02:00
4e80388380
Extracted preference search string resources
2019-08-30 11:38:56 +02:00
6dbddb78e2
Disabled long-press drag
2019-08-30 02:14:47 +02:00
c14c223e2f
Allow different playback speed for video
2019-08-30 01:56:52 +02:00
a445942cec
Extracted playback controls to new class
2019-08-30 01:09:18 +02:00
7f05e358d1
Fixed white on white icon
2019-08-30 00:47:29 +02:00
f35286f1dc
Bumped version to 1.7.3-RC2
2019-08-28 20:24:39 +02:00
4a2feb3721
Fixed upgrading preferences
...
Needs to use the original storage location that `UpdateManager` used,
which was removed in e2cf363cc4
2019-08-28 20:22:13 +02:00
caf6f097a7
Fixed crash on Android 4.3
...
Apparently, applying `android:attr/textColorPrimary` to a TextView
works, while using it to tint an ImageView makes the app crash.
2019-08-28 19:58:23 +02:00
44c60620a6
Bumped version to 1.7.3-RC1
2019-08-28 13:11:56 +02:00
82997f4e9e
Updated release notes
2019-08-23 17:41:56 +02:00
9a1d5fd855
Merge pull request #3331 from ByteHamster/add-feed-page-spacing
...
Updated spacing of add feed page
2019-08-23 17:39:06 +02:00
be957e53b3
Implemented filter function for "All Episodes" list ( #3321 )
2019-08-23 17:38:42 +02:00
79465983d3
Updated spacing of add feed page
2019-08-23 17:33:32 +02:00
91b171acb3
Making Google happy about the translations
...
Removed translations that Google does not support
Added titles
Removed translations which do not have both full and short description
2019-08-20 23:07:05 +02:00
43248271e1
Updated Gradle publisher
2019-08-20 22:17:56 +02:00
99e9a0b793
Pulled play store metadata from Transifex
2019-08-20 21:50:37 +02:00
44b9057852
Added Google Play icon
2019-08-20 19:51:39 +02:00
f099092af0
Show add feed fragment on first launch
2019-08-20 18:03:41 +02:00
ed63f41401
Merge pull request #3328 from ByteHamster/tests-espresso
...
Converted NavigationDrawerTest to Espresso
2019-08-18 15:03:34 +02:00
0e42c5d092
Converted NavigationDrawerTest to Espresso
2019-08-18 14:58:20 +02:00
4b299fef41
Allow to open speed settings with ExoPlayer
2019-08-18 12:50:30 +02:00
795952711e
Updated changelog
2019-08-16 15:33:39 +02:00
9fc97010f9
Merge pull request #3320 from gaul/static-class
...
Make classes static where possible
2019-08-13 09:04:02 +02:00
94bee6fb74
Make classes static where possible
...
Found via error-prone.
2019-08-12 21:41:01 -07:00
50e71545f7
Sort automatic download wifi names ignoring case
...
When a user has many wifi networks it can be difficult to remember if
a given network has upper- or lower-case.
2019-08-12 21:25:38 -07:00
0680dfb047
Merge pull request #3317 from ByteHamster/tests
...
Tests
2019-08-11 21:33:27 +02:00
c29b0ce8c7
Fixed app integration tests
2019-08-11 21:21:28 +02:00
1315c9e20b
Merge branch 'develop' into make_multidex_on_debug_build_only
2019-08-11 14:57:44 +02:00
ce64c412ac
Merge pull request #3316 from ByteHamster/online-feed-view
...
Updated OnlineFeedView layout
2019-08-11 14:48:20 +02:00
4e79ddb51b
Merge pull request #3315 from damoasda/Queue-Sort-Order2
...
Queue sort order - with keep sorted checkbox
2019-08-11 14:48:01 +02:00
f1612995a2
Updated OnlineFeedView layout
2019-08-11 14:18:41 +02:00
c4399de8cb
Changes due to feedback in pull request #3315
2019-08-11 14:07:45 +02:00
fe9f0c8e7e
Changes due to feedback in pull request #3315
2019-08-11 11:08:19 +02:00
3ceb99d2e2
Merge pull request #3303 from rezanejati/develop
...
Add socks proxy in network settings
2019-08-11 10:19:52 +02:00
c47ceb7f73
Improve code style
2019-08-11 09:11:11 +04:30
906142cbf3
Queue: Keep sorted #1556
2019-08-10 21:59:19 +02:00
5bc15a73ad
Queue: Keep sorted #1556
2019-08-10 21:28:33 +02:00
be676c6faa
Queue: Keep sorted #1556
2019-08-10 21:25:59 +02:00
867a2812e8
Merge pull request #3292 from ByteHamster/mobile-updates-setting
...
Mobile updates setting
2019-08-10 18:37:56 +02:00
9ffd9a9848
Merge pull request #3283 from andersonvom/3273-renable-linting
...
Re-enable deprecation and serial linting
2019-08-10 17:45:18 +02:00
6f7ec2011f
Cleanup
2019-08-10 17:23:31 +02:00
2f1ebbbf74
Add brackets for condition - add new line in ProxyConfig
2019-08-07 09:11:55 +04:30
c968bfd5cc
Show PR.SOCKS on Android API >= 24
2019-08-06 09:27:16 +04:30
f3fec57a18
Add socks proxy in network settings
2019-08-05 16:39:05 +04:30
51f348caa3
Merge branch 'develop' into Queue-Sort-Order
2019-08-04 09:59:32 +02:00
be8e7c32f1
Display notification when trying to stream
2019-07-25 01:08:16 +02:00
be42cc0c71
Refactored mobile updates setting
2019-07-25 00:38:00 +02:00
60866a1c79
Merge pull request #3286 from ByteHamster/batch-edit-queue
...
Added batch edit to queue
2019-07-23 23:01:49 +02:00
22ac88e2df
Merge pull request #3287 from ByteHamster/add-feed-page-redesign
...
Added error message, do not jump after loading completed
2019-07-23 23:01:33 +02:00
cfe05e3038
Added batch edit to queue
2019-07-23 22:43:18 +02:00
f7251af8be
Merge pull request #3284 from ByteHamster/default-exoplayer
...
Make ExoPlayer the default player
2019-07-23 22:11:48 +02:00
8b9c31ccf0
Do not set PlaybackService to null while still updating widget
2019-07-23 21:27:18 +02:00
e2cf363cc4
Make ExoPlayer the default player
2019-07-23 21:22:27 +02:00
4551b1fbc9
Fixed crash when context is null
...
From Google Play console
2019-07-23 20:53:40 +02:00
97acd6c960
Added error message, do not jump after loading completed
2019-07-23 16:50:50 +02:00
b88ab959eb
Cleanup
2019-07-23 16:30:12 +02:00
33ba9baa35
Added quick discovery fragment
2019-07-22 22:09:39 +02:00
c7f92b7c71
Redesigned add feed page
2019-07-22 20:52:28 +02:00
eaa1527fac
Merge pull request #3278 from ByteHamster/empty-view
...
Updated empty views
2019-07-22 19:05:39 +02:00
865cb65470
Merge pull request #3240 from ByteHamster/combined-search
...
WIP: Combined podcast search
2019-07-22 19:05:21 +02:00
613703ba95
Removed unused imports
2019-07-22 19:02:36 +02:00
a5df1c075d
Targeting Android API 28
2019-07-22 18:50:56 +02:00
94ba9dfd46
Using EmptyViewHandler for chapters fragment
2019-07-22 12:49:16 +02:00
a409f439ac
Updated appearance of empty view
2019-07-22 12:49:11 +02:00
28c7858387
Add serialVersionUID to all exceptions
...
For more info, see [1].
[1]: https://stackoverflow.com/questions/146715/use-the-serialversionuid-or-suppress-warnings
2019-07-21 23:37:01 -04:00
fb294315a9
Merge pull request #3272 from andersonvom/3225-remove-new-flag
...
Reword "Mark as seen" to "Remove 'new' flag"
2019-07-14 17:47:50 +02:00
c38d7bad6b
Reword "Mark as seen" to "Remove 'new' flag"
...
This avoids the confusion between "Mark as seen" and "Mark as played".
Closes : #3225
2019-07-14 11:16:52 -04:00
539802ba04
Merge pull request #3267 from libliboom/develop
...
Removed screenOrientation attributes in manifest
2019-07-14 14:40:33 +02:00
53073c958c
add android:imeOptions="flagNoFullscreen" attribute in EditText
2019-07-14 21:14:54 +09:00
329750ca01
add android:imeOptions="flagNoFullscreen" attribute in EditText
2019-07-14 21:09:56 +09:00
3b4fd3f414
Merge pull request #3271 from ByteHamster/fix-batch-edit
...
Fixed batch edit items grayed out on API 23 and 24
2019-07-14 10:30:10 +02:00
339569421a
add android:imeOptions="flagNoFullscreen" attribute in EditText
2019-07-14 01:48:50 +09:00
5e1ab265b5
Fixed batch edit items grayed out on API 23 and 24
2019-07-13 17:47:27 +02:00
9fe4fed874
Merge pull request #3233 from jas14/pad-scrubber
...
Pad scrubber on large devices
2019-07-13 17:01:36 +02:00
ed338edea4
Merge pull request #3266 from ByteHamster/remove-flattr
...
Removed Flattr support
2019-07-13 15:04:05 +02:00
f1d5c00f3b
Resolves #3235 . Refer to the changes.
...
- Remove android:screenOrientation="portrait" for rotating.
- Remove override onConfigurationChanged function that does nothing.
2019-07-13 20:14:16 +09:00
c8fc1f90e0
Merge pull request #3265 from ByteHamster/storage-label
...
Added total space to storage select dialog
2019-07-12 22:51:11 +02:00
641ee60cbf
Removed Flattr support
2019-07-12 19:28:22 +02:00
b5b2bccda4
Added total space to storage select dialog
2019-07-12 18:59:43 +02:00
cbf3a2102f
Simplified encoding query
2019-07-12 15:28:33 +02:00
3962fdd6f8
Added CombinedSearcher for podcasts
2019-07-12 15:24:06 +02:00
eda23ca4bb
Updated SearchPreference
2019-07-12 14:35:38 +02:00
9f6529d4bc
Merge branch 'develop' into 2747-completed-downloads-update
2019-07-11 12:43:30 +02:00
e78e4d5656
Merge pull request #3261 from archibishop/fix-removing-wrong-favourite-message
...
Fix removing wrong favourite message
2019-07-11 12:42:14 +02:00
782fce76d0
Fix removing wrong favoruite message
2019-07-10 12:29:48 +03:00
9b7a61471d
Queue: Keep sorted #1556
2019-07-09 08:55:46 +02:00
9e72780bc8
Merge pull request #3254 from jas14/feed-rotation-crash-3245
...
New ViewModel for loading feed preferences across lifecycle
2019-07-06 15:10:57 +02:00
ce649ec087
Merge pull request #3249 from archibishop/imagecover-playpause-fuctionality
...
Extend play/pause functionality to Image Cover
2019-07-06 15:00:30 +02:00
e887996053
Extend play/pause functionality to Image Cover
2019-07-02 21:58:30 +03:00
3b6cfb711f
New ViewModel for loading feed preferences across lifecycle
2019-07-02 18:33:32 +02:00
4bc8821845
Increase scrubber padding for large devices
2019-07-01 12:31:14 +02:00
2d91292937
Combined podcast search
2019-06-26 08:27:19 +02:00
7f1f725bfe
validate username for characters not accepted.
2019-06-26 04:50:18 +03:00
8e95ed75ab
Fix recycler and empty view hide/show logic
...
The `emptyViewHandler` already handles hiding and showing both the empty
view and the recycler view on data changes, so this commit removes this
part of the logic from the episodes fragment.
It also hides the empty view right after creating the recycle adapter
for the first time (when the fragment is created) to prevent the
progress bar and the empty view from being displayed at the same time.
`createRecycleAdapter()` signature was changed to make it explicit that
it depends on both the `recyclerView` and `emptyViewHandler`. Similarly,
`onFragmentLoaded()`, since it also depends on the new data that gets
loaded.
2019-06-24 09:32:06 -04:00
bb8b1fc58f
Reorganize subscription fragment lifecycle
2019-06-24 08:38:04 -04:00
fd07a10f03
Reorganize search fragment lifecycle
2019-06-24 08:38:04 -04:00
5e5dfa5584
Reorganize playback history lifecycle
2019-06-24 08:38:04 -04:00
90d5208402
Reorganize item fragments lifecycle
2019-06-24 08:38:04 -04:00
e22adbe451
Reorganize DownloadLogFragment lifecycle
2019-06-24 08:38:04 -04:00
bbcec5d0aa
Reorganize Episode Fragments lifecycle
...
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
aabe370db3
Fix whitespace
2019-06-24 08:38:04 -04:00
486ceed0ef
Reorganize downloads fragments lifecycle
...
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747 ), so this registers/unregisters on view create/destroy.
Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.
There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.
Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.
[1]: https://developer.android.com/guide/components/fragments
Closes : #2747
2019-06-24 08:38:04 -04:00
a556183d60
Extract methods from onViewCreated
2019-06-24 08:38:04 -04:00
69f116904d
Fix IDE warnings
...
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
56dc16802a
Fix whitespace
2019-06-24 08:38:04 -04:00
f3cd43b972
Cleanup
2019-06-14 10:45:45 +02:00
5a7cbdfaca
Added authentication and episode filter dialogs
2019-06-14 10:34:55 +02:00
8f11f8a271
Updated feed settings screen
2019-06-14 00:38:34 +02:00
8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
...
Restructured preferences code
2019-06-13 23:38:18 +02:00
85ef61f4ef
Removed deleted receiver from manifest
2019-06-13 23:18:12 +02:00
99acff3b8f
Restructured preferences code
2019-06-13 23:12:41 +02:00
3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
...
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
ee1809001d
don't override summary value in PreferenceController
2019-06-04 23:58:17 +02:00
405db1f169
Merge pull request #3164 from ByteHamster/work-manager
...
Work manager
2019-06-03 11:59:23 +02:00
8dc4c9ff56
Upgrade preferences independently from database
2019-06-03 11:56:44 +02:00
605e02fa70
add pref_episode_cache_summary
2019-06-01 18:16:47 +02:00
f05132a716
Allow to disable auto updates
2019-05-28 18:11:12 +02:00
4443d629fc
Merge branch 'develop' into work-manager
2019-05-28 17:56:05 +02:00
ce8adc4b26
Use annotation processor for EventBus
2019-05-28 17:26:09 +02:00
d81cb2ff39
Merge pull request #3043 from CedricCabessa/remaining_time_playback_speed
...
Fixes #2197 : Remaining time playback speed
2019-05-28 15:52:54 +02:00
60771673dc
rename category title to match with "playback speeds"
...
also rename the key to be consistent with the content
2019-05-28 12:03:28 +02:00
f563fe48b5
Merge pull request #3207 from ByteHamster/sort-description
...
Sort options: 'old to new' instead of 'ascending'
2019-05-27 22:54:21 +02:00
2450b0817b
Replace action/callback utils with ItemActionButton
...
This just replaces all previous usages of `ActionButtonUtils` and
`DefaultActionButtonCallback` with the newly created `ItemActionButton`
class.
2019-05-27 16:06:55 -04:00
1d64057fd4
Extract action button utils/callback into classes
...
This splits the logic in `ActionButtonUtils` and
`DefaultActionButtonCallback` into multiple specialized classes to
reduce duplication figuring out which button/action to use while at the
same time making each individual button to have a single responsability.
2019-05-27 16:01:54 -04:00
81a3d756eb
Sort options: 'old to new' instead of 'ascending'
2019-05-27 21:09:55 +02:00
c327fd59c9
Merge pull request #3206 from ByteHamster/clear-text-traffic
...
Clear text traffic in shownotes
2019-05-27 19:24:46 +02:00
2d5995d1a5
Allow mixed content
2019-05-27 13:06:52 +02:00
5ea11ca748
Allow cleartext traffic
2019-05-27 12:48:49 +02:00
46103883ce
Merge pull request #3191 from jas14/stricter-db-import
...
Check SQLite3 magic bytes before import
2019-05-27 12:44:44 +02:00
35770dc2e2
Merge pull request #3198 from jas14/fix-3196
...
Avoid error delivery to disposed Disposable
2019-05-27 12:41:33 +02:00
382860d65e
Avoid error delivery to disposed Disposable
2019-05-23 08:48:34 -04:00
4f3fa6246e
Added test for shutdown/widget updater race in PSTM
2019-05-21 18:36:04 -04:00
09e138b51f
Check SQLite3 magic bytes before import
2019-05-20 17:41:20 -04:00
c98a7c0c38
Merge pull request #3136 from andersonvom/develop
...
Add progress bar with space information to data folder selection dialog
2019-05-19 19:38:37 +02:00
e4a17562cb
Improve space wording on choose data folder dialog
...
This makes it clear that the number refers to the **free** space left on
the device, as opposed to the total space available.
2019-05-19 13:25:27 -04:00
9396d41dcc
Add space usage bar to data folder dialog
...
This displays a progress bar with the amount of used/free space in each
storage location to make it easier to identify storage devices. This is
particularly useful for devices that use non-standard names.
Reference: #3049
2019-05-19 13:25:27 -04:00
683f7e46a2
Extract data folder dialog layout
...
This is in preparation to add a progress bar displaying the amount of
used/free space in the dialog (#3049 ). Since we'll need a custom view to
do it, this extracts the layout beforehand.
2019-05-19 13:25:27 -04:00
31adff0dcc
Extract methods in ChooseDataFolderDialog
...
This makes the main `showDialog()` method a bit shorter by extracting
behavior into shorter methods.
2019-05-19 13:25:27 -04:00
b2ea26d489
No longer try to remove log
2019-05-19 19:23:33 +02:00
a8b05c3c66
Merge pull request #3165 from ByteHamster/opml-import-mismatch
...
Removed opml pick action
2019-05-19 19:22:14 +02:00
orionlee
H. Lehmann
ByteHamster
William Seemann
Jonas Kalderstam
Jan-Peter von Hunnius
Andrew Gaul
damoasda
rezanejati
Anderson Mesquita
bhlee
Wagubi Brian
Joe Stein
Unknown
Cédric Cabessa
Martin Fietz