65abd2bbb4
Prevent actionbar items from moving when searching
...
Previously, when the user clicked the search button, the context menu
would be hidden and the refresh button would move way too close to the
edge of the screen.
This makes sure that when a user clicks the search button on the
episodes screen, the remaining actionbar items (refresh and context
menu) stay where they are.
2019-05-11 14:20:57 -04:00
c9b17c14f1
Bumped version to 1.7.2-RC5
2019-05-08 19:55:00 +02:00
96f582a4d4
Merge pull request #3166 from ByteHamster/fix-some-tests
...
Fixed some integration tests
2019-05-08 19:30:04 +02:00
bf6f6376db
Do not deadlock
...
The Android internal media player blocks its `start()` call until the
seek listener completes. The seek listener is called on the main thread
even though `start()` is called on the executor. This makes the main
thread wait for the lock and the executor (which has the lock) wait for the
main thread to finish the call to the listener.
2019-05-08 19:18:44 +02:00
e464569712
Fixed NPE
2019-05-08 15:37:53 +02:00
c6e81391b2
Updated translations
2019-05-07 15:56:29 +02:00
7ce4685447
Bumped version to 1.7.2-RC4
2019-05-07 15:54:36 +02:00
86129a9686
Merge pull request #3167 from ByteHamster/threading
...
Fixed threading bugs in Sonic
2019-05-07 15:47:40 +02:00
dc24f5f163
Updated release notes
2019-05-07 15:44:17 +02:00
5a99580985
Do not deadlock on seek when using Sonic
...
Callbacks are called on the thread that created the MediaPlayer.
For Sonic, this is the executor. For ExoPlayer, this is the main thread.
When calling executor.submit, every thread waiting for the runnable to
complete gets blocked.
Because the callback is called in the thread that created the player,
we can simply remove the call to executor.submit and still be sure
that a background thread is used.
2019-05-07 15:32:48 +02:00
c16bbdfc96
Do not block when using Sonic+Sleep timer
2019-05-07 14:58:34 +02:00
ae3cef3bd2
Fixed some integration tests
2019-05-06 23:52:02 +02:00
d7768d33e2
Merge pull request #3161 from andersonvom/2982-fix-icon-padding
...
Fix padding when count is zero and error happened
2019-05-06 16:33:32 +02:00
af31464cd5
Fix padding when count is zero and error happened
...
When we're not able to get the episode count for a podcast and updating
the feed fails, the error icon shown in the navbar is too close to the
right/end border of the nav drawer.
This fixes this padding.
Closes : #2982
2019-05-04 18:14:28 -04:00
0107cf22cc
Merge pull request #3155 from ByteHamster/empty-view-simplification
...
Simplify empty view handling on recycler views
2019-05-03 12:24:27 +02:00
605475d2ed
Merge pull request #3156 from ByteHamster/crash-episodes-long-press
...
Fixed NPE when selected item is null
2019-05-03 12:23:08 +02:00
2f7314eb2e
Merge pull request #3157 from ByteHamster/add-thread-names
...
Added names for threads
2019-05-03 12:21:13 +02:00
01616dd502
Added names for threads
...
So it is easier to identify problems in bug reports
2019-05-03 12:17:05 +02:00
7f514384fc
Fixed NPE when selected item is null
...
The method is called again with a valid listAdapter automatically
Closes #3154
2019-05-03 11:56:27 +02:00
06c15fd9e6
Simplify empty view handling on recycler views
2019-05-03 11:06:04 +02:00
7a921e0024
Fixed about screen readability in amoled theme ( Closes #3151 )
2019-05-03 10:20:23 +02:00
d67aa6386e
Updated string
...
Closes #3145
2019-05-01 11:02:29 +02:00
954cf87eff
Merge pull request #3147 from ByteHamster/fix-empty-list
...
Fixed empty list not receiving updates
2019-04-30 20:55:12 +02:00
9b91a51df8
Fixed empty list not receiving updates
2019-04-30 18:57:09 +02:00
717b1cb0ad
Merge pull request #3141 from andersonvom/remove-exceptions
...
Fix thrown exceptions when adding/removing podcasts
2019-04-30 18:44:21 +02:00
a2cd8cca73
Return Optional feed when loading feed items
...
RxJava 2.x no longer accepts `null` values and will yield a
`NullPointerException` immediately or as a signal to downstream [1].
This returns an Optional<Feed> instead to avoid errors.
[1]: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#nulls
2019-04-30 06:10:41 -04:00
34d33f796e
Close OkHttp request before making new ones
...
When adding certain podcasts [1], a `LeakedClosableViolation` is thrown
due to the fact that we're reusing the OkHttpClient to make multiple
requests (one to get the iTunes toplist for the user's language, and
another one defaulting to US).
This makes sure that all requests are closed to prevent this exception,
according to OkHttp docs [2].
[1]: https://podcasts.apple.com/us/podcast/stupid-genius-with-emma-chamberlain/id1458568923
[2]: https://github.com/square/okhttp/blob/18f2b5e/okhttp/src/main/java/okhttp3/Call.kt#L32-L40
2019-04-28 09:10:02 -04:00
a4dc3d9e96
Bumped version to RC3
2019-04-28 14:39:01 +02:00
835d1f8cd3
Made null check work
2019-04-28 14:18:47 +02:00
5d124c476a
Fixed sleep timer ANR ( Closes #3139 )
2019-04-27 10:50:13 +02:00
881578ee41
Bumped version to 1.7.2-RC2
2019-04-26 19:12:50 +02:00
8e25f188c5
Fixed crash where recyclerAdapter is null
...
Closes #3138
2019-04-26 19:10:27 +02:00
48ead285b3
Imported store description into new publisher layout
2019-04-26 18:10:56 +02:00
d0cbe158bb
New Play publisher directory layout
2019-04-26 17:58:48 +02:00
309cd20d66
Merge pull request #3134 from ByteHamster/prepare-release
...
Prepare 1.7.2 release
2019-04-26 16:55:12 +02:00
aeef6361d7
Merge pull request #3137 from andersonvom/warning-cleanup
...
Cleanup compiler warnings
2019-04-26 16:54:54 +02:00
57301cf81c
Making sure that publisher releases to alpha first, so we can wait for Pre-Launch-Report
2019-04-26 10:38:34 +02:00
f96c1d5367
Bumped versionCode
2019-04-26 10:37:05 +02:00
fd2424edd4
Cleanup compiler warnings
...
Removes redundant casts and adds generic type to avoid compiler warnings.
2019-04-25 18:45:36 -04:00
0925078770
Translation updates
2019-04-24 23:19:52 +02:00
46f9a9c65b
Added release notes
2019-04-24 23:12:03 +02:00
3b9e34e18e
Merge pull request #3131 from ByteHamster/fix-hiding-ExternalPlayer
...
Hiding ExternalPlayerFragment onStart
2019-04-24 23:05:55 +02:00
92165f9021
Hiding ExternalPlayerFragment onStart
...
If the playback is finished in background, the fragmentLayout is not hidden.
Steps to reproduce (without this commit):
- Start last item in queue
- Leave app using home button
- Finish playback by using notification skip button
- Resume to AntennaPod
- ExternalPlayerFragment is shown (in invalid state) but should be hidden
2019-04-24 22:56:37 +02:00
017a6ab3bc
Merge pull request #2957 from orionlee/bugfix_app_anr_in_auto_feed_update_2956
...
Prevent app crash during some automatic feed update
2019-04-19 12:02:25 +02:00
f4de370f17
Merge pull request #3126 from alimemonzx/develop
...
bugfix #3092 - time left on Queue screen not updated after download c…
2019-04-19 11:58:41 +02:00
f2a777bd06
bugfix #3092 - time left on Queue screen not updated after download completes
2019-04-19 04:34:06 +01:00
a03bf4cfc9
Merge pull request #3122 from ByteHamster/anr-switch-player
...
Made sure that there is not an ANR when switching media player
2019-04-17 20:53:12 +02:00
2fca491f53
Made sure that there is not an ANR when switching media player
2019-04-17 20:52:13 +02:00
09e7f60db8
Merge pull request #3121 from ByteHamster/network-main-thread
...
Fixed NetworkOnMainThreadException
2019-04-16 23:03:56 +02:00
1fe33fb351
Fixed NetworkOnMainThreadException
2019-04-16 22:50:59 +02:00
Anderson Mesquita
ByteHamster
H. Lehmann
Martin Fietz
Ali