8380c18543
Merge pull request #2709 from brad/fix-2359
...
Display cover art for media in the widget
2019-05-28 16:29:43 +02:00
88854ea6ba
Make sure to clear old icon if loading fails
2019-05-28 16:23:46 +02:00
d81cb2ff39
Merge pull request #3043 from CedricCabessa/remaining_time_playback_speed
...
Fixes #2197 : Remaining time playback speed
2019-05-28 15:52:54 +02:00
60771673dc
rename category title to match with "playback speeds"
...
also rename the key to be consistent with the content
2019-05-28 12:03:28 +02:00
f563fe48b5
Merge pull request #3207 from ByteHamster/sort-description
...
Sort options: 'old to new' instead of 'ascending'
2019-05-27 22:54:21 +02:00
81a3d756eb
Sort options: 'old to new' instead of 'ascending'
2019-05-27 21:09:55 +02:00
46103883ce
Merge pull request #3191 from jas14/stricter-db-import
...
Check SQLite3 magic bytes before import
2019-05-27 12:44:44 +02:00
effa17c41d
Fix scheduling tasks on shutdown executor
2019-05-21 18:36:04 -04:00
09e138b51f
Check SQLite3 magic bytes before import
2019-05-20 17:41:20 -04:00
c98a7c0c38
Merge pull request #3136 from andersonvom/develop
...
Add progress bar with space information to data folder selection dialog
2019-05-19 19:38:37 +02:00
e4a17562cb
Improve space wording on choose data folder dialog
...
This makes it clear that the number refers to the **free** space left on
the device, as opposed to the total space available.
2019-05-19 13:25:27 -04:00
9396d41dcc
Add space usage bar to data folder dialog
...
This displays a progress bar with the amount of used/free space in each
storage location to make it easier to identify storage devices. This is
particularly useful for devices that use non-standard names.
Reference: #3049
2019-05-19 13:25:27 -04:00
73744e3d4c
Merge branch 'develop' into eventbus-v3
2019-05-19 18:59:03 +02:00
135df61692
Merge pull request #3159 from andersonvom/3024-itunes-duration-format
...
Handle iTunes single-number duration format
2019-05-19 13:40:20 +02:00
6e29c37360
Merge pull request #3108 from ByteHamster/attr-redeclaration
...
Fixed attr redeclaration
2019-05-19 12:07:03 +02:00
8f93e3b2e2
Merge pull request #3172 from andersonvom/3169-cover-fragment-small-screen
...
Fix cover fragment in small screens
2019-05-19 12:01:45 +02:00
49ef28877d
Enable autodownload over Ethernet
2019-05-18 12:11:39 +02:00
b47f6e8f3c
Moved notification setup to new class
2019-05-17 15:16:22 +02:00
785dff0698
Added logging in cases where service did not know how to handle intent
2019-05-17 14:42:21 +02:00
1f8f2be9ab
Do not try to display notification two times
...
The Thread is interrupted which leads to an empty notification
2019-05-17 14:35:19 +02:00
7c4b98be59
Cherry-Pick: Add a generic java8-like Optional class
...
For use with RxJava2 where null was to be returned (RxJava2 requires non-null).
Cherry-picked from PR #2954
2019-05-17 09:53:51 +02:00
3fca616e30
Revert "Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716"
...
This reverts commit 643173de14f2d103736d
2019-05-17 09:45:22 +02:00
0a1a54d28d
Smart shuffle: spread episodes evenly
...
This reworks the sort algorithm used in smart shuffle so that episodes
are spread out evenly, which avoids episodes bunching up at the bottom
of the queue when one feed has more episodes than others, and avoids
running through feeds with few episodes very quickly.
Signed-off-by: Stephen Kitt <steve@sk2.org>
2019-05-09 18:38:34 +02:00
bf6f6376db
Do not deadlock
...
The Android internal media player blocks its `start()` call until the
seek listener completes. The seek listener is called on the main thread
even though `start()` is called on the executor. This makes the main
thread wait for the lock and the executor (which has the lock) wait for the
main thread to finish the call to the listener.
2019-05-08 19:18:44 +02:00
e9e61776ed
Fix cover fragment in small screens
...
The cover fragment would hide both podcast and episode names in small
screen devices or multi-window mode.
This replaces the deprecated PercentRelativeLayout in favor of a regular
LinearLayout with weights to make sure that each section of the fragment
(podcast title, image, episode name) will have the necessary space in
the screen.
Since PercentRelativeLayout was only being used here, it also removes
the dependencies from the gradle files.
Closes : #3169
2019-05-08 09:48:00 -04:00
e464569712
Fixed NPE
2019-05-08 15:37:53 +02:00
c6e81391b2
Updated translations
2019-05-07 15:56:29 +02:00
5a99580985
Do not deadlock on seek when using Sonic
...
Callbacks are called on the thread that created the MediaPlayer.
For Sonic, this is the executor. For ExoPlayer, this is the main thread.
When calling executor.submit, every thread waiting for the runnable to
complete gets blocked.
Because the callback is called in the thread that created the player,
we can simply remove the call to executor.submit and still be sure
that a background thread is used.
2019-05-07 15:32:48 +02:00
c16bbdfc96
Do not block when using Sonic+Sleep timer
2019-05-07 14:58:34 +02:00
cd5224d01b
Charging constraint is related to auto download only
2019-05-06 23:08:45 +02:00
dbda4a9aa8
Using WorkManager for feed updates
2019-05-06 23:04:19 +02:00
fb3bfa9f80
Handle iTunes single-number duration format
...
Apple says this [1] about the `<itunes:duration>` tag:
If you specify a single number as a value (without colons), Apple
Podcasts displays the value as seconds.
This commit makes it also handle this single-number format.
Closes : #3024
[1]: https://help.apple.com/itc/podcasts_connect/#/itcb54353390
2019-05-05 00:04:06 -04:00
9b41139709
Extract DurationParser
...
This makes it easier to test the logic of parsing duration strings.
References: #3024
2019-05-05 00:04:06 -04:00
a4c852dac0
Extract methods in NSITunes
...
References: #3024
2019-05-04 13:59:05 -04:00
01616dd502
Added names for threads
...
So it is easier to identify problems in bug reports
2019-05-03 12:17:05 +02:00
d67aa6386e
Updated string
...
Closes #3145
2019-05-01 11:02:29 +02:00
cf638a4978
use time converter and pref in MediaPlayer and Widget
2019-04-28 21:03:18 +02:00
6187945e8f
add a time conversion class
...
convert time depending on current playback speed and preferences
2019-04-28 21:03:18 +02:00
743ec1927c
add preference for "Time respects playback speed"
2019-04-28 21:03:18 +02:00
5d124c476a
Fixed sleep timer ANR ( Closes #3139 )
2019-04-27 10:50:13 +02:00
0925078770
Translation updates
2019-04-24 23:19:52 +02:00
017a6ab3bc
Merge pull request #2957 from orionlee/bugfix_app_anr_in_auto_feed_update_2956
...
Prevent app crash during some automatic feed update
2019-04-19 12:02:25 +02:00
a349865af3
use multi-line TextView for "No media playing"
2019-04-18 22:08:49 -07:00
73c39fc3d0
no need to spell out android.view.View
2019-04-18 21:48:33 -07:00
ee6e5ed5d0
space before ( for better style
2019-04-18 21:45:59 -07:00
bf54e0e7c7
avoid "app not responding" errors loading widget image
2019-04-18 21:45:11 -07:00
a60b6efc51
use ic_launcher_foreground for widget when nothing is playing
2019-04-18 21:43:35 -07:00
2fca491f53
Made sure that there is not an ANR when switching media player
2019-04-17 20:52:13 +02:00
1fe33fb351
Fixed NetworkOnMainThreadException
2019-04-16 22:50:59 +02:00
0339ce7bca
Do not set player status before player object is created
2019-04-14 13:56:04 +02:00
28f424e3c1
No locks are needed if everything is executed on main thread
2019-04-14 13:42:32 +02:00
25915453ba
hide widget text when displaying < 3 columns
2019-04-12 17:56:53 -07:00
09f4ebf08a
Let PlaybackController handle listening for service start
2019-04-12 11:39:38 +02:00
7d20baf4f9
Upgraded EventBus to v3
...
Also made sure that register/unregister are called in onStart/onStop
instead of onResume/onPause (prevents possible MultiWindow problems
where updates are not received because activity is not fucused).
2019-04-12 11:32:31 +02:00
3f1e6b5d50
Merge pull request #3106 from ByteHamster/subscriptions-columns
...
Set number of subscription columns
2019-04-12 10:56:26 +02:00
11b085c68b
Fixed attr redeclaration
2019-04-12 10:41:49 +02:00
b4f04f6d6d
Merge pull request #3105 from ByteHamster/style-repetition
...
Reduced repetition in styles.xml
2019-04-12 10:36:06 +02:00
64ddf6ec96
use app_icon_size for layout width on widget components
2019-04-11 22:26:01 -07:00
210afaeb3c
fix widget image glider
2019-04-11 22:25:24 -07:00
cfd0af55c4
Removed nb translation
2019-04-11 21:54:57 +02:00
777d92d4be
Set number of subscription columns
2019-04-11 21:24:51 +02:00
6595f49f22
Reduced repetition in styles.xml
2019-04-11 21:02:45 +02:00
97d08f3b00
Merge pull request #3097 from ByteHamster/exoplayer-main-thread
...
Executing all ExoPlayer methods on main thread
2019-04-11 20:50:56 +02:00
5745da75a6
Clarified that it is using caller thread. not main thread
2019-04-11 20:11:40 +02:00
f2af5192e6
Merge branch 'develop' into fix-2359
2019-04-10 08:21:55 -07:00
0e3cabb86d
Do not hold state in fragments
2019-04-10 01:05:36 +02:00
156a20734a
Fix Sonic playback
2019-04-07 12:54:12 +02:00
2c9cb25eda
Merge branch 'develop' into exoplayer-main-thread
2019-04-07 11:52:24 +02:00
ebe32e795a
Executing all ExoPlayer methods on main thread
2019-04-07 00:19:02 +02:00
20f1445c06
fix rebase conflicts - remove the incorrect @NonNull from rxjava
2019-04-06 14:19:16 -07:00
1655d234af
#2966 RxJava2 null - case the underlying method may return null, but
...
should never happen in the code path, e.g.,
return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
onError() to handle null case
Rx observer : underlying sources marked as @Nullable
ItemFragment.load : .loadInBackground
MediaplayerActivity.checkFavorite : DBReader.getFeedItem
ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
ItemlistFragment.loadItems : .loadData
2019-04-06 13:43:11 -07:00
0472bb9237
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
2019-04-06 13:43:11 -07:00
670fc124eb
#2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
...
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.
Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
2019-04-06 13:43:11 -07:00
5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145
...
Bulk remove from queue
2019-04-06 21:45:55 +02:00
cb14fd930f
refactor - rename string resource name `remove_episode_lable` , which was ambiguous with typos, to `delete_episode_label`
...
- non-default string resources to be handled by Transifex
2019-04-06 11:27:20 -07:00
cc43af110a
tweak - bulk edit UI - show a message after an action is applied.
2019-04-06 11:15:14 -07:00
b3fbf0b4aa
refactor - UI - remove the old (and now used) select all / none /intermediate icons
2019-04-04 14:05:51 -07:00
d186309066
bulk edit - UI - new select all / none icons, based on
...
standard Material icons.
2019-04-04 13:50:55 -07:00
dfe2241b4c
bulk remove episodes from queue - UI - icon for dark themes.
2019-04-04 13:12:09 -07:00
643173de14
Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716
...
Fix phantom service notification
2019-04-04 11:59:30 +02:00
b683d33bcb
bulk edit - refactor - reorder method parameter for DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API.
2019-04-03 14:21:35 -07:00
4322e8646f
bulk edit - UI tweak - rename "Remove Episode" to "Delete Episode", to be consistent with other UIs
2019-04-03 13:27:31 -07:00
46510c808a
Respect 'keep updated' for new items counter
2019-04-03 18:11:55 +02:00
7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates
...
Mobile updates: Allow images
2019-04-03 17:43:53 +02:00
b6e50c61d6
Merge pull request #3060 from jatinkumarg/issue-3052
...
Added empty views to the PlayBack History, Queue,and Downloads
2019-04-03 17:42:09 +02:00
788e75515a
Review changes
2019-04-03 17:29:44 +02:00
3768dfb0ff
bulk edit - "N selected" UI logic
2019-04-02 17:34:05 -07:00
364c9a308d
bulk remove from queue - backend - implement the new API
2019-04-02 15:59:27 -07:00
70287a740e
bulk remove from queue - backend - refactor existing logic to support bulk remove
2019-04-02 14:59:12 -07:00
7d78b88a1c
bulk remove from queue - frontend logic, with a stub backend.
2019-04-02 14:11:22 -07:00
737f7571ab
UI Prototype for Batch Edit Episodes rework (from #1145 )
2019-04-02 11:47:57 -07:00
6fe171fac9
Use ApOkHttpUrlLoader for all images
...
Probably got broken during my Glide update.
When using append or prepend, Glide uses the next one in the chain if ApOkHttpUrlLoader blocks
2019-04-02 17:41:21 +02:00
0fda36b9b3
Add preference to allow mobile updates of images
2019-04-02 17:41:15 +02:00
c589bd2022
Validate that the *new* and *not played* are also exclusive
...
The FeedItem state is actually a tri-state, complement the test
coverage by checking that the state changes from *new* to
*not played*.
2019-03-31 21:26:53 +02:00
6ebf1defe7
Validate that the item state is only changed when needed
...
Follow-up to commit 8172d87477#3067 )
that adds test coverage for the resolved issue.
Also, fix that commit by making the update condition more explicit:
the FeedItem state is only changed when a state switch is necessary.
In other words, an item marked as *new* that gets downloaded should
lose the *new* mark and gain the *unplayed* mark instead.
2019-03-31 16:28:05 +02:00
cba4059063
Require the Mockito library for unit testing
2019-03-31 16:26:26 +02:00
3c7fd274de
Validate that the *new* and *played* states are exclusive
2019-03-31 16:26:26 +02:00
c6344f5bc0
Merge pull request #3073 from deandreamatias/fix-button-shadow-3040
...
Fix #3040 Video playback control button shadow
2019-03-31 00:44:50 +01:00
56456e0001
Delete unused drawable
2019-03-30 21:21:11 +01:00
f900046c66
Merge pull request #3068 from bibz/develop
...
Do not reset item "played" flag on media download
2019-03-30 11:12:46 +01:00
7f3f2180cc
Fixes #3040
...
- Delete unused icons
2019-03-29 22:27:26 +01:00
007f92c291
Change the icons in interface #3040
2019-03-29 22:23:52 +01:00
9e21695486
Add new vector icons #3040
2019-03-29 22:21:04 +01:00
209b0b3880
Fixed typos
2019-03-29 14:20:11 -04:00
09087b354d
Fix #3040
...
- Change the size of the button circle background
2019-03-29 12:57:52 +01:00
42cbdbd989
Merge pull request #3066 from orionlee/bugfix_statistics_played_duration_inflated_2162
...
bugfix - statistics - inflated actual played duration
2019-03-27 20:51:13 +01:00
bdf7bf6844
Fixes #3052 : Added empty views to the Playback History, Queue, Downloads and Episodes
2019-03-27 04:16:06 -04:00
8172d87477
Do not reset item "played" flag on media download
...
If an item has already been played, downloading its media will not
reset that "played" flag.
Fixes : #3067
2019-03-25 15:41:39 +01:00
0a01f6e00b
#2162 bugfix - statistics - inflated actual played duration
2019-03-24 13:00:37 -07:00
6662205167
Added empty views to the PlayBack History, Queue,and Downloads
2019-03-21 03:05:01 -04:00
e25659a128
Fix #3054 : use UTF-8 to encode password and username for gpodder auth
2019-03-08 17:46:30 +01:00
7a905c0570
remove the commented stopService() call (to avoid future confusion)
2019-03-05 15:07:16 -08:00
24915785eb
remove the stopService() per review (which might unnecessarily
...
stop the playback when unsupported media buttons are pressed.)
2019-03-05 15:01:48 -08:00
c1bfb9183c
Merge pull request #3013 from hannesa2/buildImprovements
...
Build improvements
2019-03-05 23:49:00 +01:00
e94e95e844
remove dead codes
2019-03-04 13:46:11 -08:00
600e0e561e
coding style fix per review
2019-03-04 13:44:53 -08:00
c0f534e825
Merge pull request #3050 from ByteHamster/add-backup-keyword
...
Add backup keyword to search
2019-03-04 18:57:37 +01:00
579b263a86
Add backup keyword to search
2019-03-04 14:33:39 +01:00
c50d37fa1b
Moved some implementation tests to unit tests
2019-03-03 23:55:52 +01:00
1593a06077
Merge pull request #3032 from shortspider/3031-TimecodeRegex
...
Change Timecode Regex
2019-03-03 23:26:32 +01:00
1d0e701525
Another atempt at fixing the regex
2019-03-03 13:36:28 -05:00
7e3ccd97da
Fix regex
2019-03-02 12:12:26 -05:00
6f69b4b140
Adjust regext to ignore X:Y timecodes
2019-03-02 08:47:52 -05:00
a3389490bb
ensure the service continues to run in the event it takes a long time for the service to load the media to play, e.g.,
...
streaming over a slow network.
2019-02-27 14:59:31 -08:00
ab78c1d410
bug fix for Android8+: revert context.startService() calls back to
...
ContextCompat.startForegroundService(), to ensure PlaybackService
can be started.
While PlaybackService itself ensures it will be raised to foreground
when appropriate, Android 8+ forbids creating the (background)
services to begin with (and throw IllegalStateException) in some
situation (e.g., BroadcastReceiver).
https://developer.android.com/about/versions/oreo/android-8.0-changes#atap
2019-02-27 14:52:34 -08:00
2c5db08e25
minor cleanup of Log codes and comments.
2019-02-27 14:52:34 -08:00
221cd4b480
refactor stop PlaybackService setupNotification() - extract common
...
code as private helper.
2019-02-27 14:52:34 -08:00
f0f8623937
refactor stop PlaybackService codes - remove legacy dead codes
2019-02-27 14:52:34 -08:00
584865ad18
review stop PlaybackService codes (stopSelf, stopForeground, etc.)
2019-02-27 14:52:34 -08:00
3f14fac479
remove static PlaybackService.started, in favor of the start state
...
managed by inner ServiceManager.
Also add a generic java8-like Optional class for use with RxJava2 where
null was to be returned (RxJava2 requires non-null).
2019-02-27 14:52:34 -08:00
e26a54bdbc
start playbackService code paths reviewed (context.startService() and
...
ContextCompat.startForegroundService())
2019-02-27 14:52:34 -08:00
76fbab8e82
more #2716 - fix VideoPlayback upon hitting home button.
2019-02-27 14:52:34 -08:00
f3980091a9
#2716 Prototype for the revamped PlaybackService to fix phantom
...
notification. Many rough edges. Notable TODOs are marked with [2716].
2019-02-27 14:52:34 -08:00
6dafc8b127
Transifex: removed duplicate Italian translation
...
Using it_IT for all italian languages because it's 100% finished
2019-02-21 15:17:59 +01:00
e94e4bc3d0
Use a single format for short timecodes
...
It is unlikely that multiple formats for short timecodes would be used
in one document. Therefor we will parse all the short timecodes to see
if they are all less then the duration as HH:MM. If they are we will use
that, otherwise we will parse them as MM:SS.
2019-02-13 21:06:19 -05:00
c49e98b546
Handle more then 23 hours
2019-02-12 20:53:17 -05:00
39b9df5064
Timecode parsing logic now handles two short formats
...
We now handle both HH:MM and MM:SS when paring timecodes. We will move
in reverse order (assuming that the timecodes will increase over the
course of the document) and parse short codes as HH:MM. When we get a
result that does not fit into the duration we will change to parse as
MM:SS and use that for the rest of the document.
2019-02-12 19:43:57 -05:00
d0f617880c
Converter handles HH:MM and MM:SS
2019-02-12 19:43:37 -05:00
96b0336b2c
Update Timeline regex
...
Regex now looks for the new types of short and long timestamps.
2019-02-10 18:01:00 -05:00
abe68ec7bd
Merge remote-tracking branch 'upstream/develop' into auto_download_12_hour_option_2685
2019-02-01 16:25:20 +01:00
7f100b3fa6
Null handling in OnlineFeedViewActivity ( #3004 )
2019-02-01 15:57:19 +01:00
0663e422a6
unify lint options for all modules
2019-01-27 12:54:56 +01:00
e9c10cdaa8
simplify build concerning maven repos
2019-01-27 12:45:32 +01:00
9ca7888d92
remove buildtools specification
2019-01-27 12:42:02 +01:00
a80435a03b
switched implementation to ussing attr
2019-01-18 12:09:24 -08:00
fd83665970
Changed implementation using themeUtils instead
2019-01-17 16:21:34 -08:00
7da762b8ea
Changed implementation using themeUtils instead
2019-01-17 16:18:50 -08:00
ecff66eff6
fixed styles
2019-01-17 12:29:23 -08:00
43642a5e6b
adding highlighting of drawer item functunality
2019-01-16 20:51:54 -08:00
5d3e3687f9
Adding some highlighting of drawer items
2019-01-16 18:26:42 -08:00
H. Lehmann
ByteHamster
Cédric Cabessa
Joe Stein
Anderson Mesquita
Martin Fietz
orionlee
Stephen Kitt
Cédric Cabessa
Brad Pitcher
Borjan Tchakaloff
Matias de Andrea
Jatin Kumar
Matthieu De Beule
Nathan Mascitelli
Burt Wiley Snyder
Hannes Achleitner
pachecosf