Borjan Tchakaloff
6ebf1defe7
Validate that the item state is only changed when needed
...
Follow-up to commit 8172d87477
(#3067 )
that adds test coverage for the resolved issue.
Also, fix that commit by making the update condition more explicit:
the FeedItem state is only changed when a state switch is necessary.
In other words, an item marked as *new* that gets downloaded should
lose the *new* mark and gain the *unplayed* mark instead.
2019-03-31 16:28:05 +02:00
Borjan Tchakaloff
cba4059063
Require the Mockito library for unit testing
2019-03-31 16:26:26 +02:00
Borjan Tchakaloff
3c7fd274de
Validate that the *new* and *played* states are exclusive
2019-03-31 16:26:26 +02:00
Jatin Kumar
7f035b8b4b
Updated text sizes from dp to sp
2019-03-30 21:42:55 -04:00
H. Lehmann
c6344f5bc0
Merge pull request #3073 from deandreamatias/fix-button-shadow-3040
...
Fix #3040 Video playback control button shadow
2019-03-31 00:44:50 +01:00
Matias de Andrea
56456e0001
Delete unused drawable
2019-03-30 21:21:11 +01:00
Martin Fietz
2094caf7f2
Merge pull request #3074 from ByteHamster/fyydlin
...
Fixed fyyd feed search
2019-03-30 11:12:58 +01:00
Martin Fietz
f900046c66
Merge pull request #3068 from bibz/develop
...
Do not reset item "played" flag on media download
2019-03-30 11:12:46 +01:00
Matias de Andrea
7f3f2180cc
Fixes #3040
...
- Delete unused icons
2019-03-29 22:27:26 +01:00
Matias de Andrea
007f92c291
Change the icons in interface #3040
2019-03-29 22:23:52 +01:00
Matias de Andrea
9e21695486
Add new vector icons #3040
2019-03-29 22:21:04 +01:00
Jatin Kumar
209b0b3880
Fixed typos
2019-03-29 14:20:11 -04:00
ByteHamster
8d8e333b84
Fixed fyyd feed search
2019-03-29 18:26:34 +01:00
Matias de Andrea
09087b354d
Fix #3040
...
- Change the size of the button circle background
2019-03-29 12:57:52 +01:00
H. Lehmann
42cbdbd989
Merge pull request #3066 from orionlee/bugfix_statistics_played_duration_inflated_2162
...
bugfix - statistics - inflated actual played duration
2019-03-27 20:51:13 +01:00
Jatin Kumar
cabf6fee7b
Updated NewEpisodesFragment and FavoriteEpisodesFragment files
2019-03-27 04:55:50 -04:00
Jatin Kumar
bdf7bf6844
Fixes #3052 : Added empty views to the Playback History, Queue, Downloads and Episodes
2019-03-27 04:16:06 -04:00
Borjan Tchakaloff
8172d87477
Do not reset item "played" flag on media download
...
If an item has already been played, downloading its media will not
reset that "played" flag.
Fixes : #3067
2019-03-25 15:41:39 +01:00
orionlee
0a01f6e00b
#2162 bugfix - statistics - inflated actual played duration
2019-03-24 13:00:37 -07:00
H. Lehmann
3e2efea0e7
Merge pull request #3062 from ByteHamster/feed-test-handler
...
Fixed FeedHandlerTest
2019-03-23 11:36:14 +01:00
ByteHamster
022a7f6981
Fixed FeedHandlerTest
2019-03-23 10:45:50 +01:00
Jatin Kumar
6662205167
Added empty views to the PlayBack History, Queue,and Downloads
2019-03-21 03:05:01 -04:00
orionlee
6f7b937d07
bugfix - video playback upon press back button (and pause), playback notification might reappear if one swipes it away quickly.
2019-03-09 14:16:53 -08:00
H. Lehmann
0a9735e7da
Merge pull request #3057 from matdb/develop
...
Fix #3054 : use UTF-8 to encode password and username for gpodder auth
2019-03-08 22:21:54 +01:00
Matthieu De Beule
e25659a128
Fix #3054 : use UTF-8 to encode password and username for gpodder auth
2019-03-08 17:46:30 +01:00
Matthieu
26d7e61f4d
Merge pull request #1 from AntennaPod/develop
...
catch up
2019-03-08 16:40:28 +01:00
H. Lehmann
6212455431
Merge pull request #3048 from ByteHamster/new-episodes-download
...
Fixed download status update in NewEpisodesFragment
2019-03-08 12:15:23 +01:00
ByteHamster
f2306d2950
Fixed download status update in NewEpisodesFragment
2019-03-08 11:39:24 +01:00
H. Lehmann
2818bb62ab
Merge pull request #3055 from matdb/develop
...
Fix #3028 : actually use encodedQuery from URLEncoder to avoid encoding issues
2019-03-08 11:27:15 +01:00
Matthieu De Beule
c362a50e1b
Fix #3028 : actually use encodedQuery from URLEncoder to avoid encoding issues
2019-03-07 20:53:22 +01:00
orionlee
7a905c0570
remove the commented stopService() call (to avoid future confusion)
2019-03-05 15:07:16 -08:00
orionlee
24915785eb
remove the stopService() per review (which might unnecessarily
...
stop the playback when unsupported media buttons are pressed.)
2019-03-05 15:01:48 -08:00
H. Lehmann
c1bfb9183c
Merge pull request #3013 from hannesa2/buildImprovements
...
Build improvements
2019-03-05 23:49:00 +01:00
orionlee
e94e95e844
remove dead codes
2019-03-04 13:46:11 -08:00
orionlee
600e0e561e
coding style fix per review
2019-03-04 13:44:53 -08:00
H. Lehmann
c0f534e825
Merge pull request #3050 from ByteHamster/add-backup-keyword
...
Add backup keyword to search
2019-03-04 18:57:37 +01:00
H. Lehmann
cfa9304c82
Merge pull request #3047 from ByteHamster/move-to-unit-test
...
Moved some implementation tests to unit tests
2019-03-04 18:56:51 +01:00
H. Lehmann
3d9811d1e3
Merge pull request #3044 from mamehacker/min_max_speeds_from_preferences
...
Set min/max playback speeds from preferences
2019-03-04 18:53:34 +01:00
ByteHamster
579b263a86
Add backup keyword to search
2019-03-04 14:33:39 +01:00
ByteHamster
c50d37fa1b
Moved some implementation tests to unit tests
2019-03-03 23:55:52 +01:00
H. Lehmann
1593a06077
Merge pull request #3032 from shortspider/3031-TimecodeRegex
...
Change Timecode Regex
2019-03-03 23:26:32 +01:00
Nathan Mascitelli
1d0e701525
Another atempt at fixing the regex
2019-03-03 13:36:28 -05:00
Nathan Mascitelli
7e3ccd97da
Fix regex
2019-03-02 12:12:26 -05:00
Nathan Mascitelli
6f69b4b140
Adjust regext to ignore X:Y timecodes
2019-03-02 08:47:52 -05:00
orionlee
a3389490bb
ensure the service continues to run in the event it takes a long time for the service to load the media to play, e.g.,
...
streaming over a slow network.
2019-02-27 14:59:31 -08:00
orionlee
ab78c1d410
bug fix for Android8+: revert context.startService() calls back to
...
ContextCompat.startForegroundService(), to ensure PlaybackService
can be started.
While PlaybackService itself ensures it will be raised to foreground
when appropriate, Android 8+ forbids creating the (background)
services to begin with (and throw IllegalStateException) in some
situation (e.g., BroadcastReceiver).
https://developer.android.com/about/versions/oreo/android-8.0-changes#atap
2019-02-27 14:52:34 -08:00
orionlee
2c5db08e25
minor cleanup of Log codes and comments.
2019-02-27 14:52:34 -08:00
orionlee
221cd4b480
refactor stop PlaybackService setupNotification() - extract common
...
code as private helper.
2019-02-27 14:52:34 -08:00
orionlee
f0f8623937
refactor stop PlaybackService codes - remove legacy dead codes
2019-02-27 14:52:34 -08:00
orionlee
584865ad18
review stop PlaybackService codes (stopSelf, stopForeground, etc.)
2019-02-27 14:52:34 -08:00