Commit Graph

42 Commits

Author SHA1 Message Date
ByteHamster e578f4ca93
CI tweaks (#7069)
- Run Checkstyle with gradle to make it easier for users
  - No longer needs different configuration for new code
  - Exclude current violations
  - Fix some violations that somehow couldn't be specified in the exclusion file
- Print SpotBugs/Lint/Checkstly violations in GitHub format
  - Then the CI run gets annotated on the web UI
2024-04-07 23:28:14 +02:00
Taco b6a4049ff4
Spotbugs cleanup (#6968)
Remove unused SpotBugs rules.
Fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD, ICAST_INTEGER_MULTIPLY_CAST_TO_LONG, NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION, OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE
2024-04-05 19:28:36 +02:00
ByteHamster edb440a5a9
Restructure related UI classes together (#7044) 2024-03-31 18:40:15 +02:00
ByteHamster 8accb54685
Move playback service to module (#7042) 2024-03-29 21:05:02 +01:00
ByteHamster 13a985ca1e
Restructure Echo to be more flexible (#7035)
Each screen is its own file, which makes it easier to add interactive elements.
2024-03-29 08:55:13 +01:00
ByteHamster f20ce1fc69
Move first batch of preferences code to :ui:preferences (#7010) 2024-03-23 09:40:40 +01:00
ByteHamster 2d77b1f118
Remove dependency from :ui:glide to :core module (#6998) 2024-03-17 20:25:44 +01:00
ByteHamster 7c14534179
Remove TriangleLabelView (#6963)
Since we redesigned the subscriptions page, this class is unused.
2024-03-06 21:53:40 +01:00
ByteHamster 68ec4e2527
Merge pull request #6958 from TacoTheDank/bumpSpotBugs
Update and fix SpotBugs
2024-03-06 17:46:05 +01:00
TacoTheDank 522288260c Clean up some old SpotBugs rules 2024-03-06 02:55:01 -05:00
TacoTheDank c2ccc28b95 Update SpotBugs 2024-03-06 02:52:14 -05:00
ByteHamster cae848b505 Fix indentation in last 8 files 2024-03-04 23:09:59 +01:00
ByteHamster 6c0f9eec62 Remove tab characters from last 6 files 2024-03-04 23:09:55 +01:00
ByteHamster 114a2c192c Make checkstyle CI faster 2022-01-16 11:23:29 +01:00
ByteHamster 9c01712276 Move more checkstyle checks from 'new code' style to main style 2022-01-15 12:57:23 +01:00
ByteHamster 849bf4ad85
Rewrite download request creation (#5530)
Android has a limit on the size of Intent parameters. When enqueuing
a huge number of items, it just ignored the argument and did not call
onNewIntent. We now load the list over in DownloadService.
2022-01-06 14:36:11 +01:00
seeto dab44b6843
Rename folder to tag (#5381) 2021-10-02 17:13:23 +02:00
ByteHamster ca64739f36 Moved media file parser to its own module 2021-08-28 10:59:26 +02:00
ByteHamster ba66ae7633 Moved model to its own module 2021-04-22 23:17:11 +02:00
ByteHamster 998535515b Make AntennaPod pass the medium SpotBugs findings 2021-03-28 22:32:40 +02:00
ByteHamster 71184ee5d4 Fixed SpotBugs violations, so that at least the most severe checks pass 2021-03-27 20:44:35 +01:00
ByteHamster 3946f986d7 Add SpotBugs CI check 2021-03-27 18:45:17 +01:00
ByteHamster f62a6b808e Only store content_encoded or description 2021-03-04 19:47:48 +01:00
Herbert Reiter 3e56e1bd64 Add Checkstyle rule to check for unused imports 2020-12-14 23:07:44 +01:00
ByteHamster 6d3cc1a9da Checkstyle fixes 2020-03-30 14:37:27 +02:00
ByteHamster 6a7375dd9b Added diff-checkstyle 2020-03-30 12:06:16 +02:00
ByteHamster 9e99b81f1e Enabled more checkstyle rules 2020-03-18 20:17:51 +01:00
ByteHamster be076be737 Cleaned up checkstyle file a bit 2020-02-03 22:18:41 +01:00
ByteHamster 719af170a7 Enforce SeparatorWrap 2020-02-02 18:42:10 +01:00
ByteHamster b656cb91a2 Enforce MethodParamPad 2020-02-02 18:42:06 +01:00
ByteHamster 8f08bd1f6d Enforce method names 2020-02-02 17:48:30 +01:00
ByteHamster b2fb239853 Enforce valid javadoc 2020-02-02 17:48:30 +01:00
ByteHamster 26e91c0b81 Avoid too much nesting 2019-12-02 10:30:49 +01:00
H. Lehmann 58764f7ccb
Merge pull request #3549 from ByteHamster/checkstyle-whitespace
Checkstyle: whitespace after comma and cast
2019-10-23 21:21:26 +02:00
ByteHamster 6017e28787 Enforcing whitespace after comma 2019-10-23 20:50:45 +02:00
ByteHamster 2fb0d637a1 Enforce NoWhitespaceBefore checkstyle 2019-10-22 16:57:05 +02:00
ByteHamster cc52fa04fa Enforce MultipleVariableDeclarations checkstyle 2019-10-22 16:53:35 +02:00
ByteHamster 6a4754922a Added more rules that we already fulfill 2019-10-22 16:50:04 +02:00
ByteHamster 1b61057dff Do not enforce Google checkstlye import order
The IntelliJ/AS default is different, so this would be a problem for most new developers.
Additionally, there definitely are more important things to enforce.
2019-10-22 16:36:51 +02:00
ByteHamster 5f75536ee5 Added best-practice checkstyle checks
This are the style guidelines I want to enforce throughout the project in the future.
Currently, huge parts of the app do not pass these checks but when developing something new,
we should add those checks to our IDEs.

They are basically the Google checks but with an increased line length from 100 to 120
characters and using 4 instead of 2 spaces for indentation.
2019-10-03 23:01:52 +02:00
ByteHamster 28a816b16c Enabled more checkstyle rules 2019-09-28 17:23:36 +02:00
ByteHamster b7301ca360 Added checkstyle 2019-09-24 11:21:08 +02:00