2d1ee52014
fix imports post androidX migration
2019-11-05 11:04:23 -08:00
fb7fb05b5e
test case tweak: preserve download order test, fix test case name
...
(remove the incomplete expected from test case name)
2019-11-05 11:04:23 -08:00
820b0b0793
test case bug fix: Bulk download 2nd item position should be 1
2019-11-05 11:04:23 -08:00
ce5aa26878
refactoring test - factor out common operations of calc position,
...
add to queue and verify result into common helper.
2019-11-05 11:04:23 -08:00
fb824b541d
Test cases readability: change expected format from position to the actual queue
...
(list of IDs), to make the test case more readable.
2019-11-05 11:04:23 -08:00
97905e5ed4
#2448 : make podcast episode enqueue position respect download start order
2019-11-05 11:04:17 -08:00
0973efa943
refactor test - break ItemEnqueuePositionCalculatorTest to be more modular
...
to prepare for testing more complex enqueue options.
2019-11-05 10:54:21 -08:00
17e61335db
#2652 (part of): Expose keep in-progress at front as a preference
...
(in Playback > Queue section)
2019-11-05 10:54:21 -08:00
30f104f40b
#2652 (part of): The in-progress podcast at the front of the queue
...
should remain at the front.
2019-11-05 10:54:21 -08:00
bfde3c7315
refactor - DBWriterTest: parametrize the set of tests
2019-11-05 10:54:21 -08:00
ba27ec6b31
refactor - DBWriter.addQueueItem() : refactor enqueue position calculation
...
to be a unit-testable component (static inner class)
2019-11-05 10:54:21 -08:00
8aff9709c3
Style OnlineFeedViewActivity like a dialog
...
User study showed that new users do not get the difference between the actual
feed list and the preview. If the preview is a dialog, this is a lot easier to see.
Additionally, the "dialog" now closes after the subscription succeeded.
2019-11-05 15:28:32 +01:00
386395629b
Clearer button text for feching podcast ( #3575 )
...
When subscribing to a podcast, the old text might be confusing to new users (it's not downloading an episode, just the feed. That is not considered downloading for most users)
Signed-off-by: sevenmaster <seven-master@hotmail.de>
2019-10-31 23:00:39 +01:00
2a2ced1631
Merge pull request #3572 from ByteHamster/downloadservice-refactoring
...
DownloadService refactoring
2019-10-31 09:23:47 +01:00
e7367e218d
Merge pull request #3571 from ByteHamster/hide-play-button-on-destroy
...
Updating notification play button in onDestroy
2019-10-30 19:30:20 +01:00
69f3a1210f
Do not refresh feeds more often than necessary
2019-10-30 19:27:38 +01:00
6825cca32a
Updating notification more often
2019-10-30 18:19:36 +01:00
dd5ba4d38d
Do not access context in constructor
2019-10-30 18:16:34 +01:00
ea6b41116f
Extracted DownloaderFactory to new class
2019-10-30 18:16:26 +01:00
8f168948ad
Reordered methods to have setup on top
2019-10-30 18:06:44 +01:00
366e60990d
Posting downloaders on executor
2019-10-30 18:05:26 +01:00
fe17f1bcb5
Extracted handling completed downloads to method
2019-10-30 17:51:22 +01:00
74621170fe
Converted our own FeedSyncThread to a task+executor
2019-10-30 11:10:44 +01:00
798868db9c
Extracted notification from DownloadService
2019-10-29 23:58:44 +01:00
056d7db16b
Extracted feed sync from DownloadService
2019-10-29 23:39:29 +01:00
7ae5424479
Updating notification play button in onDestroy
2019-10-29 22:37:58 +01:00
917e60fbe2
Fix incorrect progress string on widget
...
If option "pref_followQueue_title" is disabled, when played episode #1 is ended and next episode #2 is loaded, progress string on widget show incorrect information about position and duration of episode, because it show (position / duration) of ended episode #1 instead of (position / duration) of loaded episode #2 .
2019-10-29 11:16:06 +03:00
20e025bd2e
Prefer image that is specified in feed over embedded image
2019-10-27 22:52:41 +01:00
57818ade38
Merge branch 'develop' into more-eventbus-migration
2019-10-25 11:40:18 +02:00
a047e34f8e
Merge pull request #3528 from orionlee/podcast_screen_sort_2524
...
Sort Support in Podcast screen
2019-10-25 11:38:31 +02:00
1de76f789f
Removed EventDistributor
2019-10-25 11:25:21 +02:00
728ed23077
Migrated feed list update event to EventBus
2019-10-25 11:19:52 +02:00
d4b9d0fd59
Migrated unread items update to EventBus
2019-10-25 11:12:48 +02:00
b5ab7d6d3c
Migrated player status event to EventBus
2019-10-25 10:54:40 +02:00
ca83c59537
Fixes #3444 - Strip off HTML from podcast descriptions
2019-10-24 23:20:31 -04:00
baec984c0f
Feed Sort Order DB column: changed from Integer to Text, to allow flexibility of multiple sorts without DB schema change
2019-10-24 15:32:51 -07:00
7687ffb08e
Misc code style fixes.
2019-10-24 13:49:32 -07:00
007f1fbb87
Remove unused comparators after SortOrder refactoring
2019-10-24 13:39:28 -07:00
437f3f29c0
Merge pull request #3551 from ByteHamster/eventdistributor
...
Migrated some events from EventDistributor to EventBus
2019-10-24 22:28:33 +02:00
385bd3597b
Merge pull request #3550 from ByteHamster/remove-resume-intent
...
Removed resume intent
2019-10-24 22:27:48 +02:00
9c895ef15a
Test to ensure Feed only accepts INTRA_FEED sort order
2019-10-24 12:17:31 -07:00
bcd4b49dda
feeditem sort - handle boundary conditions
2019-10-24 12:03:22 -07:00
306b6f30a4
rename + refactor QueueSorter to FeedItemPermutors, to support both queue and podcast screen.
2019-10-24 11:32:06 -07:00
f56a02d513
sort in Podcast screen - implement all the sorts
2019-10-24 11:01:48 -07:00
05dfccacc3
a new filter icon, to differentiate it from sort per review.
...
- Icon source: https://materialdesignicons.com/icon/filter-outline
2019-10-24 10:30:32 -07:00
f41bdcbaf2
Merge pull request #3544 from M-arcel/develop
...
Transparent widget
2019-10-23 23:11:51 +02:00
ff44f97dd6
Showing a more interesting background image
2019-10-23 23:08:07 +02:00
6642b79ac3
Code cleanup
2019-10-23 23:08:07 +02:00
28cc00a016
Material design layout tweaks
2019-10-23 23:08:07 +02:00
b513608032
Transparent widget
2019-10-23 23:07:49 +02:00
7d3b78091f
Removed event that is never sent
2019-10-23 22:51:28 +02:00
d8ffa6c459
Migrated playback history events to EventBus
2019-10-23 22:51:21 +02:00
68da2e022d
Migrated download log events to EventBus
2019-10-23 22:41:20 +02:00
a8c1b3c87c
Removed resume intent
2019-10-23 22:25:33 +02:00
bc5f36336e
Merge pull request #3547 from ByteHamster/checkstyle-change
...
Checkstyle change
2019-10-22 22:59:42 +02:00
cc52fa04fa
Enforce MultipleVariableDeclarations checkstyle
2019-10-22 16:53:35 +02:00
562ddee7d7
sort in podcast screen - db persistence
2019-10-20 15:21:46 -07:00
be7db6cef1
sort in podcast screen - logic, no db persistence yet.
2019-10-20 15:21:46 -07:00
1620d29549
Sort in Podcast screen - UI
2019-10-20 15:21:46 -07:00
fea84424e3
Removed code duplication from playback tests, added test for ExoPlayer
2019-10-20 23:49:14 +02:00
f1f91478b6
Merge pull request #3520 from dsmith47/stream
...
Show stream button rather than download (in queue, podcast views)
2019-10-20 18:54:14 +02:00
38a670139f
Merge pull request #3505 from xgouchet/feature/3070_episode_image
...
Add an option to replace Episode cover with Podcast cover
2019-10-19 22:24:42 +02:00
4df98151a5
Merge pull request #3538 from ariedov/crash-on-equalizer-4.1
...
Fixes crash on equalizer open on Android 4.1
2019-10-19 01:53:08 +02:00
5f3714a028
Fixes crash on equalizer open on Android 4.1
2019-10-19 00:20:53 +03:00
250594827d
unit test for get feeditem link with fallback
2019-10-18 11:31:46 -07:00
5eaa4dbfb1
bugfix: Share Episode URL - handle empty link
2019-10-17 12:47:45 -07:00
fd5a5d71a2
Add an option to replace Episode cover with Podcast cover
...
The default is to use the episode cover (keep the previous behavior).
Fixes #3070
2019-10-17 16:00:27 +02:00
87cca61dcd
Merge remote-tracking branch 'origin/develop' into feat/simple-adjust-volume-per-feed
2019-10-17 13:13:19 +02:00
cc9c8bb63a
#3248 Extract @string resource for summary
2019-10-17 12:06:15 +02:00
14db72ac35
#3248 Merge FeedVolumeReduction into VolumeReductionSetting
2019-10-17 11:54:11 +02:00
3bc55a09b1
#3248 Rename PlaybackVolumeAdaptor -> ..Updater
2019-10-17 09:56:04 +02:00
f9cf013b16
#3248 Enable volume reduction for video media
2019-10-17 09:40:18 +02:00
0bc3294ca4
Implemented feature to show stream button (instead of Download/Play-Pause) in podcast episode views.
...
* Added user preference to specify that stream buttons are preferred
* Added StreamAction button to trigger streams on podcast options
2019-10-16 04:31:50 -04:00
54eeeb4355
Merge pull request #3516 from egsavage/reset-sleep-timer-on-play
...
Issue #2381 - restart sleep timer on play
2019-10-15 12:12:06 +02:00
504bbb0058
Remove duplicate string
2019-10-14 09:14:00 +02:00
c81fcba22d
Fix formatting
2019-10-14 09:14:00 +02:00
4f65aa015a
Add confirmation dialog before reseting statistics
2019-10-14 09:14:00 +02:00
4289933155
Optimize the deletion of statistics data
2019-10-14 09:14:00 +02:00
5989d6daf6
Remove the unnecessary StatisticsEvent
2019-10-14 09:14:00 +02:00
91463ba877
Remove icon from "Reset statistics" option menu item
2019-10-14 09:14:00 +02:00
f9b413332f
Reset playback statistics
...
Fixes #1867
2019-10-14 09:14:00 +02:00
a59fd67178
Issue #2381 - restart sleep timer on play
2019-10-13 20:58:28 -04:00
c1d81408c1
Fixed notification reappearing if continuous playback is disabled
2019-10-09 12:26:11 +02:00
3980bcca6d
Merge pull request #3386 from orionlee/bugfix_skip_last_episode_in_queue_3383
...
Bugfix skip last episode in queue - episode status
2019-10-09 12:09:04 +02:00
0e614f96e9
Merge pull request #3497 from ByteHamster/position-in-notification
...
Showing progress in notification
2019-10-06 19:42:14 +02:00
f750e06a1b
Merge pull request #3498 from ByteHamster/fix-mono-switch
...
Fixed downmixing if service is not bound
2019-10-06 12:57:07 +02:00
935e2ceee0
Merge pull request #3499 from ByteHamster/local-playable-improvements
...
Local playable improvements
2019-10-06 12:54:14 +02:00
de10ca9548
Merge pull request #3415 from spacecowboy/per_feed_playbackspeed
...
Added per-feed playback speed setting
2019-10-06 12:52:55 +02:00
526c5744de
Merge pull request #3496 from ByteHamster/default-playback-speed
...
Added 0.75 to default playback speed list
2019-10-06 12:48:46 +02:00
6f809b47e6
Speeding up notification update
...
startForeground() is significantly slower than just notify()
2019-10-06 12:45:22 +02:00
138c29df0f
Removed potentially misleading comment
2019-10-06 10:06:11 +02:00
b2d9455d6c
Caching icon manually to prevent long locks
2019-10-06 10:04:06 +02:00
cab40dc466
Removed unnecessary comment
2019-10-06 10:04:05 +02:00
69e51c148e
Moved notification setup out of Thread
...
Fixes wrong thread for media player. Also, might fix race conditions.
2019-10-06 09:11:45 +02:00
e6ae4c23f0
Showing file name if title extraction fails
2019-10-05 23:48:50 +02:00
cf3e8107f3
Syntax cleanup
...
Mostly replaced tabs with spaces
2019-10-05 23:38:51 +02:00
b081e320e3
Fixed downmixing if service is not bound
2019-10-05 23:04:18 +02:00
53ea702772
Showing progress in notification
2019-10-05 21:58:25 +02:00
cb942b646a
Added 0.75 to default playback speed list
...
Users on Google Play seem to be confused that they can not select a
playback speed lower than 1x anymore. The reason is that they just
use the preference dialog and that dialog only displays the range
that is selected for the button.
2019-10-05 21:05:28 +02:00
9539908f23
Removed unused imports and unnecessary whitespace changes
2019-10-05 02:24:47 +02:00
6a37d33b97
Changed from db backed item speed to preferences backed global value
2019-10-05 02:15:26 +02:00
97aa360611
Merge remote-tracking branch 'antennapod/develop' into per_feed_playbackspeed
2019-10-05 01:18:14 +02:00
e37bd24364
Fixed free build
2019-10-04 23:20:51 +02:00
650c5503ad
Moved SafeJobIntentService to correct package
2019-10-04 11:24:43 +02:00
933790b0d3
Fixed compilation
2019-10-04 11:24:27 +02:00
7574ca7920
Adapted dependency versions to stable ones
2019-10-04 11:23:50 +02:00
c130498fc6
Automatic AndroidX migration
2019-10-04 11:22:39 +02:00
59d5c3cbf2
Changed color of default notification icon
2019-10-02 16:07:08 +02:00
71a5a00fd0
Merge branch 'develop' into notification-default-icon
2019-10-02 16:03:11 +02:00
cbee8c3043
Merge branch 'develop' into feat/simple-adjust-volume-per-feed
2019-10-02 15:58:58 +02:00
2db5c00d66
Merge pull request #3482 from ByteHamster/exoplayer-log-source
...
Added logging to ExoPlayer
2019-10-02 15:58:04 +02:00
cbdd3603aa
Added logging to ExoPlayer
2019-10-02 15:42:55 +02:00
d84fc95f0d
test for DownloadService, case media download successful.
2019-09-30 13:46:59 -07:00
f3b3d5c422
Merge pull request #3476 from ByteHamster/fix-feed-without-identifying-value
...
Fixed feed without any identifying value
2019-09-30 21:34:56 +02:00
f862d15753
Merge pull request #3471 from orionlee/bugfix2_player_not_using_downloaded_media_2947
...
New fix player stuck due to streaming rather than using downloaded media
2019-09-30 21:34:17 +02:00
f71b933c6b
Fixed feed without any identifying value
2019-09-30 20:39:02 +02:00
694d0f8d34
Merge pull request #3472 from ByteHamster/do-not-spam-logcat
...
Reduced logcat output
2019-09-30 19:07:56 +02:00
0ffa0e77d9
Reduced logcat output
2019-09-29 22:07:39 +02:00
71de4607a3
bugfix: Ensure when media download completes and item update event is posted, the feed media has been updated,
2019-09-29 12:55:02 -07:00
9469ebc6c3
bugfix: Ensure playback service use the updated feedItem after media download completes (rather than trying to stream)
2019-09-29 12:46:21 -07:00
5bf7216064
Merge branch 'develop' into feat/simple-adjust-volume-per-feed
2019-09-29 17:31:34 +02:00
1709877531
Merge pull request #3470 from ByteHamster/playbackservice-save-current-playable
...
Moved storing PlaybackPreferences to PlaybackPreferences.java
2019-09-29 17:10:34 +02:00
a3598daaa7
Moved storing PlaybackPreferences to PlaybackPreferences
2019-09-29 16:47:12 +02:00
1c60a0134d
Keep buffer depending on rewind time
2019-09-29 14:05:48 +02:00
ea84dde76f
Merge pull request #3467 from ByteHamster/keep-back-buffer
...
Keep 30 seconds of back buffer
2019-09-29 12:56:04 +02:00
2dfe08df2a
Merge pull request #3454 from ByteHamster/update-progress
...
Update episode progress during playback
2019-09-29 12:52:48 +02:00
c614e6e29c
Merge pull request #3466 from ByteHamster/no-reinit-on-pause
...
Do not reinit on pause
2019-09-29 12:50:47 +02:00
fc317e3b68
Keep 30 seconds of back buffer
2019-09-29 12:49:06 +02:00
3beda73e3c
Do not reinit on pause
2019-09-29 12:39:13 +02:00
8d9c292ca1
Merge branch 'develop' into smart-spread-fix
2019-09-29 12:31:55 +02:00
373f31c53e
Merge pull request #3416 from orionlee/bugfix_autodownload_wifi_filter_on_android10_3387
...
Make Automatic Download WiFi filter UI work on Android 10+
2019-09-29 11:16:10 +02:00
e3ef12e413
Merge pull request #3440 from orionlee/avoid_cast_init_unless_enabled
...
Avoid Cast initialization unless it is enabled
2019-09-29 11:13:33 +02:00
fb377258f2
Merge pull request #3461 from ByteHamster/do-not-notify-cancelled-downloads
...
Do not notify cancelled downloads
2019-09-29 11:10:59 +02:00
cf5f0fbc28
#3383 Fix skip last episode in queue - the fix
2019-09-28 15:50:12 -07:00
11270d91a6
#3383 Fix skip last episode in queue: android test to reproduce it.
2019-09-28 15:50:11 -07:00
7ae3934794
Fix the smart shuffle spread calculation
...
We want to ensure that the total spread is divisible by all feed
sizes, so the modulo calculation needs to divide spread by the feed
size, not the other way round as is done currently.
In addition, this ensures the per-feed spread is never 0 (so the
degenerate case is equivalent to the old smart shuffle).
Signed-off-by: Stephen Kitt <steve@sk2.org>
2019-09-28 18:11:08 +02:00
28a816b16c
Enabled more checkstyle rules
2019-09-28 17:23:36 +02:00
66cf4a8a43
Sending event if download was cancelled
2019-09-28 14:20:57 +02:00
3041336b92
Do not notify cancelled downloads
2019-09-28 13:04:40 +02:00
0b5f4e9dc0
Avoid Cast initialization unless it is enabled (to avoid triggering Google Play Service)
2019-09-27 11:19:29 -07:00
db2141a7b4
#3387 permission prompt - add warning icon to make it stand out.
2019-09-27 10:29:27 -07:00
d559a8b906
#3387 use ACCESS_FINE_LOCATION per Google feedback
...
https://issuetracker.google.com/issues/140696830
2019-09-27 10:29:27 -07:00
c8dda3c0c0
#3387 ask for location permission for Wi-Fi filter UI on Android 10+.
2019-09-27 10:29:26 -07:00
d80daee37e
#3387 new permission for WiFi filter UI be compatible with Android 10+
2019-09-27 10:29:26 -07:00
107b64315e
Merge branch 'develop' into update-progress
2019-09-27 12:58:56 +02:00
3e01d66cbd
Merge branch 'master' into develop
2019-09-27 12:55:24 +02:00
a6bffa797a
Merge pull request #3458 from ByteHamster/store-foreground-state-correctly
...
Fixed another phantom service is running notification
2019-09-27 12:43:03 +02:00
0c0e50d3ae
Fixed another phantom service is running notification
...
Steps to reproduce:
- Send STOP key two times
- Service starts foreground but does not stop again because stateManager does not know about foreground state
2019-09-27 12:03:39 +02:00
bbf4f8cc3f
Merge pull request #3453 from ByteHamster/refresh-subscriptions-view
...
Added refresh item to subscriptions view
2019-09-26 23:45:22 +02:00
8b53268bfe
Refactored method for readability
2019-09-26 19:06:26 +02:00
orionlee
ByteHamster
sevenmaster
H. Lehmann
Ptilopsis Leucotis
fossterer
Marcel Regeci
David Leibovych
Xavier Gouchet
Max Bechtold
Doug Smith
egsavage
Jonas Kalderstam
Stephen Kitt