9e72780bc8
Merge pull request #3254 from jas14/feed-rotation-crash-3245
...
New ViewModel for loading feed preferences across lifecycle
2019-07-06 15:10:57 +02:00
ce649ec087
Merge pull request #3249 from archibishop/imagecover-playpause-fuctionality
...
Extend play/pause functionality to Image Cover
2019-07-06 15:00:30 +02:00
83c54e953a
Merge pull request #3256 from gaul/within-last-year
...
Fix within last year check in formatAbbrev
2019-07-06 14:57:00 +02:00
24e4211da1
Fix within last year check in formatAbbrev
...
Previously this method considered a date within the last 365 days to
be in the same year as today. Instead compare the actual years to
avoid confusion. Fixes #3255 .
2019-07-03 13:18:05 -07:00
e887996053
Extend play/pause functionality to Image Cover
2019-07-02 21:58:30 +03:00
3b6cfb711f
New ViewModel for loading feed preferences across lifecycle
2019-07-02 18:33:32 +02:00
082a452156
Merge pull request #3252 from jas14/handle-bad-chapters
...
Gracefully handle bad ID3 chapter URLs
2019-07-02 09:18:37 +02:00
f047c23c09
Gracefully handle bad ID3 chapter URLs
2019-07-01 13:40:46 +02:00
4bc8821845
Increase scrubber padding for large devices
2019-07-01 12:31:14 +02:00
2d91292937
Combined podcast search
2019-06-26 08:27:19 +02:00
abcd6f772e
Merge pull request #3239 from archibishop/username-validation-gpodder-login
...
Validate username for characters not accepted.
2019-06-26 06:51:42 +02:00
7f1f725bfe
validate username for characters not accepted.
2019-06-26 04:50:18 +03:00
8e95ed75ab
Fix recycler and empty view hide/show logic
...
The `emptyViewHandler` already handles hiding and showing both the empty
view and the recycler view on data changes, so this commit removes this
part of the logic from the episodes fragment.
It also hides the empty view right after creating the recycle adapter
for the first time (when the fragment is created) to prevent the
progress bar and the empty view from being displayed at the same time.
`createRecycleAdapter()` signature was changed to make it explicit that
it depends on both the `recyclerView` and `emptyViewHandler`. Similarly,
`onFragmentLoaded()`, since it also depends on the new data that gets
loaded.
2019-06-24 09:32:06 -04:00
bb8b1fc58f
Reorganize subscription fragment lifecycle
2019-06-24 08:38:04 -04:00
fd07a10f03
Reorganize search fragment lifecycle
2019-06-24 08:38:04 -04:00
5e5dfa5584
Reorganize playback history lifecycle
2019-06-24 08:38:04 -04:00
90d5208402
Reorganize item fragments lifecycle
2019-06-24 08:38:04 -04:00
e22adbe451
Reorganize DownloadLogFragment lifecycle
2019-06-24 08:38:04 -04:00
bbcec5d0aa
Reorganize Episode Fragments lifecycle
...
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
aabe370db3
Fix whitespace
2019-06-24 08:38:04 -04:00
486ceed0ef
Reorganize downloads fragments lifecycle
...
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747 ), so this registers/unregisters on view create/destroy.
Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.
There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.
Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.
[1]: https://developer.android.com/guide/components/fragments
Closes : #2747
2019-06-24 08:38:04 -04:00
a556183d60
Extract methods from onViewCreated
2019-06-24 08:38:04 -04:00
69f116904d
Fix IDE warnings
...
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
56dc16802a
Fix whitespace
2019-06-24 08:38:04 -04:00
1580e93b94
Merge pull request #3229 from ByteHamster/feed-settings-update
...
Updated feed settings screen
2019-06-14 18:47:53 +02:00
f3cd43b972
Cleanup
2019-06-14 10:45:45 +02:00
5a7cbdfaca
Added authentication and episode filter dialogs
2019-06-14 10:34:55 +02:00
8f11f8a271
Updated feed settings screen
2019-06-14 00:38:34 +02:00
8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
...
Restructured preferences code
2019-06-13 23:38:18 +02:00
d21422a50f
Merge pull request #3228 from ByteHamster/removed-deleted-receiver
...
Removed deleted receiver from manifest
2019-06-13 23:22:18 +02:00
85ef61f4ef
Removed deleted receiver from manifest
2019-06-13 23:18:12 +02:00
99acff3b8f
Restructured preferences code
2019-06-13 23:12:41 +02:00
3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
...
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
d2b3d5f220
remove german translation
2019-06-07 09:47:55 +02:00
2949fe61b6
Merge pull request #3218 from ByteHamster/mobile-download
...
Clarified mobile updates setting
2019-06-06 00:18:51 +02:00
6712711ab2
Clarified setting
2019-06-05 23:50:52 +02:00
ee1809001d
don't override summary value in PreferenceController
2019-06-04 23:58:17 +02:00
80ecfacb81
Merge pull request #3215 from ByteHamster/crashes
...
Fixed ArrayIndexOutOfBoundsException
2019-06-03 12:40:45 +02:00
83201d27df
Merge pull request #3214 from ByteHamster/work-manager-disabled-auto-update
...
Handle disabled auto update
2019-06-03 12:39:19 +02:00
ba96311e87
Fixed ArrayIndexOutOfBoundsException
2019-06-03 12:32:38 +02:00
6a83d2a434
Handle disabled auto update
2019-06-03 12:19:34 +02:00
405db1f169
Merge pull request #3164 from ByteHamster/work-manager
...
Work manager
2019-06-03 11:59:23 +02:00
8dc4c9ff56
Upgrade preferences independently from database
2019-06-03 11:56:44 +02:00
5630bf756d
Revert "Start WorkManager on upgrade"
...
This reverts commit d372aa9577
2019-06-03 11:44:18 +02:00
d372aa9577
Start WorkManager on upgrade
2019-06-03 11:31:53 +02:00
605e02fa70
add pref_episode_cache_summary
2019-06-01 18:16:47 +02:00
eb92e1144b
Merge pull request #3212 from ByteHamster/issue-template
...
Updated to new issue template file structure
2019-05-29 19:36:25 +02:00
a3a3eec675
Updated to new issue template file structure
2019-05-29 19:13:29 +02:00
f05132a716
Allow to disable auto updates
2019-05-28 18:11:12 +02:00
4443d629fc
Merge branch 'develop' into work-manager
2019-05-28 17:56:05 +02:00
H. Lehmann
Andrew Gaul
Wagubi Brian
Joe Stein
ByteHamster
Anderson Mesquita
Unknown