Commit Graph

2794 Commits

Author SHA1 Message Date
ByteHamster 0172a5db13 Nullability checks in ExoPlayerWrapper 2021-03-07 20:00:09 +01:00
ByteHamster 7a3bb825ed Fixed calling bindService if service is not running 2021-03-07 19:57:35 +01:00
ByteHamster d3bf107363 Fixed download service notification not being updated to 'Stopping service' 2021-03-06 21:00:26 +01:00
ByteHamster ef24f6d1f4 Fixed local folders ending up in DownloadService 2021-03-06 20:59:16 +01:00
ByteHamster 8426971161 Updated translations to avoid Lint error 2021-03-04 12:37:29 +01:00
ByteHamster 2e750effa1 Make errors on 'add feed' page more pretty 2021-03-04 12:10:01 +01:00
ByteHamster 6020f481c5 Mention ad blockers in certificate error message 2021-03-04 11:49:36 +01:00
ByteHamster 4872ea76f4 Show the name of failing downloads in the notification 2021-03-04 11:23:08 +01:00
ByteHamster d4141d19a0 Described download errors in more detail 2021-03-04 11:15:44 +01:00
ByteHamster 352df348cb Show dedicated error message when an app messes with the network 2021-03-04 10:45:19 +01:00
ByteHamster 878da84666 Formatted with spaces 2021-03-04 10:23:05 +01:00
ByteHamster 931941f4a3 Updated translations 2021-03-03 11:37:23 +01:00
ByteHamster 3dadbbf249
Merge pull request #4983 from ByteHamster/fix-error-message-wrong-size
Fixed wrong error message
2021-03-01 23:03:20 +01:00
ByteHamster 3bfe69219f Fixed wrong error message 2021-03-01 20:54:24 +01:00
ByteHamster 91f613b4de Fixed crash when notification updater is null 2021-03-01 19:53:41 +01:00
ByteHamster ddd6a12354 Merge branch 'master' into develop 2021-03-01 11:24:39 +01:00
ByteHamster c4f036c06c
Merge pull request #4963 from a1291762/develop
Avoid the stuck download notification
2021-03-01 10:09:28 +01:00
Lincoln Ramsay 8755a54e99 Change the message that appears when downloads are finished
In the event that the notification hangs around, this is a more
accurate description of what is happening.
2021-03-01 07:13:33 +10:00
Herbert Reiter 47a0336c3e
Refactoring: Remove Cursor related code from Feed class (#4968) 2021-02-28 14:16:07 +01:00
Lincoln Ramsay fcbbaa4060 Avoid stuck download notifications
Cancel the periodic updater before calling stopForeground so
that the notification can't come back after it has been closed.

Remove the workaround for API 30 slow notification closing because
it can cause a stuck notification. However, in order to avoid misleading
text being left on the notification if it closes slowly, ensure that
the "0 downloads" text is written to the notification when shutting down.

Fixes #4556
2021-02-28 09:34:25 +10:00
ByteHamster cc3e0c38d2 Removed DbWriter dependency from model 2021-02-26 11:10:00 +01:00
Herbert Reiter 39f9796656
Refactoring: Move inner classes PlayableUtils and PlayableException out of Playable (#4962) 2021-02-25 23:17:34 +01:00
MStrecke 519d6ce9d6
use full URL for custom gpodder server (#4932) 2021-02-25 23:08:00 +01:00
Herbert Reiter 1cd680a2af
Remove interface ImageResource (#4911) 2021-02-24 15:44:40 +01:00
ByteHamster 2c70db7074 Remove free build hack 2021-02-23 17:11:32 +01:00
ByteHamster 82dc41d813
Merge pull request #4950 from ByteHamster/fix-file-not-found
Fixed rare 'file not found' errors when starting playback
2021-02-23 10:07:38 +01:00
ByteHamster 353aeb5d8d
Merge pull request #4954 from damoasda/FeedItem-description
Improve FeedItem class documentation
2021-02-23 10:01:24 +01:00
ByteHamster 6add59819a Added auphonic files to chapter marks tests
We currently don't have a parser for the m4a file but I just committed
the file for later.
2021-02-22 17:11:40 +01:00
Herbert Reiter 8bffe2beda Improve FeedItem class documentation 2021-02-21 16:00:21 +01:00
ByteHamster 949260658b Fixed rare 'file not found' errors when starting playback
The `getPlayLastPlayedMediaIntent` method was originally added in 2013
to avoid starting the service without a media file. The bind method
should actually never need to start the service in the first place,
though.
2021-02-19 21:22:19 +01:00
ByteHamster 8fdd034e9e Added a real file to test chapters with
Thanks to the Sendegate community
https://sendegate.de/t/gesucht-beispieldateien-mit-kapitelmarken/13228
2021-02-19 14:21:44 +01:00
Yaron Shahrabani 7b39ef8953
Fixed typo
Epsiodes->Episodes
2021-02-18 00:57:48 +02:00
ByteHamster 12e22849e6 Added more id3 parser tests 2021-02-17 14:48:31 +01:00
ByteHamster 28d6551dbc Removed plural form because Transifex only allows 2 forms in English 2021-02-17 11:39:30 +01:00
ByteHamster 9e68b8b0a3 Fixed NPE when loading ogg chapters 2021-02-16 16:09:18 +01:00
ByteHamster 3f1c1c4bf5 Rewrite chapter parser for testability 2021-02-16 14:39:49 +01:00
ByteHamster 0f692be2d4
Merge pull request #4940 from ByteHamster/more-reliable-chapters
More reliable chapter loading
2021-02-16 09:39:23 +01:00
ByteHamster 4f2dcc189c Fix parsing chapters with multiple null bytes
Previously, we relied on the string to fill the complete frame.
Some podcasts terminate the string early and leave some garbage in
the frame data. Skip that garbage, so that the reader is at a valid
frame header position when starting the next iteration.
2021-02-15 23:13:29 +01:00
ByteHamster 57587c928e Removed method that does the same as loadMediaInfo anyway 2021-02-15 22:02:55 +01:00
ByteHamster 339aa936bf Removed return parameter of loadMediaInfo
We return true anyways. The call for actually loading is asynchronous,
so returning anything here does not make sense.

Reduces likelihood of loader being interrupted to just load the same
item again when the state changes.
2021-02-15 21:56:06 +01:00
Geist5000 aaeea78b37
changed the "Use Episode Cover" setting to only apply to list items. (#4908) 2021-02-15 16:04:03 +01:00
ByteHamster 42ce907aaf
Merge pull request #4936 from ByteHamster/chapter-reader
Simplified chapter reader
2021-02-15 15:21:49 +01:00
ByteHamster b1bf77d4e3 New workaround for hiding the notification directly 2021-02-15 11:44:02 +01:00
ByteHamster 4aa5443529 Refresh all feeds at once instead of sending tons of lists with 1 feed each 2021-02-15 11:43:57 +01:00
ByteHamster 52421d81f7 Removed some unnecessary calls to startForeground 2021-02-15 11:28:03 +01:00
ByteHamster 5a234a367d Simplified chapter reader
No longer uses code duplication for opening local and remote streams.
Also, switched to OkHttp to handle redirects.
2021-02-15 11:08:00 +01:00
ByteHamster 66ae028719 Merge branch 'master' into develop 2021-02-14 22:44:08 +01:00
Tony Tam f57cf0c317
New preference to show the remaining time in the 'queue' and podcast episode view (#4880) 2021-02-14 12:18:27 +01:00
ByteHamster 010ed376cd Move basic views to new module 2021-02-12 21:00:39 +01:00
ByteHamster 24ea4708ea Remove PlaybackServiceCallbacks 2021-02-12 18:08:58 +01:00