Move strings files to their own module

.tx/config

@@ -2,44 +2,44 @@
 host = https://www.transifex.com
 
 [antennapod.core-values]
-source_file = core/src/main/res/values/strings.xml
+source_file = ui/i18n/src/main/res/values/strings.xml
 source_lang = en
-trans.ar = core/src/main/res/values-ar/strings.xml
-trans.ast_ES = core/src/main/res/values-ast/strings.xml
-trans.br = core/src/main/res/values-br/strings.xml
-trans.ca = core/src/main/res/values-ca/strings.xml
-trans.cs_CZ = core/src/main/res/values-cs/strings.xml
-trans.da = core/src/main/res/values-da/strings.xml
-trans.de = core/src/main/res/values-de/strings.xml
-trans.es = core/src/main/res/values-es/strings.xml
-trans.et = core/src/main/res/values-et/strings.xml
-trans.eu = core/src/main/res/values-eu/strings.xml
-trans.fa = core/src/main/res/values-fa/strings.xml
-trans.fi = core/src/main/res/values-fi/strings.xml
-trans.fr = core/src/main/res/values-fr/strings.xml
-trans.gl = core/src/main/res/values-gl/strings.xml
-trans.he_IL = core/src/main/res/values-iw/strings.xml
-trans.hi_IN = core/src/main/res/values-hi/strings.xml
-trans.hu = core/src/main/res/values-hu/strings.xml
-trans.it_IT = core/src/main/res/values-it/strings.xml
-trans.ja = core/src/main/res/values-ja/strings.xml
-trans.ko = core/src/main/res/values-ko/strings.xml
-trans.lt = core/src/main/res/values-lt/strings.xml
-trans.nb_NO = core/src/main/res/values-nb/strings.xml
-trans.nl = core/src/main/res/values-nl/strings.xml
-trans.pl_PL = core/src/main/res/values-pl/strings.xml
-trans.pt = core/src/main/res/values-pt/strings.xml
-trans.pt_BR = core/src/main/res/values-pt-rBR/strings.xml
-trans.ro_RO = core/src/main/res/values-ro/strings.xml
-trans.ru_RU = core/src/main/res/values-ru/strings.xml
-trans.sk = core/src/main/res/values-sk/strings.xml
-trans.sl_SI = core/src/main/res/values-sl/strings.xml
-trans.sv_SE = core/src/main/res/values-sv/strings.xml
-trans.tr = core/src/main/res/values-tr/strings.xml
-trans.uk_UA = core/src/main/res/values-uk/strings.xml
-trans.zh_CN = core/src/main/res/values-zh-rCN/strings.xml
-trans.zh_TW = core/src/main/res/values-zh-rTW/strings.xml
-trans.zh_HK = core/src/main/res/values-zh-rHK/strings.xml
+trans.ar = ui/i18n/src/main/res/values-ar/strings.xml
+trans.ast_ES = ui/i18n/src/main/res/values-ast/strings.xml
+trans.br = ui/i18n/src/main/res/values-br/strings.xml
+trans.ca = ui/i18n/src/main/res/values-ca/strings.xml
+trans.cs_CZ = ui/i18n/src/main/res/values-cs/strings.xml
+trans.da = ui/i18n/src/main/res/values-da/strings.xml
+trans.de = ui/i18n/src/main/res/values-de/strings.xml
+trans.es = ui/i18n/src/main/res/values-es/strings.xml
+trans.et = ui/i18n/src/main/res/values-et/strings.xml
+trans.eu = ui/i18n/src/main/res/values-eu/strings.xml
+trans.fa = ui/i18n/src/main/res/values-fa/strings.xml
+trans.fi = ui/i18n/src/main/res/values-fi/strings.xml
+trans.fr = ui/i18n/src/main/res/values-fr/strings.xml
+trans.gl = ui/i18n/src/main/res/values-gl/strings.xml
+trans.he_IL = ui/i18n/src/main/res/values-iw/strings.xml
+trans.hi_IN = ui/i18n/src/main/res/values-hi/strings.xml
+trans.hu = ui/i18n/src/main/res/values-hu/strings.xml
+trans.it_IT = ui/i18n/src/main/res/values-it/strings.xml
+trans.ja = ui/i18n/src/main/res/values-ja/strings.xml
+trans.ko = ui/i18n/src/main/res/values-ko/strings.xml
+trans.lt = ui/i18n/src/main/res/values-lt/strings.xml
+trans.nb_NO = ui/i18n/src/main/res/values-nb/strings.xml
+trans.nl = ui/i18n/src/main/res/values-nl/strings.xml
+trans.pl_PL = ui/i18n/src/main/res/values-pl/strings.xml
+trans.pt = ui/i18n/src/main/res/values-pt/strings.xml
+trans.pt_BR = ui/i18n/src/main/res/values-pt-rBR/strings.xml
+trans.ro_RO = ui/i18n/src/main/res/values-ro/strings.xml
+trans.ru_RU = ui/i18n/src/main/res/values-ru/strings.xml
+trans.sk = ui/i18n/src/main/res/values-sk/strings.xml
+trans.sl_SI = ui/i18n/src/main/res/values-sl/strings.xml
+trans.sv_SE = ui/i18n/src/main/res/values-sv/strings.xml
+trans.tr = ui/i18n/src/main/res/values-tr/strings.xml
+trans.uk_UA = ui/i18n/src/main/res/values-uk/strings.xml
+trans.zh_CN = ui/i18n/src/main/res/values-zh-rCN/strings.xml
+trans.zh_TW = ui/i18n/src/main/res/values-zh-rTW/strings.xml
+trans.zh_HK = ui/i18n/src/main/res/values-zh-rHK/strings.xml
 
 [antennapod.description]
 source_file = app/src/main/play/listings/en-US/full-description.txt

app/build.gradle

@@ -120,6 +120,7 @@ dependencies {
     implementation project(':playback:cast')
     implementation project(':ui:app-start-intent')
     implementation project(':ui:common')
+    implementation project(':ui:i18n')
 
     annotationProcessor "androidx.annotation:annotation:$annotationVersion"
     implementation "androidx.appcompat:appcompat:$appcompatVersion"

core/build.gradle

@@ -7,9 +7,8 @@ apply from: "../playFlavor.gradle"
 android {
     lintOptions {
         disable "InvalidPeriodicWorkRequestInterval", "ObsoleteLintCustomCheck", "DefaultLocale", "UnusedAttribute",
-                "ParcelClassLoader", "Typos", "ExtraTranslation", "ImpliedQuantity", "CheckResult",
-                "PluralsCandidate", "UnusedQuantity", "StringFormatCount", "TrustAllX509TrustManager",
-                "StaticFieldLeak", "TypographyEllipsis", "IconDensities", "IconDuplicates"
+                "ParcelClassLoader", "CheckResult", "TrustAllX509TrustManager",
+                "StaticFieldLeak", "IconDensities", "IconDuplicates"
     }
 
     defaultConfig {
@@ -33,6 +32,7 @@ dependencies {
     implementation project(':playback:cast')
     implementation project(':ui:app-start-intent')
     implementation project(':ui:common')
+    implementation project(':ui:i18n')
     implementation project(':ui:png-icons')
 
     annotationProcessor "androidx.annotation:annotation:$annotationVersion"

core/lint.xml

@@ -4,12 +4,4 @@
         <ignore path="res/drawable/ic_settings.xml" />
         <ignore path="res/drawable/ic_settings_white.xml" />
     </issue>
-    
-    <issue id="MissingDefaultResource">
-        <ignore path="**/values-**/strings.xml" />
-    </issue>
-
-    <issue id="UnusedResources" severity="error">
-        <ignore path="**/values-**/strings.xml" />
-    </issue>
 </lint>

settings.gradle

@@ -15,4 +15,5 @@ include ':playback:cast'
 
 include ':ui:app-start-intent'
 include ':ui:common'
+include ':ui:i18n'
 include ':ui:png-icons'

ui/i18n/README.md

@@ -0,0 +1,3 @@
+# :ui:i18n
+
+The abbreviation i18n stands for internationalization. This module contains the app's main texts that are translated to different languages. Most modules that show UI depend on this module.

ui/i18n/build.gradle

@@ -0,0 +1,15 @@
+plugins {
+    id("com.android.library")
+}
+apply from: "../../common.gradle"
+
+android {
+    lintOptions {
+        disable "Typos", "ExtraTranslation", "ImpliedQuantity",
+                "PluralsCandidate", "UnusedQuantity", "TypographyEllipsis"
+    }
+}
+
+dependencies {
+    annotationProcessor "androidx.annotation:annotation:$annotationVersion"
+}

ui/i18n/lint.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>    
+    <issue id="MissingDefaultResource">
+        <ignore path="**/values-**/strings.xml" />
+    </issue>
+
+    <issue id="UnusedResources" severity="error">
+        <ignore path="**/values-**/strings.xml" />
+    </issue>
+</lint>

ui/i18n/src/main/AndroidManifest.xml

@@ -0,0 +1 @@
+<manifest package="de.danoeh.antennapod.ui.i18n" />