From 8feb6e087f2cd1d4bab9e2f51e777868173f4b6c Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Mon, 5 Feb 2018 00:14:39 +0100 Subject: [PATCH 1/8] Make player selectable --- app/src/main/res/layout/external_player_fragment.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/layout/external_player_fragment.xml b/app/src/main/res/layout/external_player_fragment.xml index c0eb9211f..9e8d1e3f4 100644 --- a/app/src/main/res/layout/external_player_fragment.xml +++ b/app/src/main/res/layout/external_player_fragment.xml @@ -6,7 +6,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:visibility="gone"> + android:visibility="gone" + android:background="?attr/selectableItemBackground"> Date: Mon, 5 Feb 2018 00:16:07 +0100 Subject: [PATCH 2/8] Do not flicker when pressing back arrow --- .../main/java/de/danoeh/antennapod/fragment/QueueFragment.java | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java index bf22e71f5..de9932bef 100644 --- a/app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java @@ -109,7 +109,6 @@ public class QueueFragment extends Fragment { @Override public void onResume() { super.onResume(); - recyclerView.setAdapter(recyclerAdapter); loadItems(true); EventDistributor.getInstance().register(contentUpdate); EventBus.getDefault().registerSticky(this); From 877ae455929ab445e61334d2f73f48fde4257e05 Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Tue, 13 Feb 2018 00:22:52 +0100 Subject: [PATCH 3/8] Removed useless nested layout --- .../res/layout/external_player_fragment.xml | 149 +++++++++--------- app/src/main/res/layout/main.xml | 2 +- 2 files changed, 72 insertions(+), 79 deletions(-) diff --git a/app/src/main/res/layout/external_player_fragment.xml b/app/src/main/res/layout/external_player_fragment.xml index 9e8d1e3f4..0efee08db 100644 --- a/app/src/main/res/layout/external_player_fragment.xml +++ b/app/src/main/res/layout/external_player_fragment.xml @@ -1,91 +1,84 @@ - - + + + android:layout_height="4dp" + android:layout_toRightOf="@id/imgvCover" + android:layout_toEndOf="@id/imgvCover" + android:layout_alignParentTop="true" + style="?attr/progressBarTheme" + android:indeterminate="false" + tools:progress="100"/> - + - + - + - - - - - - - + diff --git a/app/src/main/res/layout/main.xml b/app/src/main/res/layout/main.xml index c05132b42..6cabcdff2 100644 --- a/app/src/main/res/layout/main.xml +++ b/app/src/main/res/layout/main.xml @@ -6,7 +6,7 @@ android:layout_width="match_parent" android:layout_height="match_parent"> - From 2f6c9c49f81ddb735d5241026ee661a3a88b0cd2 Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Tue, 13 Feb 2018 00:45:25 +0100 Subject: [PATCH 4/8] Set background of playerFragment to same color as toolbar Most noticeable in dark theme --- app/src/main/res/layout/main.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/layout/main.xml b/app/src/main/res/layout/main.xml index 6cabcdff2..e20fe1f70 100644 --- a/app/src/main/res/layout/main.xml +++ b/app/src/main/res/layout/main.xml @@ -16,6 +16,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_alignParentBottom="true" + android:background="?attr/colorPrimary" tools:layout_height="64dp" tools:background="@android:color/holo_green_light" /> @@ -41,7 +42,6 @@ android:layout_height="0px" android:layout_above="@id/playerFragment" android:layout_below="@id/toolbar" - android:foreground="?android:windowContentOverlay" tools:background="@android:color/holo_red_dark" /> From 2fed8ff104676a09c525f52ecdb54a2cd5a67494 Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Tue, 13 Feb 2018 00:53:28 +0100 Subject: [PATCH 5/8] Darken background of feed header This change only applies to feed items using transparent backgrounds. The item is darkened but the background keeps transparent, which looks weird, especially in light theme (have a look at the 34C3 feed) --- app/src/main/res/layout/feeditemlist_header.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/res/layout/feeditemlist_header.xml b/app/src/main/res/layout/feeditemlist_header.xml index 361b583c9..01b6ea8fe 100644 --- a/app/src/main/res/layout/feeditemlist_header.xml +++ b/app/src/main/res/layout/feeditemlist_header.xml @@ -4,6 +4,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" + android:background="#5000" tools:context="de.danoeh.antennapod.activity.MainActivity" tools:background="@android:color/darker_gray"> From d376e462e710e144ef91c21b9b6dd97e6e4a4bdf Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Wed, 14 Feb 2018 11:15:15 +0100 Subject: [PATCH 6/8] Make feed title selectable --- app/src/main/res/layout/cover_fragment.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/src/main/res/layout/cover_fragment.xml b/app/src/main/res/layout/cover_fragment.xml index 05b927da4..b1e93a195 100644 --- a/app/src/main/res/layout/cover_fragment.xml +++ b/app/src/main/res/layout/cover_fragment.xml @@ -38,6 +38,7 @@ android:maxLines="2" android:ellipsize="end" android:text="Podcast" + android:textIsSelectable="true" android:textColor="?android:attr/textColorSecondary" /> @@ -61,6 +62,7 @@ android:maxLines="2" android:ellipsize="end" android:text="Episode" + android:textIsSelectable="true" android:textColor="?android:attr/textColorPrimary" /> From fcbadf1e9e76c132931b90c09d6266bb2f4f09f7 Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Tue, 20 Feb 2018 22:47:18 +0100 Subject: [PATCH 7/8] Revert "Set background of playerFragment to same color as toolbar" This reverts commit 2f6c9c49f81ddb735d5241026ee661a3a88b0cd2. --- app/src/main/res/layout/main.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/layout/main.xml b/app/src/main/res/layout/main.xml index e20fe1f70..6cabcdff2 100644 --- a/app/src/main/res/layout/main.xml +++ b/app/src/main/res/layout/main.xml @@ -16,7 +16,6 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_alignParentBottom="true" - android:background="?attr/colorPrimary" tools:layout_height="64dp" tools:background="@android:color/holo_green_light" /> @@ -42,6 +41,7 @@ android:layout_height="0px" android:layout_above="@id/playerFragment" android:layout_below="@id/toolbar" + android:foreground="?android:windowContentOverlay" tools:background="@android:color/holo_red_dark" /> From 146ec02395dc6de0cbbc394726f39c08b9880afd Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Mon, 2 Apr 2018 21:13:13 +0200 Subject: [PATCH 8/8] Extracted color resource --- app/src/main/res/layout/feeditemlist_header.xml | 2 +- core/src/main/res/values/colors.xml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/res/layout/feeditemlist_header.xml b/app/src/main/res/layout/feeditemlist_header.xml index 01b6ea8fe..c6ba80e2a 100644 --- a/app/src/main/res/layout/feeditemlist_header.xml +++ b/app/src/main/res/layout/feeditemlist_header.xml @@ -4,7 +4,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="#5000" + android:background="@color/feed_image_bg" tools:context="de.danoeh.antennapod.activity.MainActivity" tools:background="@android:color/darker_gray"> diff --git a/core/src/main/res/values/colors.xml b/core/src/main/res/values/colors.xml index 981d16d03..969500928 100644 --- a/core/src/main/res/values/colors.xml +++ b/core/src/main/res/values/colors.xml @@ -20,6 +20,7 @@ #060708 #669900 #80000000 + #50000000 #286E8A #81CFEA