Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core tests: Make DownloadServiceTest be a unit test (the portion of

Browse Source 
DownloadService tested is all in-memory logic).
This commit is contained in:
orionlee 2018-05-18 13:42:39 -07:00
parent 46ae3e0b00
commit eb0ef1e201
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java
View File

@ -7,8 +7,6 @@ import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.media.MediaMetadataRetriever;
import android.os.Binder;
import android.os.Build;
@ -1107,7 +1105,7 @@ public class DownloadService extends Service {
* that every image reference is unique.
*/
@VisibleForTesting
public static void removeDuplicateImages(Feed feed) {
static void removeDuplicateImages(Feed feed) {
Set<String> known = new HashSet<>();
for (FeedItem item : feed.getItems()) {
String url = item.hasItemImage() ? item.getImage().getDownload_url() : null;

8
core/src/androidTest/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java → core/src/test/java/de/danoeh/antennapod/core/service/download/DownloadServiceTest.java
View File

@ -1,6 +1,7 @@
package de.danoeh.antennapod.core.service.download;
import android.test.AndroidTestCase;
import org.junit.Test;
import java.util.ArrayList;
import java.util.List;
@ -9,8 +10,11 @@ import de.danoeh.antennapod.core.feed.Feed;
import de.danoeh.antennapod.core.feed.FeedImage;
import de.danoeh.antennapod.core.feed.FeedItem;
public class DownloadServiceTest extends AndroidTestCase {
import static org.junit.Assert.assertEquals;
public class DownloadServiceTest {
@Test
public void testRemoveDuplicateImages() {
List<FeedItem> items = new ArrayList<>();
for (int i = 0; i < 50; i++) {