Bump AGP and Gradle (#6489)

app/build.gradle

@@ -1,11 +1,13 @@
 plugins {
     id('com.android.application')
-    id('com.github.triplet.play') version '3.7.0' apply false
+    id('com.github.triplet.play') version '3.8.3' apply false
 }
 apply from: "../common.gradle"
 apply from: "../playFlavor.gradle"
 
 android {
+    namespace "de.danoeh.antennapod"
+
     defaultConfig {
         // Version code schema:
         // "1.2.3-beta4"    -> 1020304

app/src/main/AndroidManifest.xml

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
-    package="de.danoeh.antennapod"
     android:installLocation="auto">
 
     <uses-permission android:name="android.permission.INTERNET"/>

app/src/play/AndroidManifest.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-   package="de.danoeh.antennapod">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <application>
         <meta-data

build.gradle

@@ -5,9 +5,9 @@ buildscript {
         gradlePluginPortal()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.0'
+        classpath 'com.android.tools.build:gradle:7.4.2'
         classpath "gradle.plugin.com.github.spotbugs.snom:spotbugs-gradle-plugin:4.7.0"
-        classpath 'org.codehaus.groovy:groovy-xml:3.0.9'
+        classpath 'org.codehaus.groovy:groovy-xml:3.0.13'
     }
 }
 

core/build.gradle

@@ -5,6 +5,8 @@ apply from: "../common.gradle"
 apply from: "../playFlavor.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.core"
+
     lint {
         disable "InvalidPeriodicWorkRequestInterval", "ObsoleteLintCustomCheck", "DefaultLocale", "UnusedAttribute",
                 "ParcelClassLoader", "CheckResult", "TrustAllX509TrustManager",

core/src/main/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools" package="de.danoeh.antennapod.core">
+    xmlns:tools="http://schemas.android.com/tools">
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"

event/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.event"
+}
+
 dependencies {
     implementation project(':model')
     implementation "androidx.core:core:$coreVersion"

event/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.event" />

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
+networkTimeout=10000
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

gradlew

@@ -1,7 +1,7 @@
 #!/bin/sh
 
 #
-# Copyright © 2015-2021 the original authors.
+# Copyright © 2015-2021 the original authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -32,10 +32,10 @@
 #       Busybox and similar reduced shells will NOT work, because this script
 #       requires all of these POSIX shell features:
 #         * functions;
-#         * expansions «$var», «${var}», «${var:-default}», «${var+SET}»,
-#           «${var#prefix}», «${var%suffix}», and «$( cmd )»;
-#         * compound commands having a testable exit status, especially «case»;
-#         * various built-in commands including «command», «set», and «ulimit».
+#         * expansions «$var», «${var}», «${var:-default}», «${var+SET}»,
+#           «${var#prefix}», «${var%suffix}», and «$( cmd )»;
+#         * compound commands having a testable exit status, especially «case»;
+#         * various built-in commands including «command», «set», and «ulimit».
 #
 #   Important for patching:
 #
@@ -55,7 +55,7 @@
 #       Darwin, MinGW, and NonStop.
 #
 #   (3) This script is generated from the Groovy template
-#       https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
+#       https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
 #       within the Gradle project.
 #
 #       You can find Gradle at https://github.com/gradle/gradle/.
@@ -80,13 +80,10 @@ do
     esac
 done
 
-APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
-
-APP_NAME="Gradle"
+# This is normally unused
+# shellcheck disable=SC2034
 APP_BASE_NAME=${0##*/}
-
-# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
+APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
 
 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD=maximum
@@ -143,12 +140,16 @@ fi
 if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
     case $MAX_FD in #(
       max*)
+        # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
+        # shellcheck disable=SC3045
         MAX_FD=$( ulimit -H -n ) ||
             warn "Could not query maximum file descriptor limit"
     esac
     case $MAX_FD in  #(
       '' | soft) :;; #(
       *)
+        # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
+        # shellcheck disable=SC3045
         ulimit -n "$MAX_FD" ||
             warn "Could not set maximum file descriptor limit to $MAX_FD"
     esac
@@ -193,6 +194,10 @@ if "$cygwin" || "$msys" ; then
     done
 fi
 
+
+# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
+DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
+
 # Collect all arguments for the java command;
 #   * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
 #     shell script including quotes and variable substitutions, so put them in
@@ -205,6 +210,12 @@ set -- \
         org.gradle.wrapper.GradleWrapperMain \
         "$@"
 
+# Stop when "xargs" is not available.
+if ! command -v xargs >/dev/null 2>&1
+then
+    die "xargs is not available"
+fi
+
 # Use "xargs" to parse quoted args.
 #
 # With -n1 it outputs one arg per line, with the quotes and backslashes removed.

gradlew.bat

@@ -14,7 +14,7 @@
 @rem limitations under the License.
 @rem
 
-@if "%DEBUG%" == "" @echo off
+@if "%DEBUG%"=="" @echo off
 @rem ##########################################################################
 @rem
 @rem  Gradle startup script for Windows
@@ -25,7 +25,8 @@
 if "%OS%"=="Windows_NT" setlocal
 
 set DIRNAME=%~dp0
-if "%DIRNAME%" == "" set DIRNAME=.
+if "%DIRNAME%"=="" set DIRNAME=.
+@rem This is normally unused
 set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%
 
@@ -40,7 +41,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome
 
 set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1
-if "%ERRORLEVEL%" == "0" goto execute
+if %ERRORLEVEL% equ 0 goto execute
 
 echo.
 echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -75,13 +76,15 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
 
 :end
 @rem End local scope for the variables with windows NT shell
-if "%ERRORLEVEL%"=="0" goto mainEnd
+if %ERRORLEVEL% equ 0 goto mainEnd
 
 :fail
 rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
 rem the _cmd.exe /c_ return code!
-if  not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
-exit /b 1
+set EXIT_CODE=%ERRORLEVEL%
+if %EXIT_CODE% equ 0 set EXIT_CODE=1
+if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE%
+exit /b %EXIT_CODE%
 
 :mainEnd
 if "%OS%"=="Windows_NT" endlocal

model/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.model"
+}
+
 dependencies {
     annotationProcessor "androidx.annotation:annotation:$annotationVersion"
     implementation "androidx.media:media:$mediaVersion"

model/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.model" />

net/common/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.net.common"
+}
+
 dependencies {
     annotationProcessor "androidx.annotation:annotation:$annotationVersion"
     implementation "com.squareup.okhttp3:okhttp:$okhttpVersion"

net/common/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.net.common" />

net/discovery/build.gradle

@@ -5,6 +5,8 @@ apply from: "../../common.gradle"
 apply from: "../../playFlavor.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.net.discovery"
+
     defaultConfig {
         if (project.hasProperty("podcastindexApiKey")) {
             buildConfigField "String", "PODCASTINDEX_API_KEY", '"' + podcastindexApiKey + '"'

net/discovery/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.net.discovery" />

net/download/service-interface/build.gradle

@@ -5,6 +5,8 @@ plugins {
 apply from: "../../../common.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.net.download.serviceinterface"
+
     lint {
         disable 'ParcelClassLoader'
     }

net/download/service-interface/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.net.download.serviceinterface" />

net/ssl/build.gradle

@@ -4,6 +4,10 @@ plugins {
 apply from: "../../common.gradle"
 apply from: "../../playFlavor.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.net.ssl"
+}
+
 dependencies {
     annotationProcessor "androidx.annotation:annotation:$annotationVersion"
     implementation "androidx.appcompat:appcompat:$appcompatVersion"

net/ssl/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.net.ssl" />

net/sync/gpoddernet/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.net.sync.gpoddernet"
+}
+
 dependencies {
     implementation project(':net:sync:model')
 

net/sync/gpoddernet/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.net.sync.gpoddernet" />

net/sync/model/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.net.sync.model"
+}
+
 dependencies {
     implementation project(':model')
 

net/sync/model/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.net.sync.model" />

parser/feed/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.parser.feed"
+}
+
 dependencies {
     implementation project(':model')
 

parser/feed/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.parser.feed" />

parser/media/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.parser.media"
+}
+
 dependencies {
     implementation project(':model')
 

parser/media/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.parser.media" />

playback/base/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.playback.base"
+}
+
 dependencies {
     implementation project(':model')
 

playback/base/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.playback.base" />

playback/cast/build.gradle

@@ -4,6 +4,10 @@ plugins {
 apply from: "../../common.gradle"
 apply from: "../../playFlavor.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.playback.cast"
+}
+
 dependencies {
     implementation project(':event')
     implementation project(':model')

playback/cast/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.playback.cast" />

storage/database/build.gradle

@@ -4,6 +4,8 @@ plugins {
 apply from: "../../common.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.storage.database"
+
     lint {
         disable "StaticFieldLeak", "StringFormatCount", "StringFormatMatches", "StringFormatInvalid", "PluralsCandidate", "StringFormatTrivial"
     }

storage/database/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.storage.database" />

storage/preferences/build.gradle

@@ -4,6 +4,8 @@ plugins {
 apply from: "../../common.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.storage.preferences"
+
     lint {
         disable "StaticFieldLeak"
     }

storage/preferences/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.storage.preferences" />

ui/app-start-intent/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.ui.appstartintent"
+}
+
 dependencies {
     annotationProcessor "androidx.annotation:annotation:$annotationVersion"
 }

ui/app-start-intent/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.ui.appstartintent" />

ui/common/build.gradle

@@ -3,6 +3,10 @@ plugins {
 }
 apply from: "../../common.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.ui.common"
+}
+
 dependencies {
     implementation project(":ui:i18n")
 

ui/common/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.ui.common" />

ui/glide/build.gradle

@@ -4,6 +4,10 @@ plugins {
 apply from: "../../common.gradle"
 apply from: "../../playFlavor.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.ui.glide"
+}
+
 dependencies {
     implementation project(":model")
     implementation project(":core")

ui/glide/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.ui.glide" />

ui/i18n/build.gradle

@@ -4,6 +4,8 @@ plugins {
 apply from: "../../common.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.ui.i18n"
+
     lint {
         disable "Typos", "ExtraTranslation", "ImpliedQuantity",
                 "PluralsCandidate", "UnusedQuantity", "TypographyEllipsis"

ui/i18n/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.ui.i18n" />

ui/png-icons/build.gradle

@@ -4,6 +4,8 @@ plugins {
 apply from: "../../common.gradle"
 
 android {
+    namespace "de.danoeh.antennapod.ui.pngicons"
+
     defaultConfig {
         vectorDrawables.useSupportLibrary false
         vectorDrawables.generatedDensities = ["xhdpi"]

ui/png-icons/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.ui.pngicons" />

ui/statistics/build.gradle

@@ -4,6 +4,10 @@ plugins {
 apply from: "../../common.gradle"
 apply from: "../../playFlavor.gradle"
 
+android {
+    namespace "de.danoeh.antennapod.ui.statistics"
+}
+
 dependencies {
     implementation project(":core")
     implementation project(":event")

ui/statistics/src/main/AndroidManifest.xml

@@ -1 +0,0 @@
-<manifest package="de.danoeh.antennapod.ui.statistics" />