Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpoddernet: do not crash on unknown remote actions

Browse Source 
According to [1] and my own episode actions feed, "action":"flattr" is a
valid action.  Future-proof the episode actions code by ignoring actions
that we don't know and care about.

This fixes the

    java.lang.IllegalArgumentException: FLATTR is not a constant

exception when fetching the episode actions list.

[1]: https://gpoddernet.readthedocs.org/en/latest/api/reference/events.html
This commit is contained in:
Simon Schubert 2015-06-25 11:12:59 +02:00
parent 5e8c75a1da
commit e3d0f8fbe5
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/java/de/danoeh/antennapod/core/gpoddernet/model/GpodnetEpisodeAction.java
View File

@ -93,7 +93,12 @@ public class GpodnetEpisodeAction {
if(StringUtils.isEmpty(podcast) || StringUtils.isEmpty(episode) || StringUtils.isEmpty(actionString)) { if(StringUtils.isEmpty(podcast) || StringUtils.isEmpty(episode) || StringUtils.isEmpty(actionString)) {
return null; return null;
} }
GpodnetEpisodeAction.Action action = GpodnetEpisodeAction.Action.valueOf(actionString.toUpperCase()); GpodnetEpisodeAction.Action action;
try {
action = GpodnetEpisodeAction.Action.valueOf(actionString.toUpperCase());
} catch (IllegalArgumentException e) {
return null;
}
String deviceId = object.optString("device", ""); String deviceId = object.optString("device", "");
GpodnetEpisodeAction.Builder builder = new GpodnetEpisodeAction.Builder(podcast, episode, action) GpodnetEpisodeAction.Builder builder = new GpodnetEpisodeAction.Builder(podcast, episode, action)
.deviceId(deviceId); .deviceId(deviceId);