Do not access context in constructor

This commit is contained in:
ByteHamster 2019-10-30 18:16:04 +01:00
parent ea6b41116f
commit dd5ba4d38d

View File

@ -90,7 +90,7 @@ public class DownloadService extends Service {
private final ExecutorService syncExecutor; private final ExecutorService syncExecutor;
private final CompletionService<Downloader> downloadExecutor; private final CompletionService<Downloader> downloadExecutor;
private final DownloadRequester requester; private final DownloadRequester requester;
private final DownloadServiceNotification notificationManager; private DownloadServiceNotification notificationManager;
/** /**
* Currently running downloads. * Currently running downloads.
@ -129,7 +129,6 @@ public class DownloadService extends Service {
downloads = Collections.synchronizedList(new ArrayList<>()); downloads = Collections.synchronizedList(new ArrayList<>());
numberOfDownloads = new AtomicInteger(0); numberOfDownloads = new AtomicInteger(0);
requester = DownloadRequester.getInstance(); requester = DownloadRequester.getInstance();
notificationManager = new DownloadServiceNotification(this);
syncExecutor = Executors.newSingleThreadExecutor(r -> { syncExecutor = Executors.newSingleThreadExecutor(r -> {
Thread t = new Thread(r); Thread t = new Thread(r);
@ -170,6 +169,7 @@ public class DownloadService extends Service {
Log.d(TAG, "Service started"); Log.d(TAG, "Service started");
isRunning = true; isRunning = true;
handler = new Handler(); handler = new Handler();
notificationManager = new DownloadServiceNotification(this);
IntentFilter cancelDownloadReceiverFilter = new IntentFilter(); IntentFilter cancelDownloadReceiverFilter = new IntentFilter();
cancelDownloadReceiverFilter.addAction(ACTION_CANCEL_ALL_DOWNLOADS); cancelDownloadReceiverFilter.addAction(ACTION_CANCEL_ALL_DOWNLOADS);