From dafe821775cf794e793ca19749911204939cdd87 Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Sun, 15 Sep 2024 10:26:13 +0200 Subject: [PATCH] Modernize feed details design (#7402) --- .../ui/screen/feed/FeedInfoFragment.java | 8 +- app/src/main/res/layout/feedinfo.xml | 83 +++++---- ui/i18n/src/main/res/values/strings.xml | 15 +- .../DownloadStatisticsListAdapter.java | 8 +- .../feed/FeedStatisticsFragment.java | 72 +++++--- .../PlaybackStatisticsListAdapter.java | 8 +- .../src/main/res/layout/feed_statistics.xml | 158 +++++------------- .../main/res/layout/feed_statistics_card.xml | 28 ++++ 8 files changed, 188 insertions(+), 192 deletions(-) create mode 100644 ui/statistics/src/main/res/layout/feed_statistics_card.xml diff --git a/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedInfoFragment.java b/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedInfoFragment.java index 87636f533..a2cda28d8 100644 --- a/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedInfoFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/ui/screen/feed/FeedInfoFragment.java @@ -41,6 +41,7 @@ import de.danoeh.antennapod.model.feed.FeedFunding; import de.danoeh.antennapod.ui.glide.FastBlurTransformation; import de.danoeh.antennapod.ui.screen.feed.preferences.EditUrlSettingsDialog; import de.danoeh.antennapod.ui.statistics.StatisticsFragment; +import de.danoeh.antennapod.ui.statistics.feed.FeedStatisticsDialogFragment; import de.danoeh.antennapod.ui.statistics.feed.FeedStatisticsFragment; import io.reactivex.Completable; import io.reactivex.Maybe; @@ -120,6 +121,9 @@ public class FeedInfoFragment extends Fragment implements MaterialToolbar.OnMenu getParentFragmentManager().beginTransaction().replace(R.id.statisticsFragmentContainer, FeedStatisticsFragment.newInstance(feedId, false), "feed_statistics_fragment") .commitAllowingStateLoss(); + viewBinding.statisticsFragmentContainer.setOnClickListener(v -> + FeedStatisticsDialogFragment.newInstance(feedId, feed.getTitle()) + .show(getChildFragmentManager().beginTransaction(), "FeedStatistics")); viewBinding.statisticsButton.setOnClickListener(view -> { StatisticsFragment fragment = new StatisticsFragment(); @@ -239,12 +243,10 @@ public class FeedInfoFragment extends Fragment implements MaterialToolbar.OnMenu ((MainActivity) getActivity()).loadChildFragment(fragment, TransitionEffect.SLIDE); }); } else { - viewBinding.statisticsButton.setVisibility(View.GONE); + viewBinding.statisticsHeading.setVisibility(View.GONE); viewBinding.statisticsFragmentContainer.setVisibility(View.GONE); - viewBinding.statisticsHeadingLabel.setVisibility(View.GONE); viewBinding.supportHeadingLabel.setVisibility(View.GONE); viewBinding.supportUrl.setVisibility(View.GONE); - viewBinding.descriptionHeadingLabel.setVisibility(View.GONE); } refreshToolbarState(); diff --git a/app/src/main/res/layout/feedinfo.xml b/app/src/main/res/layout/feedinfo.xml index 7c7afa425..5ff462fa9 100644 --- a/app/src/main/res/layout/feedinfo.xml +++ b/app/src/main/res/layout/feedinfo.xml @@ -54,8 +54,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:clipToPadding="false" - android:paddingLeft="16dp" - android:paddingRight="16dp" + android:paddingHorizontal="8dp" android:paddingBottom="8dp" android:scrollbarStyle="outsideOverlay" app:layout_behavior="@string/appbar_scrolling_view_behavior"> @@ -65,82 +64,93 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingTop="16dp" android:paddingHorizontal="@dimen/additional_horizontal_spacing"> - + android:paddingHorizontal="8dp" + android:layout_marginTop="16dp" + android:orientation="horizontal"> + + + +